From: Krzysztof Kozlowski <krzk@kernel.org>
To: Charan Pedumuru <charan.pedumuru@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: dma: convert text based binding to json schema
Date: Fri, 2 May 2025 13:37:06 +0200 [thread overview]
Message-ID: <d4d91f3c-731f-44a8-8f08-1979f335b074@kernel.org> (raw)
In-Reply-To: <a701201e-c888-40e5-a57b-45ea0416af31@gmail.com>
On 02/05/2025 12:27, Charan Pedumuru wrote:
>>> + maxItems: 1
>>> +
>>> + reset-names:
>>> + const: dma
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>> And here the order is correct...
>>
Fix your email program, because it re-wraps or removes line breaks in
each quote. It is making conversation unnecessarily less readable.
>>> + - interrupts
>>> + - clocks
>> But here different. Keep the same order as in properties.
>>
>>> + - resets
>>> + - reset-names
>>> + - "#dma-cells"
>>> +
>> missing allOf: to dma-controller
>
>
> The reason, I didn't include dma-controller is the pattern under
> $nodename in dma-controller is not matching with the pattern present in
> dts files.
>
> So, I excluded it.
Then the DTS has to be changed.
Best regards,
Krzysztof
prev parent reply other threads:[~2025-05-02 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 13:12 [PATCH] dt-bindings: dma: convert text based binding to json schema Charan Pedumuru
2025-05-02 7:58 ` Krzysztof Kozlowski
2025-05-02 10:27 ` Charan Pedumuru
2025-05-02 11:37 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d4d91f3c-731f-44a8-8f08-1979f335b074@kernel.org \
--to=krzk@kernel.org \
--cc=charan.pedumuru@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=robh@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox