* [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation
@ 2021-01-05 15:47 Sebastien Laveze (OSS)
2021-01-10 3:16 ` Jakub Kicinski
0 siblings, 1 reply; 3+ messages in thread
From: Sebastien Laveze (OSS) @ 2021-01-05 15:47 UTC (permalink / raw)
To: David S . Miller, Jakub Kicinski, Rob Herring, Alexandre Torgue,
Giuseppe Cavallaro, Jose Abreu, netdev, devicetree
From: Seb Laveze <sebastien.laveze@nxp.com>
The priority field is not the queue priority (queue priority is fixed)
but a bitmask of priorities assigned to this queue.
In receive, priorities relate to tagged frames priorities.
In transmit, priorities relate to PFC frames.
Signed-off-by: Seb Laveze <sebastien.laveze@nxp.com>
---
Documentation/devicetree/bindings/net/snps,dwmac.yaml | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
index 11a6fdb657c9..9f6ba47513a7 100644
--- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
+++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
@@ -161,7 +161,8 @@ properties:
* snps,route-dcbcp, DCB Control Packets
* snps,route-up, Untagged Packets
* snps,route-multi-broad, Multicast & Broadcast Packets
- * snps,priority, RX queue priority (Range 0x0 to 0xF)
+ * snps,priority, bitmask of the tagged frames priorities assigned to
+ the queue
snps,mtl-tx-config:
$ref: /schemas/types.yaml#definitions/phandle
@@ -188,7 +189,10 @@ properties:
* snps,idle_slope, unlock on WoL
* snps,high_credit, max write outstanding req. limit
* snps,low_credit, max read outstanding req. limit
- * snps,priority, TX queue priority (Range 0x0 to 0xF)
+ * snps,priority, bitmask of the priorities assigned to the queue.
+ When a PFC frame is received with priorities matching the bitmask,
+ the queue is blocked from transmitting for the pause time specified
+ in the PFC frame.
snps,reset-gpio:
deprecated: true
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation
2021-01-05 15:47 [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation Sebastien Laveze (OSS)
@ 2021-01-10 3:16 ` Jakub Kicinski
2021-01-11 8:03 ` Sebastien Laveze
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Kicinski @ 2021-01-10 3:16 UTC (permalink / raw)
To: Sebastien Laveze (OSS)
Cc: David S . Miller, Rob Herring, Alexandre Torgue,
Giuseppe Cavallaro, Jose Abreu, netdev, devicetree
On Tue, 5 Jan 2021 16:47:48 +0100 Sebastien Laveze (OSS) wrote:
> From: Seb Laveze <sebastien.laveze@nxp.com>
>
> The priority field is not the queue priority (queue priority is fixed)
> but a bitmask of priorities assigned to this queue.
>
> In receive, priorities relate to tagged frames priorities.
>
> In transmit, priorities relate to PFC frames.
>
> Signed-off-by: Seb Laveze <sebastien.laveze@nxp.com>
Hi Sebastien, looks like this no longer applies to net could you rebase?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation
2021-01-10 3:16 ` Jakub Kicinski
@ 2021-01-11 8:03 ` Sebastien Laveze
0 siblings, 0 replies; 3+ messages in thread
From: Sebastien Laveze @ 2021-01-11 8:03 UTC (permalink / raw)
To: Jakub Kicinski
Cc: David S . Miller, Rob Herring, Alexandre Torgue,
Giuseppe Cavallaro, Jose Abreu, netdev, devicetree
On Sat, 2021-01-09 at 19:16 -0800, Jakub Kicinski wrote:
> Hi Sebastien, looks like this no longer applies to net could you
> rebase?
Hi Jakub,
Sure, no problem.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-11 8:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-01-05 15:47 [PATCH net] dt-bindings: net: dwmac: fix queue priority documentation Sebastien Laveze (OSS)
2021-01-10 3:16 ` Jakub Kicinski
2021-01-11 8:03 ` Sebastien Laveze
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).