From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ECFABC4332E for ; Tue, 2 Mar 2021 20:31:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C927964F21 for ; Tue, 2 Mar 2021 20:31:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1837024AbhCBU3u (ORCPT ); Tue, 2 Mar 2021 15:29:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47934 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1448132AbhCBRaZ (ORCPT ); Tue, 2 Mar 2021 12:30:25 -0500 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 47437C061221; Tue, 2 Mar 2021 08:53:59 -0800 (PST) Received: by mail-lj1-x22f.google.com with SMTP id a17so24833909ljq.2; Tue, 02 Mar 2021 08:53:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=faWbq/WMv3ZR1gToxIr2aLjBRTdDNxo7+ThXJjNGaIo=; b=hmBekdGUxUExGQJ6JMFq6hE1MDzFwReePVI8GOf5z4T/95msnW4QO3MIEmsO/NaKEZ LQfdb7pOMUeCUrqJguC1IlMp+uzDJsrDME3ZJ4TsZsp8DARjnnLKhq2geD/GpRoRy+qk cK4b3GUoy4msSiT31Kdapphy7vtzuw8gdONd1mdwu2R8etVGOFwIvxuofeUW0ov7Kxv2 +N+ERu2Szxo46lPTqNtzQbUcmsKEovWNcqH4YXgOc9MWnQmlPjDlE5Y1jvsqYLYljb7x HmARZIYImzMPiiltdmcOdY6Jm7gSjKsYT2xwxXTTekQIGMZxxulQAND9KJOoHvar31hO 91uQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=faWbq/WMv3ZR1gToxIr2aLjBRTdDNxo7+ThXJjNGaIo=; b=AjMM2zPLZ0vA7OXF6y4anfSf53FrNJyWkGmrR6ptVFk2aOccYsbI+mTSmCaVcibxTr 3IVNoyVEGNGwdzCGps9EUD2NT7ElxWX5wZIAvGdqJaQBmMg2D4Hy77qgV2tRG/fIZNNJ VYJqJ4SkrtVW7iDIPVWn1sEWw6w+wGRhUG/YFc+fQHmOgmS/HgHtOz6ECDx+d35oYGwO BII8h+qoDWr7nZxJpOT3PJ/54Fg19ARzcA72XhsicGczuwka5iAwkGf6PLXLdNU+JjPv 3zAMPf+EpSSUbfNv2Nd58vZtivoe/M4Fi+kSXQwqoR83bRJp0GGA8LZqCnmimVVX96ZF GXIw== X-Gm-Message-State: AOAM5304r+NFavhdWBDLKx/xSnbexHrUyspzRz/LrDZU9zEeA15LYcEv 1xO1Wr0FVazDFkhcLfF60vw= X-Google-Smtp-Source: ABdhPJw/W01gIjsqpMNr8JSw/9SiRbUKcitCde7eXbhpqsWpDs9pwVC/y07CdIyBdlketTmha75GtQ== X-Received: by 2002:a2e:2e19:: with SMTP id u25mr38659lju.487.1614704037798; Tue, 02 Mar 2021 08:53:57 -0800 (PST) Received: from localhost.localdomain (ip-194-187-74-233.konfederacka.maverick.com.pl. [194.187.74.233]) by smtp.googlemail.com with ESMTPSA id g2sm2894780ljk.15.2021.03.02.08.53.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Mar 2021 08:53:56 -0800 (PST) Subject: Re: [PATCH v2 1/3] mtd: partitions: ofpart: skip subnodes parse with compatible To: Ansuel Smith , Richard Weinberger Cc: devicetree@vger.kernel.org, Vignesh Raghavendra , Boris Brezillon , linux-kernel@vger.kernel.org, Rob Herring , linux-mtd@lists.infradead.org, Miquel Raynal References: <20210216212638.28382-1-ansuelsmth@gmail.com> <20210216212638.28382-2-ansuelsmth@gmail.com> From: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= Message-ID: Date: Tue, 2 Mar 2021 17:53:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <20210216212638.28382-2-ansuelsmth@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16.02.2021 22:26, Ansuel Smith wrote: > If a partitions structure is not used, parse direct subnodes as > fixed-partitions only if a compatible is not found or is of type > fixed-partition. A parser can be used directly on the subnode and > subnodes should not be parsed as fixed-partitions by default. > > Signed-off-by: Ansuel Smith > --- > drivers/mtd/parsers/ofpart.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/mtd/parsers/ofpart.c b/drivers/mtd/parsers/ofpart.c > index daf507c123e6..4b363dd0311c 100644 > --- a/drivers/mtd/parsers/ofpart.c > +++ b/drivers/mtd/parsers/ofpart.c > @@ -50,6 +50,11 @@ static int parse_fixed_partitions(struct mtd_info *master, > master->name, mtd_node); > ofpart_node = mtd_node; > dedicated = false; > + > + /* Skip parsing direct subnodes if a compatible is found and is not fixed-partitions */ > + if (node_has_compatible(ofpart_node) && > + !of_device_is_compatible(ofpart_node, "fixed-partitions")) > + return 0; > } else if (!of_device_is_compatible(ofpart_node, "fixed-partitions")) { > /* The 'partitions' subnode might be used by another parser */ > return 0; I admit I'm not familiar with the old binding, so let me know if my understanding is incorrect. It seems to me however that your change will break parsing in cases like: spi-flash@0 { compatible = "jedec,spi-nor"; reg = <0x0>; partition@0 { label = "bootloader"; reg = <0x0 0x100000>; }; }; nandcs@0 { compatible = "brcm,nandcs"; reg = <0>; partition@0 { label = "bootloader"; reg = <0x0000000 0x10000>; }; }; Did we ever use "fixed-partitions" without partitions { } subnode?