[PATCH 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[PATCH 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Sriranjani P]

FSD SoC has three sysreg nodes one in PERIC block and other two are in
FSYS0 and FSYS1 block. This patch series add required DT binding and
DT file modifications.

Sriranjani P (2):
  dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC
  arm64: dts: fsd: add sysreg device node

 Documentation/devicetree/bindings/mfd/syscon.yaml |  1 +
 arch/arm64/boot/dts/tesla/fsd.dtsi                | 15 +++++++++++++++
 2 files changed, 16 insertions(+)

-- 
2.17.1

[PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Sriranjani P]

Describe the compatible properties for Tesla SYSREG controllers found on
FSD SoC.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 4e4baf53796d..8c3334999bec 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -69,6 +69,7 @@ properties:
               - samsung,exynos5433-sysreg
               - samsung,exynos850-sysreg
               - samsung,exynosautov9-sysreg
+              - tesla,fsd-sysreg
 
           - const: syscon
 
-- 
2.17.1

Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Lee Jones]

On Mon, 21 Nov 2022, Sriranjani P wrote:

> Describe the compatible properties for Tesla SYSREG controllers found on
> FSD SoC.

Not much describing going on here.

> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>

Struggling to imagine how it took 5 of you to author a single line
patch.

> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 4e4baf53796d..8c3334999bec 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -69,6 +69,7 @@ properties:
>                - samsung,exynos5433-sysreg
>                - samsung,exynos850-sysreg
>                - samsung,exynosautov9-sysreg
> +              - tesla,fsd-sysreg
>  
>            - const: syscon
>  

-- 
Lee Jones [李琼斯]

RE: [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC

[Sriranjani P]

> -----Original Message-----
> From: Lee Jones [mailto:lee@kernel.org]
> Sent: 21 November 2022 17:55
> To: Sriranjani P <sriranjani.p@samsung.com>
> Cc: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com; linux-
> kernel@vger.kernel.org; Vivek Yadav <vivek.2311@samsung.com>
> Subject: Re: [PATCH 1/2] dt-bindings: mfd: syscon: Add tesla compatibles
> found on FSD SoC
> 
> On Mon, 21 Nov 2022, Sriranjani P wrote:
> 
> > Describe the compatible properties for Tesla SYSREG controllers found
> > on FSD SoC.
> 
> Not much describing going on here.
> 
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Signed-off-by: Ravi Patel <ravi.patel@samsung.com>
> > Signed-off-by: Vivek Yadav <vivek.2311@samsung.com>
> > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> 
> Struggling to imagine how it took 5 of you to author a single line patch.
[Sriranjani P] Previous version of this patch had some yaml changes, I amended the new changes in the same patch and posted it, forgot to remove the sign off.
Will fix it in the next version.
> 
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 4e4baf53796d..8c3334999bec 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -69,6 +69,7 @@ properties:
> >                - samsung,exynos5433-sysreg
> >                - samsung,exynos850-sysreg
> >                - samsung,exynosautov9-sysreg
> > +              - tesla,fsd-sysreg
> >
> >            - const: syscon
> >
> 
> --
> Lee Jones [李琼斯]
[Sriranjani P] Thank you 

[PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Sriranjani P]

Add SYSREG controller device node, which is available in PERIC, FSYS0 and
FSYS1 block of FSD SoC.

Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
---
 arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
index f35bc5a288c2..db78816ba0bf 100644
--- a/arch/arm64/boot/dts/tesla/fsd.dtsi
+++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
@@ -518,6 +518,21 @@
 				"dout_cmu_fsys1_shared0div4";
 		};
 
+		sysreg_peric: syscon@14030000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x14030000 0x0 0x1000>;
+		};
+
+		sysreg_fsys0: syscon@15030000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x15030000 0x0 0x1000>;
+		};
+
+		sysreg_fsys1: syscon@16830000 {
+			compatible = "tesla,fsd-sysreg", "syscon";
+			reg = <0x0 0x16830000 0x0 0x1000>;
+		};
+
 		mdma0: dma-controller@10100000 {
 			compatible = "arm,pl330", "arm,primecell";
 			reg = <0x0 0x10100000 0x0 0x1000>;
-- 
2.17.1

Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Krzysztof Kozlowski]

On 21/11/2022 10:11, Sriranjani P wrote:
> Add SYSREG controller device node, which is available in PERIC, FSYS0 and
> FSYS1 block of FSD SoC.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> ---
>  arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi b/arch/arm64/boot/dts/tesla/fsd.dtsi
> index f35bc5a288c2..db78816ba0bf 100644
> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> @@ -518,6 +518,21 @@
>  				"dout_cmu_fsys1_shared0div4";
>  		};
>  
> +		sysreg_peric: syscon@14030000 {

Node name system-controller
and either put it next to existing one or next to functional block
(peric clocks?) ordered by unit address.

> +			compatible = "tesla,fsd-sysreg", "syscon";
> +			reg = <0x0 0x14030000 0x0 0x1000>;
> +		};

Best regards,
Krzysztof

RE: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Sriranjani P]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 November 2022 17:58
> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
> 
> On 21/11/2022 10:11, Sriranjani P wrote:
> > Add SYSREG controller device node, which is available in PERIC, FSYS0
> > and
> > FSYS1 block of FSD SoC.
> >
> > Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> > Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> > Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> > ---
> >  arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > index f35bc5a288c2..db78816ba0bf 100644
> > --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> > +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> > @@ -518,6 +518,21 @@
> >  				"dout_cmu_fsys1_shared0div4";
> >  		};
> >
> > +		sysreg_peric: syscon@14030000 {
> 
> Node name system-controller
[Sriranjani P] Will fix it in the next version. We added “syscon” since I referred other dtsi files in mainline for example exynosautov9.dtsi used syscon as node name. If this is the name we should add then I’ll post few more patches fixing this node name in other Exynos dtsi files.
> and either put it next to existing one or next to functional block (peric
> clocks?) ordered by unit address.
[Sriranjani P] We thought of it but as I saw current fsd.dtsi file and other exynos file like exynosautov9.dtsi, in that nodes are not properly arranged as per unit address.

So I can think of following two approaches: 
1: For the time being I will put this sysreg node in between clock_peric node and clock_fysys0 node and clock_fsys1 node as per increasing unit address. I will clean up other exynos and FSD DTSI files and post a new patch 
2: First I will clean up exynos and FSD DTSI files and then post this sysreg patch keeping it at appropriate place. 

Please let me know which way it will be more appropriate.
> 
> > +			compatible = "tesla,fsd-sysreg", "syscon";
> > +			reg = <0x0 0x14030000 0x0 0x1000>;
> > +		};
> 
> Best regards,
> Krzysztof
[Sriranjani P] Thank you for reviewing the patch.

Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Krzysztof Kozlowski]

On 23/11/2022 12:57, Sriranjani P wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: 21 November 2022 17:58
>> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
>> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
>> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
>> pankaj.dubey@samsung.com; ravi.patel@samsung.com
>> Cc: linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
>>
>> On 21/11/2022 10:11, Sriranjani P wrote:
>>> Add SYSREG controller device node, which is available in PERIC, FSYS0
>>> and
>>> FSYS1 block of FSD SoC.
>>>
>>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
>>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
>>> ---
>>>  arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
>>>  1 file changed, 15 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> index f35bc5a288c2..db78816ba0bf 100644
>>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
>>> @@ -518,6 +518,21 @@
>>>  				"dout_cmu_fsys1_shared0div4";
>>>  		};
>>>
>>> +		sysreg_peric: syscon@14030000 {
>>
>> Node name system-controller
> [Sriranjani P] Will fix it in the next version. We added “syscon” since I referred other dtsi files in mainline for example exynosautov9.dtsi used syscon as node name. If this is the name we should add then I’ll post few more patches fixing this node name in other Exynos dtsi files.

Use proper wrapping for mailing lists. It's difficult to read your emails.

>> and either put it next to existing one or next to functional block (peric
>> clocks?) ordered by unit address.
> [Sriranjani P] We thought of it but as I saw current fsd.dtsi file and other exynos file like exynosautov9.dtsi, in that nodes are not properly arranged as per unit address.

I know, that's why I proposed to order by unit address within other
syscons or other functional blocks (e.g. peric-related).

> 
> So I can think of following two approaches: 
> 1: For the time being I will put this sysreg node in between clock_peric node and clock_fysys0 node and clock_fsys1 node as per increasing unit address. I will clean up other exynos and FSD DTSI files and post a new patch 

Not sure what cleaning you have in mind.

> 2: First I will clean up exynos and FSD DTSI files and then post this sysreg patch keeping it at appropriate place. 

What cleaning?

Best regards,
Krzysztof

RE: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Sriranjani P]

> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 23 November 2022 18:43
> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> pankaj.dubey@samsung.com; ravi.patel@samsung.com
> Cc: linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
> 
> On 23/11/2022 12:57, Sriranjani P wrote:
> >
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> >> Sent: 21 November 2022 17:58
> >> To: Sriranjani P <sriranjani.p@samsung.com>; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; lee@kernel.org;
> >> devicetree@vger.kernel.org; alim.akhtar@samsung.com;
> >> pankaj.dubey@samsung.com; ravi.patel@samsung.com
> >> Cc: linux-kernel@vger.kernel.org
> >> Subject: Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node
> >>
> >> On 21/11/2022 10:11, Sriranjani P wrote:
> >>> Add SYSREG controller device node, which is available in PERIC,
> >>> FSYS0 and
> >>> FSYS1 block of FSD SoC.
> >>>
> >>> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> >>> Signed-off-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >>> Signed-off-by: Sriranjani P <sriranjani.p@samsung.com>
> >>> ---
> >>>  arch/arm64/boot/dts/tesla/fsd.dtsi | 15 +++++++++++++++
> >>>  1 file changed, 15 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> index f35bc5a288c2..db78816ba0bf 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> @@ -518,6 +518,21 @@
> >>>  				"dout_cmu_fsys1_shared0div4";
> >>>  		};
> >>>
> >>> +		sysreg_peric: syscon@14030000 {
> >>
> >> Node name system-controller
> > [Sriranjani P] Will fix it in the next version. We added “syscon” since I
> referred other dtsi files in mainline for example exynosautov9.dtsi used
> syscon as node name. If this is the name we should add then I’ll post few
> more patches fixing this node name in other Exynos dtsi files.
> 
> Use proper wrapping for mailing lists. It's difficult to read your emails.

Sorry for the confusion. I have fixed my email client now.

> 
> >> and either put it next to existing one or next to functional block
> >> (peric
> >> clocks?) ordered by unit address.
> > [Sriranjani P] We thought of it but as I saw current fsd.dtsi file and other
> exynos file like exynosautov9.dtsi, in that nodes are not properly arranged as
> per unit address.
> 
> I know, that's why I proposed to order by unit address within other syscons
> or other functional blocks (e.g. peric-related).

Got it. I'll move the sysreg nodes near to their functional blocks and order them by unit address.

> 
> >
> > So I can think of following two approaches:
> > 1: For the time being I will put this sysreg node in between
> > clock_peric node and clock_fysys0 node and clock_fsys1 node as per
> > increasing unit address. I will clean up other exynos and FSD DTSI
> > files and post a new patch
> 
> Not sure what cleaning you have in mind.
> 
> > 2: First I will clean up exynos and FSD DTSI files and then post this sysreg
> patch keeping it at appropriate place.
> 
> What cleaning?

By cleaning I meant fixing these dtsi files to have the device nodes in the order of ascending unit address.

> 
> Best regards,
> Krzysztof

Thank you.

Re: [PATCH 2/2] arm64: dts: fsd: add sysreg device node

[Krzysztof Kozlowski]

On 23/11/2022 14:40, Sriranjani P wrote:
>>
>>>
>>> So I can think of following two approaches:
>>> 1: For the time being I will put this sysreg node in between
>>> clock_peric node and clock_fysys0 node and clock_fsys1 node as per
>>> increasing unit address. I will clean up other exynos and FSD DTSI
>>> files and post a new patch
>>
>> Not sure what cleaning you have in mind.
>>
>>> 2: First I will clean up exynos and FSD DTSI files and then post this sysreg
>> patch keeping it at appropriate place.
>>
>> What cleaning?
> 
> By cleaning I meant fixing these dtsi files to have the device nodes in the order of ascending unit address.

Such cleanup is fine.

Best regards,
Krzysztof

Re: [PATCH 0/2] arm64: dts: Add SYSREG nodes for FSD SoC

[Krzysztof Kozlowski]

On 21/11/2022 10:11, Sriranjani P wrote:
> FSD SoC has three sysreg nodes one in PERIC block and other two are in
> FSYS0 and FSYS1 block. This patch series add required DT binding and
> DT file modifications.
> 
> Sriranjani P (2):
>   dt-bindings: mfd: syscon: Add tesla compatibles found on FSD SoC
>   arm64: dts: fsd: add sysreg device node
> 
>  Documentation/devicetree/bindings/mfd/syscon.yaml |  1 +
>  arch/arm64/boot/dts/tesla/fsd.dtsi                | 15 +++++++++++++++

This does not CC necessary lists and folks, but that's MAINTAINERS or
get_maintainers.pl fault. I sent a patch for it.

Best regards,
Krzysztof