From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DACCB3815D2 for ; Thu, 29 Jan 2026 10:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769682781; cv=none; b=WREqBLWzYDGIl0ndI+aOZZSpn3soyaZkzWU6mjtU8DcrHnuqCygEqKku3FZNytB5Cu8viWWEJq3iaXyMYUCBa5BkORH96HXoy3b76p/p/GjUXvmcIIRxZiU6XemJpA0pgfRaTrxAWsZ2Dhdxv/fqqXJqnx2eYAwn4l9itHxVVt0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769682781; c=relaxed/simple; bh=oHUBI5wS+aYJL2pSTSPoeDZI/0I7Pb1vC66WMf2UeKs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=SOTK+JZ9RgCVbagU9pHQQjuDUEwX+TjvnYQNzKEIEYF1lvGkfrkxUcV956oWgMft9BFhgME7B2qNYBCbZyMpkQFVtzOj68XO/1UIvFM0T3HlyR3miyHYB8UbZ2nf8QMwU7X1a6XJPIasNX+L/qam1Ka1LhXPDMWVhZa6tkiSjiw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=l9eJcJqp; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=fRd7mZOR; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="l9eJcJqp"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="fRd7mZOR" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60TAKZPl3674068 for ; Thu, 29 Jan 2026 10:32:59 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= QOqjZJLJs5gDvla8rd+g87KJ7IFJ9OH5vIIsz79XB14=; b=l9eJcJqpeAyL/FcO eLuOK5UqvtcuTcOyqwvuSg8RziAkLr8vArhI2m/n1nOOfYhVn+AhMabtCB2LgjeY +zmTV26rzesBegTjfcTIBA0S0Mh8ee4CfJpfiVNWxKLdM56n/TzRUV9IM+u45fGO VVaHJ92/spmzL5v6DB7IU5DER9I5vYeLIyRcT1uWsMh599RnKtZ73qHti79k1gnf JhXGkn5X+kOFFrnLaoGJCIc74/GAgwJkWqoi/ZwfQeBVKxw6hUtQJ+iDGlgzdSKm HY7gyQB3sP00RF7MPK4N3N7kvufUGOTf0wNYKglFPhpHZTB7jylcx4aR99z+CJqI PZgQTA== Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4c05q7g13g-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 29 Jan 2026 10:32:58 +0000 (GMT) Received: by mail-qv1-f69.google.com with SMTP id 6a1803df08f44-89496f5086dso2571166d6.3 for ; Thu, 29 Jan 2026 02:32:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769682778; x=1770287578; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QOqjZJLJs5gDvla8rd+g87KJ7IFJ9OH5vIIsz79XB14=; b=fRd7mZORvcWInMNOl3dy51fRXsZEaR9jQH2LsrWym7ngFd85xjKRwzz7L5AqRBKHot ZoC2vsxxzNUcyk+bI3nnNg1uPgr7fFyLsMBN7nD4Zoo+MjnlPzJcrIeRgRGeYt+Y3mUP mWIx62y6Rcm2Sg85OWk9cOSc+rXAAYEsN3JHDycrrbI4v8zUIP7Or/B4liDl/P9AKON+ FP2lY/qxne9fNezCUUsrKJnyeVAMWfDzA8UOMO0cB9nfStN/c038uCLBoAFDmlXlJSX2 /a4yC1URnniASC48U87cEGesiZsGHqmj7D3G15BXp0xJmEIrJmo+RWPryWFaJ/m/9p5M 4utQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769682778; x=1770287578; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=QOqjZJLJs5gDvla8rd+g87KJ7IFJ9OH5vIIsz79XB14=; b=YZHs6uVkjNiJuY8Lez451qUSkpctaNLPVcFs5UF9Tmt7/n7iyqQT390E82ge8N+czM dC/yqFKTFKo0nUX32+3RJGRrkxraPzAVzwrz9CxEjEM76SUSJceNVoyFOG9mqFoqAYjh iYDwxJU83Vewv/6bbngBUof+19E0YjPS/bmx1A/Vg2fXFuf7abvXLSwfNX/3M2KalPh5 0M6l0h6wh6snDdCKdH7e6wETtet9tE5bSYk3OecLxWE0L3YUVJ73tgxQ8qYjfNWq3scd M436eyGEJbxgJbZJx96eiPca9BZpGV93rgtpS6baWZWalvq6F1vEF+HyiqvI/hembob5 4I1Q== X-Forwarded-Encrypted: i=1; AJvYcCW7tcgCRUTofZBd2/P94y1Uhyzaz8lqh7nESTZVAhMNh+KEhFdfLZvyc/DT763Wr+abkT/9A8woqFf4@vger.kernel.org X-Gm-Message-State: AOJu0Yz04d94BiXIDD2T9xZPK6SZHjzaYlsk1TkVpvio27mebgHirJVH mOrWBESFLtHX+xEpiBr+bggCQV1d+lY1H/MNLOiiM4gZdS86mswZV4DVnQl32bl4y6zs/MNLY7a +CXyErYh7KBB1fd5QAWU6bv2U+MCgEJIFp/Y3LRkh02XCSRllraxlW6u6HBnWcyD/ X-Gm-Gg: AZuq6aLgPmAhhEyShsZr5GMXys0LcKBMR+D1nUOnKc/9GM65AKAGfAEV0zOw7L0TDGQ Ucn33R8RRWfXZyqIOm6WH2eu6FlQoiFLImGapuWnTSHJ6O3gWY/HARqwD8Ovn++r70UWVOaKFLk Q4v+Hj5mILvK3ncQhJVb6O9bw2nlZQhvPeQOJIQ4YjwfLKEzD6JxzHXohElhMk3BsW+1GOLI5NA 3E/d9OKsc7zLpt9PUiiIMoZ+6mGlHdGbxd/EjZCB0/fpcqadz6pPoQiPIDr8UVIysQk11kCQW19 s32u0//f9GeiP/YLIfXbVEHM0bRsHkmvJyxs9U+OXcr0qb/ZCmTAcd+QUxiP18YDVIcFpo5Ra+p i3VEIQelKpKBOL30eNpMm6vwSR0Ki1Pc4B+e4zifw0qLA6H1ibNm8EqBGkFA836G77Hw= X-Received: by 2002:a05:620a:44d1:b0:8c6:2539:dcda with SMTP id af79cd13be357-8c714b4f97amr512809085a.2.1769682777838; Thu, 29 Jan 2026 02:32:57 -0800 (PST) X-Received: by 2002:a05:620a:44d1:b0:8c6:2539:dcda with SMTP id af79cd13be357-8c714b4f97amr512807285a.2.1769682777472; Thu, 29 Jan 2026 02:32:57 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbefc69ebsm244806166b.20.2026.01.29.02.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jan 2026 02:32:56 -0800 (PST) Message-ID: Date: Thu, 29 Jan 2026 11:32:54 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] dt-bindings: interconnect: qcom,qcs8300-rpmh: add clocks property to enable QoS To: Odelu Kukatla , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: Raviteja Laggyshetty , Dmitry Baryshkov , Bartosz Golaszewski , linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Mike Tipton References: <20260127090116.1438780-1-odelu.kukatla@oss.qualcomm.com> <20260127090116.1438780-2-odelu.kukatla@oss.qualcomm.com> <5b62fc63-314e-40a0-a975-9df75ec49e9a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: HdHN5zt4ID3ke9x8TXKkMyRiUQiVOln- X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI5MDA2OSBTYWx0ZWRfX1P/li8lQcDgP JQa9+8h9ClLPwXPxk5o71Tf1oCvPRtoooQXVdJ3tQmYcB76z4IMgPcxWzyP5RkeYx7OarWQ4vlU 39Iewazo1OFgea1AkR9Xxwe0yNdJiar6xWwP57Kmjh4E5SHbdhFvxXMvU2dYLKaHSghJ5dkcy7a 7fW3FYk79CiLPC1UOGds3aygV5/a/xyt8ylZ83qJNu3nwJ7dZe7PdUX3ieFUqa0RKQF71UkpTXD u+4c1n7Y7vKi8Rv7dJsydVHAtscjWtFAe/WXQxwGuhv0gE6/0lFQMdfbjGV378pdYHlfHcmN/X/ C84KaQ20ZtDHVavGXCGXDDWIttEuYaZP3uwQ+GbGxb+uWldamrwAc1QqdErC4ZiYv9rQOx00cX+ vvB/xP2+WHmJtC/Y7yCwKJyXkxiVzdByf9e6/VSV69dVUb3T4YHWRpfAljIEm6uXYvnTFf+iuE0 BhydY4emc2WYyMi55AA== X-Authority-Analysis: v=2.4 cv=donWylg4 c=1 sm=1 tr=0 ts=697b375a cx=c_pps a=wEM5vcRIz55oU/E2lInRtA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=WMlQ1W5rKAuT8PP_VscA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=OIgjcC2v60KrkQgK7BGD:22 X-Proofpoint-ORIG-GUID: HdHN5zt4ID3ke9x8TXKkMyRiUQiVOln- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-29_02,2026-01-28_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 clxscore=1015 suspectscore=0 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 malwarescore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601290069 On 1/29/26 11:10 AM, Odelu Kukatla wrote: > > > On 1/27/2026 4:24 PM, Konrad Dybcio wrote: >> On 1/27/26 10:01 AM, Odelu Kukatla wrote: >>> Some QCS8300 interconnect nodes have QoS registers located inside >>> a block whose interface is clock-gated. For those nodes, driver >>> must enable the corresponding clock(s) before accessing the >>> registers. Add the 'clocks' property so the driver can obtain >>> and enable the required clock(s). >>> >>> Only interconnects that have clock‑gated QoS register interface >>> use this property; it is not applicable to all interconnect nodes. >>> >>> Signed-off-by: Odelu Kukatla >>> --- [...] >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,qcs8300-aggre2-noc >>> + then: >>> + properties: >>> + clocks: >>> + items: >>> + - description: RPMH CC IPA clock >> >> LeMans also has ufscard clk here >> > > For aggre2 noc, QCS8300 does not integrate the ufscard controller > present on LeMans, so that clock is not part of the QCS8300 hardware. > The only QoS relevant clock on this node for QCS8300 is the RPMH CC IPA > clock, which is why only that one appears in the binding. Ohhh I forgot UFSCard translated to UFS1.. >>> + >>> + - if: >>> + properties: >>> + compatible: >>> + contains: >>> + enum: >>> + - qcom,qcs8300-gem-noc >>> + then: >>> + properties: >>> + clocks: >>> + items: >>> + - description: GCC DDRSS GPU AXI clock >> >> and lacks this one >> >> Are there actual reasons for these differences? >> > > The gem noc QoS interface on QCS8300 requires the DDRSS GPU AXI clock to > be enabled for QoS register access, so it is listed in the binding. The > difference is therefore due to SoC level differences. Alright, thanks Konrad