From: Krzysztof Kozlowski <krzk@kernel.org>
To: 郑豪威 <zhenghaowei@loongson.cn>,
gregkh@linuxfoundation.org, jirislaby@kernel.org,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
chenhuacai@kernel.org, kernel@xen0n.name, p.zabel@pengutronix.de
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, loongarch@lists.linux.dev
Subject: Re: [PATCH v2 2/3] tty: serial: 8250: Add loongson uart driver support
Date: Fri, 9 Aug 2024 07:57:05 +0200 [thread overview]
Message-ID: <d52861ee-26a3-4673-8aae-9859d435f817@kernel.org> (raw)
In-Reply-To: <77b249fd-3cf7-4cb4-a2b4-64c0c2ba96fa@loongson.cn>
On 07/08/2024 10:24, 郑豪威 wrote:
>>> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> + if (!res)
>>> + return -ENODEV;
>>> +
>>> + port->membase = devm_ioremap(&pdev->dev, res->start, resource_size(res));
>>> + if (!port->membase)
>>> + return -ENOMEM;
>>> +
>> Use wrapper combining both calls.
>
> I got it, did you mean like this?
>
> + res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> + if (!res)
> + return -ENODEV;
> +
> + port->mapbase = res->start;
> + port->mapsize = resource_size(res);
> +
> + port->membase = devm_ioremap(&pdev->dev, port->mapbase, port->mapsize);
> + if (!port->membase)
> + return -ENOMEM;
I still see two calls, so how are they combined? Just open any other
file and see how it is done there.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-08-09 5:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-04 6:38 [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller zhenghaowei
2024-08-04 6:38 ` [PATCH v2 2/3] tty: serial: 8250: Add loongson uart driver support zhenghaowei
2024-08-04 7:13 ` Christophe JAILLET
2024-08-04 15:11 ` kernel test robot
2024-08-04 15:33 ` Krzysztof Kozlowski
2024-08-07 8:24 ` 郑豪威
2024-08-09 5:57 ` Krzysztof Kozlowski [this message]
2024-08-04 16:42 ` kernel test robot
2024-08-04 6:38 ` [PATCH v2 3/3] LoongArch: dts: Update UART driver to Loongson-2K0500, Loongson-2K1000 and Loongson-2K2000 zhenghaowei
2024-08-04 8:40 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-04 7:23 ` [PATCH v2 1/3] dt-bindings: serial: Add Loongson UART controller Rob Herring (Arm)
2024-08-04 8:41 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-04 8:43 ` Krzysztof Kozlowski
2024-08-07 8:23 ` 郑豪威
2024-08-07 8:39 ` Xi Ruoyao
2024-08-07 9:01 ` 郑豪威
2024-08-09 5:53 ` Krzysztof Kozlowski
2024-08-09 9:55 ` 郑豪威
2024-08-09 10:05 ` Krzysztof Kozlowski
2024-08-12 8:09 ` 郑豪威
2024-08-12 8:25 ` Krzysztof Kozlowski
2024-08-25 3:34 ` 郑豪威
2024-08-25 6:55 ` Krzysztof Kozlowski
2024-08-25 8:24 ` 郑豪威
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d52861ee-26a3-4673-8aae-9859d435f817@kernel.org \
--to=krzk@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=kernel@xen0n.name \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=zhenghaowei@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).