From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27631EB64DD for ; Thu, 17 Aug 2023 11:40:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348069AbjHQLjv (ORCPT ); Thu, 17 Aug 2023 07:39:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36064 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350372AbjHQLjW (ORCPT ); Thu, 17 Aug 2023 07:39:22 -0400 Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FE14E55 for ; Thu, 17 Aug 2023 04:39:20 -0700 (PDT) Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fe5c0e5747so5609575e9.0 for ; Thu, 17 Aug 2023 04:39:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1692272359; x=1692877159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=TTEZsdCY4/ROvTDegYueu3UoNKVTo+C9n4Jn+JaTP2o=; b=oX5yPVth+PHIjocLUBndePdGLypDvYq2solc5BzuflSzikrFXb3kjbOOxCzeIXUOc2 eMRRn1Y5UkU4Y7HoKz9ahfaZy2mVS5ClWAtrqtSr5TZ+Zxe/kyZM8J1YkzTb+9LS5T7c iEawd+lQth5ZCOZC1GA5tHDPx4dG/nU+F9hV4Rg4zFa/seAonVVXc7XYFbWzxdN7l/yi yZ2YYFXEsbbBOg2qRfFt9dPWobIgklKKF1O9yB5b/8u4n3ehRrRCpcqoojzhPe5mG2Ae KqeCVbtlKG4lP6k/0BhYNtRVHXy7GVEcVY2etFpfdOQmrcff1COpd+rvL+gcXg/Vg1+n yWjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692272359; x=1692877159; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TTEZsdCY4/ROvTDegYueu3UoNKVTo+C9n4Jn+JaTP2o=; b=GJm5SDMGCkFcp6ZuiTmucYwlLvzFsT5fd6BVKlYns18H33sSE0B1xWoRDKEhQ8yNIT zATNdd0MC4I/LlXL2/2qHqHnoKPdmlCLuFQMZmr+Zo/N1iQ77zeEEoPidLuG/TwGpl2R AKQlbEdyG2z79nCAF8FZr0C64cPsYWZyAvmijsU7nxcJd6gA6jDkPbdnsbu4dwtuDxV3 abK3Op/tSK1YeJL8akQnagmvU8UHfpGS6d8+4Ht7e2hIu4aJxaGC52LN1Gn01qZP5GM+ nEhp6n8XKKCB+6ihWXM/VZQroQORQ+zts9UgvewuPvFrqR9uo7AEGGMKUhN1Jm62ayta FjVA== X-Gm-Message-State: AOJu0YzlAo18KlGPJSF/asomVSOw/44d2RNqz+PNoyWvio7dY3GL9cYq aJr9nshnyUWnzzZe7YgFbEyVmA== X-Google-Smtp-Source: AGHT+IGplJUJS6D5RdP0gSy2QTohSeSR4gSIA81af/fmBPrRIPnGjoUraXeZu9PIoTjkHGZhXLeFjw== X-Received: by 2002:a05:600c:3c8b:b0:3fe:4c29:e626 with SMTP id bg11-20020a05600c3c8b00b003fe4c29e626mr1942612wmb.13.1692272358746; Thu, 17 Aug 2023 04:39:18 -0700 (PDT) Received: from [192.168.10.46] (146725694.box.freepro.com. [130.180.211.218]) by smtp.googlemail.com with ESMTPSA id a23-20020a05600c225700b003fe1cdbc33dsm2749722wmm.9.2023.08.17.04.39.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 04:39:18 -0700 (PDT) Message-ID: Date: Thu, 17 Aug 2023 13:39:17 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v4 0/5] Add LVTS support for mt8192 Content-Language: en-US To: Chen-Yu Tsai Cc: =?UTF-8?B?TsOtY29sYXMgRi4gUi4gQS4gUHJhZG8=?= , =?UTF-8?Q?Bernhard_Rosenkr=c3=a4nzer?= , angelogioacchino.delregno@collabora.com, rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, rdunlap@infradead.org, ye.xingchen@zte.com.cn, p.zabel@pengutronix.de, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, james.lo@mediatek.com, rex-bc.chen@mediatek.com, abailon@baylibre.com, amergnat@baylibre.com, khilman@baylibre.com References: <20230530195132.2286163-1-bero@baylibre.com> <107678ff-c3d5-4c3a-ad0e-fa292a125daa@notapiano> From: Daniel Lezcano In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17/08/2023 10:45, Chen-Yu Tsai wrote: > On Thu, Aug 17, 2023 at 4:49 AM Daniel Lezcano > wrote: >> >> >> Hi, >> >> On 16/08/2023 21:57, Nícolas F. R. A. Prado wrote: >> >> [ ... ] >> >>> Hi Daniel, >>> >>> just a gentle reminder. As you've just applied [1], there are no longer any >>> concerns with this series, and it'll provide both working interrupts and >>> reliable thermal readings on MT8192. >> >> There are still concerns and questions in the series for patch2 and 3. > > FWIW the readout errors raised in patch 3 were fixed by > > "thermal/drivers/mediatek/lvts_thermal: Make readings valid in filtered mode" > > So I guess the remaining concern is on patch 2 about whether the noirq > suspend callback should be used instead. Yes, and the reordering of the lvts_of_match -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog