From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sergei Shtylyov Subject: Re: [PATCH v2 1/3] dt/bindings: da8xx-usb: Add binding for the CPPI 4.1 DMA controller Date: Wed, 18 Jan 2017 12:30:11 +0300 Message-ID: References: <20170117142016.11163-1-abailon@baylibre.com> <20170117142016.11163-2-abailon@baylibre.com> <710c724c-3831-e9d1-406b-76bdfed7b948@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <710c724c-3831-e9d1-406b-76bdfed7b948-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Sekhar Nori , Alexandre Bailon , vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org Cc: dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, ptitiano-rdvid1DuHRBWk0Htik3J/w@public.gmane.org, tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, b-liu-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: devicetree@vger.kernel.org Hello! On 1/18/2017 11:33 AM, Sekhar Nori wrote: >>> DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller. >>> >>> Signed-off-by: Alexandre Bailon >>> --- >>> .../devicetree/bindings/usb/da8xx-usb.txt | 42 >>> ++++++++++++++++++++++ >>> 1 file changed, 42 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> b/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> index ccb844a..aed3169 100644 >>> --- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt >>> @@ -18,10 +18,26 @@ Required properties: >>> >>> - phy-names: Should be "usb-phy" >>> >>> + - dmas: specifies the dma channels >>> + >>> + - dma-names: specifies the names of the channels. Use "rxN" for receive >>> + and "txN" for transmit endpoints. N specifies the endpoint number. >>> + >>> Optional properties: >>> ~~~~~~~~~~~~~~~~~~~~ >>> - vbus-supply: Phandle to a regulator providing the USB bus power. >>> >>> +DMA >>> +~~~ >>> +- compatible: ti,da8xx-cppi41 >> >> Almost missed this -- wildcards in this property are forbidden. >> We should use "ti,da830-cppi41" as a least common denominator. > > Documentation/devicetree/bindings/submitting-patches.txt states: > > " > 5) The wildcard "" may be used in compatible strings, as in > the following example: > > - compatible: Must contain '"nvidia,-pcie", > "nvidia,tegra20-pcie"' where is tegra30, tegra132, ... > " > > I take this to mean that using wildcards to denote an SoC family on > which the same IP is present is okay to do.> With that understanding, I > think using ti,da8xx-cppi41 is fine too. It doesn't really follow. I repeat, x's are not allowed. [...] > Thanks, > Sekhar MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html