devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
@ 2023-05-10 10:38 Tony Lindgren
  2023-05-10 10:51 ` Krzysztof Kozlowski
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Tony Lindgren @ 2023-05-10 10:38 UTC (permalink / raw)
  To: Arnd Bergmann, Olof Johansson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, Dinh Nguyen
  Cc: linux-arm-kernel, Niravkumar L Rabara, devicetree

According to the pinctrl binding pinmux and pinctrl are valid controller
names. Let's replace pinconf with pinctrl so we don't get new warnings
when pinctrl-singl yaml binding gets merged.

Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Dinh Nguyen <dinguyen@kernel.org>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
Cc: Ray Jui <rjui@broadcom.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Scott Branden <sbranden@broadcom.com>
Cc: Wei Xu <xuwei5@hisilicon.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>
---
 arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi | 2 +-
 arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi              | 2 +-
 arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi b/arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi
--- a/arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi
+++ b/arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi
@@ -32,7 +32,7 @@
 
 #include <dt-bindings/pinctrl/brcm,pinctrl-stingray.h>
 
-		pinconf: pinconf@140000 {
+		pinconf: pinctrl@140000 {
 			compatible = "pinconf-single";
 			reg = <0x00140000 0x250>;
 			pinctrl-single,register-width = <32>;
diff --git a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
--- a/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi
@@ -172,7 +172,7 @@ combphy1: phy@858 {
 			};
 		};
 
-		pmx0: pinconf@8a21000 {
+		pmx0: pinctrl@8a21000 {
 			compatible = "pinconf-single";
 			reg = <0x8a21000 0x180>;
 			pinctrl-single,register-width = <32>;
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
--- a/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex.dtsi
@@ -365,7 +365,7 @@ pinctrl0: pinctrl@ffd13000 {
 			pinctrl-single,function-mask = <0x0000000f>;
 		};
 
-		pinctrl1: pinconf@ffd13100 {
+		pinctrl1: pinctrl@ffd13100 {
 			compatible = "pinctrl-single";
 			#pinctrl-cells = <1>;
 			reg = <0xffd13100 0x20>;
-- 
2.40.1

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 10:38 [PATCH] arm64: dts: Change pinconf controller node name to pinctrl Tony Lindgren
@ 2023-05-10 10:51 ` Krzysztof Kozlowski
  2023-05-10 10:53   ` Tony Lindgren
  2023-05-18 22:56 ` Florian Fainelli
  2023-06-07  1:47 ` Wei Xu
  2 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-10 10:51 UTC (permalink / raw)
  To: Tony Lindgren, Arnd Bergmann, Olof Johansson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, Dinh Nguyen
  Cc: linux-arm-kernel, Niravkumar L Rabara, devicetree

On 10/05/2023 12:38, Tony Lindgren wrote:
> According to the pinctrl binding pinmux and pinctrl are valid controller
> names. Let's replace pinconf with pinctrl so we don't get new warnings
> when pinctrl-singl yaml binding gets merged.
> 
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>
> ---
>  arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi | 2 +-
>  arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi              | 2 +-
>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)

These should be either split by subsystem or you will have to push it
through soc.

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 10:51 ` Krzysztof Kozlowski
@ 2023-05-10 10:53   ` Tony Lindgren
  2023-05-10 12:10     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 7+ messages in thread
From: Tony Lindgren @ 2023-05-10 10:53 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Arnd Bergmann, Olof Johansson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, Dinh Nguyen,
	linux-arm-kernel, Niravkumar L Rabara, devicetree

* Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230510 10:51]:
> On 10/05/2023 12:38, Tony Lindgren wrote:
> > According to the pinctrl binding pinmux and pinctrl are valid controller
> > names. Let's replace pinconf with pinctrl so we don't get new warnings
> > when pinctrl-singl yaml binding gets merged.
> > 
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Dinh Nguyen <dinguyen@kernel.org>
> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> > Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> > Cc: Ray Jui <rjui@broadcom.com>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Scott Branden <sbranden@broadcom.com>
> > Cc: Wei Xu <xuwei5@hisilicon.com>
> > Signed-off-by: Tony Lindgren <tony@atomide.com>
> > ---
> >  arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi | 2 +-
> >  arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi              | 2 +-
> >  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> These should be either split by subsystem or you will have to push it
> through soc.

Let's see if Arnd cares to pick it up :)

Regards,

Tony

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 10:53   ` Tony Lindgren
@ 2023-05-10 12:10     ` Krzysztof Kozlowski
  2023-06-13 22:40       ` Dinh Nguyen
  0 siblings, 1 reply; 7+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-10 12:10 UTC (permalink / raw)
  To: Tony Lindgren
  Cc: Arnd Bergmann, Olof Johansson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, Dinh Nguyen,
	linux-arm-kernel, Niravkumar L Rabara, devicetree

On 10/05/2023 12:53, Tony Lindgren wrote:
> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230510 10:51]:
>> On 10/05/2023 12:38, Tony Lindgren wrote:
>>> According to the pinctrl binding pinmux and pinctrl are valid controller
>>> names. Let's replace pinconf with pinctrl so we don't get new warnings
>>> when pinctrl-singl yaml binding gets merged.
>>>
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>> Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>>> Cc: Ray Jui <rjui@broadcom.com>
>>> Cc: Rob Herring <robh+dt@kernel.org>
>>> Cc: Scott Branden <sbranden@broadcom.com>
>>> Cc: Wei Xu <xuwei5@hisilicon.com>
>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>> ---
>>>  arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi | 2 +-
>>>  arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi              | 2 +-
>>>  arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 +-
>>>  3 files changed, 3 insertions(+), 3 deletions(-)
>>
>> These should be either split by subsystem or you will have to push it
>> through soc.
> 

FWIW:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 10:38 [PATCH] arm64: dts: Change pinconf controller node name to pinctrl Tony Lindgren
  2023-05-10 10:51 ` Krzysztof Kozlowski
@ 2023-05-18 22:56 ` Florian Fainelli
  2023-06-07  1:47 ` Wei Xu
  2 siblings, 0 replies; 7+ messages in thread
From: Florian Fainelli @ 2023-05-18 22:56 UTC (permalink / raw)
  To: Tony Lindgren, Arnd Bergmann, Olof Johansson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, Dinh Nguyen
  Cc: linux-arm-kernel, Niravkumar L Rabara, devicetree

[-- Attachment #1: Type: text/plain, Size: 738 bytes --]

On 5/10/23 03:38, Tony Lindgren wrote:
> According to the pinctrl binding pinmux and pinctrl are valid controller
> names. Let's replace pinconf with pinctrl so we don't get new warnings
> when pinctrl-singl yaml binding gets merged.
> 
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Acked-by: Florian Fainelli <florian.fainelli@broadcom.com> 
#stingray-pinctrl.dtsi
-- 
Florian


[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 10:38 [PATCH] arm64: dts: Change pinconf controller node name to pinctrl Tony Lindgren
  2023-05-10 10:51 ` Krzysztof Kozlowski
  2023-05-18 22:56 ` Florian Fainelli
@ 2023-06-07  1:47 ` Wei Xu
  2 siblings, 0 replies; 7+ messages in thread
From: Wei Xu @ 2023-06-07  1:47 UTC (permalink / raw)
  To: Tony Lindgren, Arnd Bergmann, Olof Johansson, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Dinh Nguyen
  Cc: linux-arm-kernel, Niravkumar L Rabara, devicetree

Hi Tony,

On 2023/5/10 18:38, Tony Lindgren wrote:
> According to the pinctrl binding pinmux and pinctrl are valid controller
> names. Let's replace pinconf with pinctrl so we don't get new warnings
> when pinctrl-singl yaml binding gets merged.
> 
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Dinh Nguyen <dinguyen@kernel.org>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
> Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
> Cc: Ray Jui <rjui@broadcom.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Scott Branden <sbranden@broadcom.com>
> Cc: Wei Xu <xuwei5@hisilicon.com>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Acked-by: Wei Xu <xuwei5@hisilicon.com> #hisilicon
Thanks!

Best Regards,
Wei

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] arm64: dts: Change pinconf controller node name to pinctrl
  2023-05-10 12:10     ` Krzysztof Kozlowski
@ 2023-06-13 22:40       ` Dinh Nguyen
  0 siblings, 0 replies; 7+ messages in thread
From: Dinh Nguyen @ 2023-06-13 22:40 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Tony Lindgren
  Cc: Arnd Bergmann, Olof Johansson, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Ray Jui, Scott Branden,
	Broadcom internal kernel review list, Wei Xu, linux-arm-kernel,
	Niravkumar L Rabara, devicetree



On 5/10/23 07:10, Krzysztof Kozlowski wrote:
> On 10/05/2023 12:53, Tony Lindgren wrote:
>> * Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> [230510 10:51]:
>>> On 10/05/2023 12:38, Tony Lindgren wrote:
>>>> According to the pinctrl binding pinmux and pinctrl are valid controller
>>>> names. Let's replace pinconf with pinctrl so we don't get new warnings
>>>> when pinctrl-singl yaml binding gets merged.
>>>>
>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>> Cc: Dinh Nguyen <dinguyen@kernel.org>
>>>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>
>>>> Cc: Niravkumar L Rabara <niravkumar.l.rabara@intel.com>
>>>> Cc: Ray Jui <rjui@broadcom.com>
>>>> Cc: Rob Herring <robh+dt@kernel.org>
>>>> Cc: Scott Branden <sbranden@broadcom.com>
>>>> Cc: Wei Xu <xuwei5@hisilicon.com>
>>>> Signed-off-by: Tony Lindgren <tony@atomide.com>
>>>> ---
>>>>   arch/arm64/boot/dts/broadcom/stingray/stingray-pinctrl.dtsi | 2 +-
>>>>   arch/arm64/boot/dts/hisilicon/hi3798cv200.dtsi              | 2 +-
>>>>   arch/arm64/boot/dts/intel/socfpga_agilex.dtsi               | 2 +-
>>>>   3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> These should be either split by subsystem or you will have to push it
>>> through soc.
>>
> 
> FWIW:
> 
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Best regards,
> Krzysztof
> 

For socfpga_agilex:

Acked-by: Dinh Nguyen <dinguyen@kernel.org>

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-06-13 22:40 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-10 10:38 [PATCH] arm64: dts: Change pinconf controller node name to pinctrl Tony Lindgren
2023-05-10 10:51 ` Krzysztof Kozlowski
2023-05-10 10:53   ` Tony Lindgren
2023-05-10 12:10     ` Krzysztof Kozlowski
2023-06-13 22:40       ` Dinh Nguyen
2023-05-18 22:56 ` Florian Fainelli
2023-06-07  1:47 ` Wei Xu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).