Re: [PATCH net-next v3 2/6] dt-bindings: net: Brcm ASP 2.0 Ethernet controller

[Conor Dooley <mail@conchuod.ie>]

On Fri, May 19, 2023 at 02:19:40PM -0700, Justin Chen wrote:
 > From: Florian Fainelli <florian.fainelli@broadcom.com>
 >
 > Add a binding document for the Broadcom ASP 2.0 Ethernet controller.
 >
 > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
 > Signed-off-by: Justin Chen <justin.chen@broadcom.com>
 > ---

Same deal here, usual mailer is refusing to reply cos of:
Problem signature from: 
1.2.840.113549.1.9.1=#6A757374696E2E6368656E4062726F6164636F6D2E636F6D,CN=Justin 
Chen,O=Broadcom Inc.,L=Bangalore,ST=Karnataka,C=IN
                    aka: <justin.chen@broadcom.com>
                created: Fri 19 May 2023 10:19:57 PM IST
                expires: Wed 10 Sep 2025 01:39:50 PM IST

 > v3
 >         - Minor formatting issues
 >         - Change channel prop to brcm,channel for vendor specific format
 >         - Removed redundant v2.0 from compat string
 >         - Fix ranges field
 >
 > v2
 >         - Minor formatting issues
 >
 >  .../devicetree/bindings/net/brcm,asp-v2.0.yaml     | 145 
+++++++++++++++++++++
 >  1 file changed, 145 insertions(+)
 >  create mode 100644 
Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
 >
 > diff --git a/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml 
b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
 > new file mode 100644
 > index 000000000000..a9fed957e1d6
 > --- /dev/null
 > +++ b/Documentation/devicetree/bindings/net/brcm,asp-v2.0.yaml
 > @@ -0,0 +1,145 @@
 > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
 > +%YAML 1.2
 > +---
 > +$id: http://devicetree.org/schemas/net/brcm,asp-v2.0.yaml#
 > +$schema: http://devicetree.org/meta-schemas/core.yaml#
 > +
 > +title: Broadcom ASP 2.0 Ethernet controller
 > +
 > +maintainers:
 > +  - Justin Chen <justin.chen@broadcom.com>
 > +  - Florian Fainelli <florian.fainelli@broadcom.com>
 > +
 > +description: Broadcom Ethernet controller first introduced with 72165
 > +
 > +properties:
 > +  '#address-cells':
 > +    const: 1
 > +  '#size-cells':
 > +    const: 1
 > +
 > +  compatible:
 > +    enum:
 > +      - brcm,asp-v2.0
 > +      - brcm,bcm72165-asp
 > +      - brcm,asp-v2.1
 > +      - brcm,bcm74165-asp

One of Rob's questions on V(N-1) that seems to have been ignored/only
partly implemented:
 > You have 1 SoC per version, so what's the point of versions? If you have
 > more coming, then fine, but I'd expect it to be something like this:
 >
 > compatible = "brcm,bcm74165-asp-v2.1", "brcm,asp-v2.1";

You did drop the -v2.1 that he requested from the SoC compatible, but I
amn't sure why the above was not implemented (at least there's no
explanation in the previous thread's version, nor in the changelog
here...)

Cheers,
Conor