From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Sahin, Okan" <Okan.Sahin@analog.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
"open list:MAXIM MAX77541 PMIC MFD DRIVER"
<linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH v2 2/5] dt-bindings: mfd: adi,max77541.yaml Add MAX77541 bindings
Date: Sun, 15 Jan 2023 20:16:22 +0100 [thread overview]
Message-ID: <d570c775-158c-26e1-94d8-de3dc4d5370e@linaro.org> (raw)
In-Reply-To: <MN2PR03MB51689EC83FF462C5CE903567E7C09@MN2PR03MB5168.namprd03.prod.outlook.com>
On 15/01/2023 18:40, Sahin, Okan wrote:
> Hi Krzysztof,
>
> Thank you for your feedback and efforts. I apologize for some missing points of v2 patch. I tried to do my best. I will be more careful to fix all feedback before sending new patch so I want to ask a few things before sending v3 patch
Please wrap lines in your email.
(...)
>>> +
>>> + adc:
>>> + type: object
>>> + additionalProperties: false
>>> + properties:
>>> + compatible:
>>> + const: adi,max77541-adc
>>
>> This is a friendly reminder during the review process.
>>
>> It seems my previous comments were not fully addressed. Maybe my feedback
>> got lost between the quotes, maybe you just forgot to apply it.
>> Please go back to the previous discussion and either implement all requested
>> changes or keep discussing them.
>>
>> Thank you.
> Honestly, I don't quite understand what you're suggesting regarding the adc part. I thought I should add the adc as an object since it is in the mfd device. Do I need to remove this part?
What is unclear in my comment from v1? Yes, you need to remove it
because it useless. There is no need for a node consisting of only
compatible. Your driver does not need the DT node at all to do its job.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-01-15 19:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221226223839.103460-1-okan.sahin@analog.com>
2022-12-26 22:38 ` [PATCH v2 2/5] dt-bindings: mfd: adi,max77541.yaml Add MAX77541 bindings Okan Sahin
2022-12-27 7:53 ` Krzysztof Kozlowski
2023-01-15 17:40 ` Sahin, Okan
2023-01-15 19:16 ` Krzysztof Kozlowski [this message]
2022-12-28 0:27 ` Rob Herring
2022-12-26 22:38 ` [PATCH v2 4/5] dt-bindings: regulator: adi,max77541-regulator.yaml Add MAX77541 Regulator bindings Okan Sahin
2022-12-27 7:56 ` Krzysztof Kozlowski
2023-01-15 17:41 ` Sahin, Okan
2023-01-15 19:12 ` Krzysztof Kozlowski
2022-12-29 4:49 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d570c775-158c-26e1-94d8-de3dc4d5370e@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Okan.Sahin@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).