[PATCH v2 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[PATCH v2 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Mukesh Ojha]

Document the qcom,tcsr-sm8450 compatible.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Change in v2:
  - Considering here it as v2 as this patch came out from comment
    made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/

 Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
index adcae6c..bdf7ab4 100644
--- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
+++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
@@ -37,6 +37,7 @@ properties:
           - qcom,tcsr-msm8960
           - qcom,tcsr-msm8974
           - qcom,tcsr-msm8996
+          - qcom,tcsr-sm8450
       - const: syscon
 
   reg:
-- 
2.7.4

[PATCH v2 2/2] arm64: dts: qcom: sm8450: Add TCSR halt register space

[Mukesh Ojha]

Add TCSR register space and refer it from scm node, so that
it can be used by SCM driver.

Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
---
Changes in v2:
  - Added SoC compatible based on comment made by krzysztof in v1.

 arch/arm64/boot/dts/qcom/sm8450.dtsi | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sm8450.dtsi b/arch/arm64/boot/dts/qcom/sm8450.dtsi
index 5704750..8c866e4 100644
--- a/arch/arm64/boot/dts/qcom/sm8450.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8450.dtsi
@@ -270,6 +270,7 @@
 	firmware {
 		scm: scm {
 			compatible = "qcom,scm-sm8450", "qcom,scm";
+			qcom,dload-mode = <&tcsr 0x13000>;
 			interconnects = <&aggre2_noc MASTER_CRYPTO 0 &mc_virt SLAVE_EBI1 0>;
 			#reset-cells = <1>;
 		};
@@ -1986,6 +1987,11 @@
 			#hwlock-cells = <1>;
 		};
 
+		tcsr: syscon@1fc0000 {
+			compatible = "qcom,tcsr-sm8450", "syscon";
+			reg = <0x0 0x1fc0000 0x0 0x30000>;
+		};
+
 		usb_1_hsphy: phy@88e3000 {
 			compatible = "qcom,sm8450-usb-hs-phy",
 				     "qcom,usb-snps-hs-7nm-phy";
-- 
2.7.4

Re: [PATCH v2 1/2] dt-bindings: mfd: qcom,tcsr: Add compatible for sm8450

[Krzysztof Kozlowski]

On 12/01/2023 09:10, Mukesh Ojha wrote:
> Document the qcom,tcsr-sm8450 compatible.
> 
> Signed-off-by: Mukesh Ojha <quic_mojha@quicinc.com>
> ---
> Change in v2:
>   - Considering here it as v2 as this patch came out from comment
>     made on its v1 https://lore.kernel.org/lkml/c5dc8042-717b-22eb-79f6-d18ab10d6685@linaro.org/
> 
>  Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> index adcae6c..bdf7ab4 100644
> --- a/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> +++ b/Documentation/devicetree/bindings/mfd/qcom,tcsr.yaml
> @@ -37,6 +37,7 @@ properties:
>            - qcom,tcsr-msm8960
>            - qcom,tcsr-msm8974
>            - qcom,tcsr-msm8996
> +          - qcom,tcsr-sm8450

Don't use deprecated name here, you can see there already new devices
with proper naming, so sm8450-tcsr


Best regards,
Krzysztof