From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Elvis.Wang" <Elvis.Wang@mediatek.com>,
Jassi Brar <jassisinghbrar@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>
Cc: "jason-jh . lin" <jason-jh.lin@mediatek.com>,
Yongqiang Niu <yongqiang.niu@mediatek.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
Project_Global_Chrome_Upstream_Group@mediatek.com
Subject: Re: [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188
Date: Sun, 27 Nov 2022 22:22:42 +0100 [thread overview]
Message-ID: <d58e3488-110f-cae0-6f44-c9bc54d301fe@linaro.org> (raw)
In-Reply-To: <20221124075516.1669-2-Elvis.Wang@mediatek.com>
On 24/11/2022 08:55, Elvis.Wang wrote:
> From: Elvis Wang <Elvis.Wang@mediatek.com>
Subject: dt-bindings: mailbox: .......
>
> add gce header file to define the gce thread priority, gce subsys id,
Start with capital letter. gce->GCE, right? So use capitals for acronym
and also explain what that acronym mean.
> event and constant for mt8188.>
> Signed-off-by: Elvis Wang <Elvis.Wang@mediatek.com>
> ---
> .../dt-bindings/mailbox/mediatek,mt8188-gce.h | 966 ++++++++++++++++++
> 1 file changed, 966 insertions(+)
> create mode 100644 include/dt-bindings/mailbox/mediatek,mt8188-gce.h
>
(...)
> +#define CMDQ_SYNC_TOKEN_DISP_VA_START 1012
> +#define CMDQ_SYNC_TOKEN_DISP_VA_END 1013
One blank line here.
> +#endif
With all above changes:
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-11-27 21:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221124075516.1669-1-Elvis.Wang@mediatek.com>
[not found] ` <20221124075516.1669-2-Elvis.Wang@mediatek.com>
2022-11-24 10:26 ` [PATCH v4 1/2] dt-bindings: gce: add gce header file for mt8188 AngeloGioacchino Del Regno
2022-11-27 21:22 ` Krzysztof Kozlowski [this message]
[not found] ` <20221124075516.1669-3-Elvis.Wang@mediatek.com>
2022-11-27 21:23 ` [PATCH v4 2/2] dt-bindings: mailbox: mediatek,gce-mailbox: add mt8188 compatible name Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d58e3488-110f-cae0-6f44-c9bc54d301fe@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Elvis.Wang@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jason-jh.lin@mediatek.com \
--cc=jassisinghbrar@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yongqiang.niu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).