From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Manuel Traut <manut@mecka.net>,
Neil Armstrong <neil.armstrong@linaro.org>,
Jessica Zhang <quic_jesszhan@quicinc.com>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>,
Sandy Huang <hjc@rock-chips.com>,
Mark Yao <markyao0591@gmail.com>,
Diederik de Haas <didi.debian@cknow.org>,
Segfault <awarnecke002@hotmail.com>,
Arnaud Ferraris <aferraris@debian.org>
Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 5/6] arm64: dts: rockchip: Fix some dtb-check warnings
Date: Fri, 22 Dec 2023 17:07:31 +0100 [thread overview]
Message-ID: <d59a60d9-6bd3-4945-a345-0b01eaf1ead8@linaro.org> (raw)
In-Reply-To: <20231222-pinetab2-v1-5-e148a7f61bd1@mecka.net>
On 22/12/2023 12:05, Manuel Traut wrote:
> devicetree checks show some warnings:
>
> video-codec@fdea0400: 'interrupt-names' is a required property
> from schema $id: http://devicetree.org/schemas/media/rockchip-vpu.yaml#
>
> hdmi@fe0a0000: Unevaluated properties are not allowed ('power-domains' were unexpected)
> from schema $id: http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi.yaml#
>
...
> @@ -819,7 +820,6 @@ hdmi: hdmi@fe0a0000 {
> clock-names = "iahb", "isfr", "cec", "ref";
> pinctrl-names = "default";
> pinctrl-0 = <&hdmitx_scl &hdmitx_sda &hdmitxm0_cec>;
> - power-domains = <&power RK3568_PD_VO>;
> reg-io-width = <4>;
> rockchip,grf = <&grf>;
> #sound-dai-cells = <0>;
> @@ -1123,7 +1123,7 @@ i2s2_2ch: i2s@fe420000 {
> dmas = <&dmac1 4>, <&dmac1 5>;
> dma-names = "tx", "rx";
> resets = <&cru SRST_M_I2S2_2CH>;
> - reset-names = "m";
> + reset-names = "tx-m", "rx-m";
That's not correct. Look at line above. How many entries it has?
Do not fix warnings just to make the warning disappear. Your change here
clearly suggests you did just that.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-22 16:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 11:05 [PATCH 0/6] arm64: rockchip: Pine64 pinetab2 support Manuel Traut
2023-12-22 11:05 ` [PATCH 1/6] dt-bindings: display: panel: Add BOE TH101MB31IG002-28A panel Manuel Traut
2023-12-22 16:01 ` Krzysztof Kozlowski
2023-12-22 16:30 ` Diederik de Haas
2023-12-22 11:05 ` [PATCH 2/6] drm/panel: Add driver for " Manuel Traut
2023-12-22 18:25 ` Fabio Estevam
2023-12-26 22:51 ` Jessica Zhang
2023-12-22 11:05 ` [PATCH 3/6] dt-bindings: arm64: rockchip: Add Pine64 Pinetab2 Manuel Traut
2023-12-22 16:02 ` Krzysztof Kozlowski
2023-12-22 11:05 ` [PATCH 4/6] arm64: dts: rockchip: Add devicetree for " Manuel Traut
2023-12-22 16:49 ` Diederik de Haas
2023-12-23 14:03 ` Manuel Traut
2023-12-22 17:01 ` Diederik de Haas
2023-12-23 13:59 ` Manuel Traut
2023-12-23 14:17 ` Diederik de Haas
2023-12-23 9:48 ` Dang Huynh
2023-12-22 11:05 ` [PATCH 5/6] arm64: dts: rockchip: Fix some dtb-check warnings Manuel Traut
2023-12-22 16:07 ` Krzysztof Kozlowski [this message]
2023-12-23 11:43 ` Heiko Stübner
2023-12-22 11:05 ` [PATCH 6/6] dt-bindings: display: rockchip: dw-hdmi: Add missing sound-dai-cells property Manuel Traut
2023-12-22 16:05 ` Krzysztof Kozlowski
2023-12-22 16:51 ` [PATCH 0/6] arm64: rockchip: Pine64 pinetab2 support Diederik de Haas
2023-12-23 11:01 ` Manuel Traut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d59a60d9-6bd3-4945-a345-0b01eaf1ead8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=aferraris@debian.org \
--cc=airlied@gmail.com \
--cc=awarnecke002@hotmail.com \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=manut@mecka.net \
--cc=markyao0591@gmail.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=quic_jesszhan@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).