From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B208C433F5 for ; Mon, 18 Apr 2022 03:40:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236079AbiDRDmw (ORCPT ); Sun, 17 Apr 2022 23:42:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33038 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229449AbiDRDmw (ORCPT ); Sun, 17 Apr 2022 23:42:52 -0400 Received: from mail-sz.amlogic.com (mail-sz.amlogic.com [211.162.65.117]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69B4CAE72; Sun, 17 Apr 2022 20:40:13 -0700 (PDT) Received: from [10.28.39.106] (10.28.39.106) by mail-sz.amlogic.com (10.28.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 18 Apr 2022 11:40:10 +0800 Message-ID: Date: Mon, 18 Apr 2022 11:40:10 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4 1/2] mtd: rawnand: meson: discard the common MMC sub clock framework Content-Language: en-US From: Liang Yang To: Miquel Raynal CC: , Rob Herring , Richard Weinberger , Vignesh Raghavendra , Jerome Brunet , Neil Armstrong , Martin Blumenstingl , Kevin Hilman , Jianxin Pan , Victor Wan , XianWei Zhao , Kelvin Zhang , BiChao Zheng , YongHui Yu , , , , References: <20220402074921.13316-1-liang.yang@amlogic.com> <20220402074921.13316-2-liang.yang@amlogic.com> <20220404103034.48ec16b1@xps13> <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> In-Reply-To: <50105d6b-8ced-1b72-30cb-a709c4a4dd26@amlogic.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.28.39.106] X-ClientProxiedBy: mail-sz.amlogic.com (10.28.11.5) To mail-sz.amlogic.com (10.28.11.5) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Miquel, i have some confusion when i prepare the patches. for DT compatibility, it falls back to the old DT when failed to get resource by the new DT, but there is some points: a. old DT depends on MMC sub clock driver, but it never be merged, so it can't work. b. if it falls back to the old DT, beside the regmap lookup below, it seems that we have to preserve the code of the old clock setting in nfc_clk_init(). do we still need to avoid break DT compatibility? Thanks. On 2022/4/11 10:40, Liang Yang wrote: >>>       nfc->dev = dev; >>> -    res = platform_get_resource(pdev, IORESOURCE_MEM, 0); >>> -    nfc->reg_base = devm_ioremap_resource(dev, res); >>> +    nfc->reg_base = devm_platform_ioremap_resource_byname(pdev, "nfc"); >> >> This change seems unrelated. > > To be consistent with the following > devm_platform_ioremap_resource_byname(pdev, "emmc"). do you mean that we > don't need it?> >>>       if (IS_ERR(nfc->reg_base)) >>>           return PTR_ERR(nfc->reg_base); >>> -    nfc->reg_clk = >>> -        syscon_regmap_lookup_by_phandle(dev->of_node, >>> -                        "amlogic,mmc-syscon"); >>> -    if (IS_ERR(nfc->reg_clk)) { >>> -        dev_err(dev, "Failed to lookup clock base\n"); >>> -        return PTR_ERR(nfc->reg_clk); >>> -    } >>> +    nfc->sd_emmc_clock = devm_platform_ioremap_resource_byname(pdev, >>> "emmc"); >>> +    if (IS_ERR(nfc->sd_emmc_clock)) >>> +        return PTR_ERR(nfc->sd_emmc_clock); >> >> While I agree this is much better than the previous solution, we cannot >> break DT compatibility, so you need to try getting the emmc clock, but >> if it fails you should fallback to the regmap lookup. > > ok, i will fix it next version. thanks. > >> >>>       irq = platform_get_irq(pdev, 0);