From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD361C19F28 for ; Wed, 3 Aug 2022 15:46:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237137AbiHCPqg (ORCPT ); Wed, 3 Aug 2022 11:46:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46504 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231493AbiHCPqf (ORCPT ); Wed, 3 Aug 2022 11:46:35 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 08EE3E08A; Wed, 3 Aug 2022 08:46:33 -0700 (PDT) Received: from [192.168.1.101] (abxi232.neoplus.adsl.tpnet.pl [83.9.2.232]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id E96CA3F672; Wed, 3 Aug 2022 17:46:31 +0200 (CEST) Message-ID: Date: Wed, 3 Aug 2022 17:46:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/5] arm64: dts: qcom: sdm845-db845c: drop power-domains from CCI I2C sensors Content-Language: en-US To: Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski , Loic Poulain , Robert Foss , Andy Gross , Bjorn Andersson , linux-i2c@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Cc: corbet@lwn.net References: <20220802153947.44457-1-krzysztof.kozlowski@linaro.org> <20220802153947.44457-2-krzysztof.kozlowski@linaro.org> From: Konrad Dybcio In-Reply-To: <20220802153947.44457-2-krzysztof.kozlowski@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2.08.2022 17:39, Krzysztof Kozlowski wrote: > The Camera Control Interface I2C controller device node belongs to > TITAN_TOP_GDSC power domain, so its children do not need to specify it > again. The OV7251 and OV8856 camera sensor bindings do not allow > power-domains. > > Signed-off-by: Krzysztof Kozlowski > > --- > > Not tested on hardware. > --- Not tested on hardware either, but looks good. Reviewed-by: Konrad Dybcio Konrad > arch/arm64/boot/dts/qcom/sdm845-db845c.dts | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > index c6e2c571b452..b9304f81290a 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-db845c.dts > @@ -1228,8 +1228,6 @@ camera@10 { > * both have to be enabled through the power management > * gpios. > */ > - power-domains = <&clock_camcc TITAN_TOP_GDSC>; > - > dovdd-supply = <&vreg_lvs1a_1p8>; > avdd-supply = <&cam0_avdd_2v8>; > dvdd-supply = <&cam0_dvdd_1v2>; > @@ -1273,8 +1271,6 @@ camera@60 { > * > * No 1.2V vddd-supply regulator is used. > */ > - power-domains = <&clock_camcc TITAN_TOP_GDSC>; > - > vdddo-supply = <&vreg_lvs1a_1p8>; > vdda-supply = <&cam3_avdd_2v8>; >