From: Randy Dunlap <rdunlap@infradead.org>
To: Theodore Ts'o <tytso@mit.edu>
Cc: Jilin Yuan <yuanjilin@cdjrlc.com>,
robh+dt@kernel.org, frowand.list@gmail.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: fix repeated words in comments
Date: Wed, 19 Oct 2022 18:54:57 -0700 [thread overview]
Message-ID: <d5a7c385-4155-af0c-ed51-865f274fa030@infradead.org> (raw)
In-Reply-To: <Y1Cm2Hvf7W7NxVzk@mit.edu>
On 10/19/22 18:39, Theodore Ts'o wrote:
> On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote:
>>
>> On 10/19/22 06:02, Jilin Yuan wrote:
>>> Delete the redundant word 'of'.
>>>
>>> Signed-off-by: Jilin Yuan <yuanjilin@cdjrlc.com>
>>> ---
>>> drivers/of/device.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/of/device.c b/drivers/of/device.c
>>> index 8cefe5a7d04e..16c7e5a2a868 100644
>>> --- a/drivers/of/device.c
>>> +++ b/drivers/of/device.c
>>> @@ -19,7 +19,7 @@
>>>
>>> /**
>>> * of_match_device - Tell if a struct device matches an of_device_id list
>>> - * @matches: array of of device match structures to search in
>>> + * @matches: array of device match structures to search in
>>
>> Hi,
>> Rob has already explained this at least 2 times.
>>
>> The second "of" is "open firmware".
>> I would write it
>> array of OF device match structures to search in
>> :)
>
> Actually, I'd probably do something like
>
> array of Open Firmware (OF) device match structures...
Sure, that's good.
> This is the first place in that file (at least in a comment) where OF
> gets used, and I've always been a big fan of using the fully expanded
> acronym before using the acronym form. Remember, PCMCIA stands for
> People Can't Memorize Computer Industry Acronyms. :-)
>
> (Actually, it's Personal Computer Memory Chip Industry Association,
Card International Association :)
> but most people don't know that, because using acronyms without
> defining them first makes you feel like you're an "insider". :-)
--
~Randy
next prev parent reply other threads:[~2022-10-20 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-19 13:02 [PATCH] of: fix repeated words in comments Jilin Yuan
2022-10-19 18:53 ` Randy Dunlap
2022-10-19 18:57 ` Conor Dooley
2022-10-20 13:34 ` Bagas Sanjaya
2022-10-20 1:39 ` Theodore Ts'o
2022-10-20 1:54 ` Randy Dunlap [this message]
2022-10-20 13:15 ` Rob Herring
2022-10-20 13:35 ` Bagas Sanjaya
2022-10-20 17:36 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5a7c385-4155-af0c-ed51-865f274fa030@infradead.org \
--to=rdunlap@infradead.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tytso@mit.edu \
--cc=yuanjilin@cdjrlc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).