From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D34AC4332F for ; Thu, 20 Oct 2022 01:55:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230506AbiJTBzL (ORCPT ); Wed, 19 Oct 2022 21:55:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229683AbiJTBzJ (ORCPT ); Wed, 19 Oct 2022 21:55:09 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0411F148F53; Wed, 19 Oct 2022 18:55:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=2WkjNmweiW5UWvFDyTIcZUK41JmBY3NIJ3WWOjzemz4=; b=yix4Du8TvUlpQtqptrK+MKkL3z /ET3kalM77hPT3l6cx/BkcbjUVKBkwSwplYfuXRgJ9WOQ6FButJSZbMP+5V6MB7P/Ryg33i28lEP4 +oCjfTdMsXUhKarpfrdoliN5qeym6d0ygAMgpVWD6rrk7WtUK8uswQdkzG04mNwtpurpG6fQe1udT Se2/1kfXz3Ct3emBhO80iKRfrL3NWFgHpGq/yT87KnL7F8fKCvNQcwAE5Tj/80CMuIx+YlrvGhBk6 nDfyBbT0d/YKYDny9orz7JkmlFfc0/jiau2GCVzD8xoelbrh/CKvDdtYIGtb3NGidbIAhp4OGjk4b pIUiSmOA==; Received: from [2601:1c2:d80:3110::a2e7] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1olKlu-009Dnn-Qc; Thu, 20 Oct 2022 01:54:58 +0000 Message-ID: Date: Wed, 19 Oct 2022 18:54:57 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] of: fix repeated words in comments Content-Language: en-US To: Theodore Ts'o Cc: Jilin Yuan , robh+dt@kernel.org, frowand.list@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221019130200.60460-1-yuanjilin@cdjrlc.com> <9fb4c010-b465-e908-6868-d9e493a9688f@infradead.org> From: Randy Dunlap In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/19/22 18:39, Theodore Ts'o wrote: > On Wed, Oct 19, 2022 at 11:53:54AM -0700, Randy Dunlap wrote: >> >> On 10/19/22 06:02, Jilin Yuan wrote: >>> Delete the redundant word 'of'. >>> >>> Signed-off-by: Jilin Yuan >>> --- >>> drivers/of/device.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/drivers/of/device.c b/drivers/of/device.c >>> index 8cefe5a7d04e..16c7e5a2a868 100644 >>> --- a/drivers/of/device.c >>> +++ b/drivers/of/device.c >>> @@ -19,7 +19,7 @@ >>> >>> /** >>> * of_match_device - Tell if a struct device matches an of_device_id list >>> - * @matches: array of of device match structures to search in >>> + * @matches: array of device match structures to search in >> >> Hi, >> Rob has already explained this at least 2 times. >> >> The second "of" is "open firmware". >> I would write it >> array of OF device match structures to search in >> :) > > Actually, I'd probably do something like > > array of Open Firmware (OF) device match structures... Sure, that's good. > This is the first place in that file (at least in a comment) where OF > gets used, and I've always been a big fan of using the fully expanded > acronym before using the acronym form. Remember, PCMCIA stands for > People Can't Memorize Computer Industry Acronyms. :-) > > (Actually, it's Personal Computer Memory Chip Industry Association, Card International Association :) > but most people don't know that, because using acronyms without > defining them first makes you feel like you're an "insider". :-) -- ~Randy