From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f178.google.com (mail-dy1-f178.google.com [74.125.82.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8422A4279F2 for ; Fri, 1 May 2026 19:40:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664434; cv=none; b=lrup10gleqoSvuRmqr6UHEYo1o178G+UTZq+3O9sgqN/H9a8ThQqjK2+NqTJHpMY0owPDZC5lJ+5nW6W3WcUkI0tMupN+GU5JD/0A/seGqUMFJ3rLDH5ayBVirFQclTaFVS72vA0ujYCAgO4CXo0g50QOJGoK+Pt4kHRLpQzDz0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777664434; c=relaxed/simple; bh=E9GFsmnekKsH/6xM/QZ53TOVyqAnriWM8ZLZsUdfH0g=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OfUkRITIULgH4E7yO+Ojy1PmvKl3Z0i1/Bc5CNv0xlzOcc4W5eU6zeVe0c5RlrFlmuztwM1BTs3JDUJ4/9Uss5j0qzMD5nzBG8zGDGxKVHdy1GVkWz0Q6lLfVu4pYaunZ7lX/zh4NBk/AumBHIfpFK8m40DEg9kf9d3Q11oZ1eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Ra2U3c+0; arc=none smtp.client-ip=74.125.82.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Ra2U3c+0" Received: by mail-dy1-f178.google.com with SMTP id 5a478bee46e88-2ed0a45e970so2707121eec.1 for ; Fri, 01 May 2026 12:40:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777664430; x=1778269230; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=E8+F67fOWD2tr6DD1heUFiUUyHmOTJ/tbCdix11hm8s=; b=Ra2U3c+0J/UdYQhUkAJV2m3CpiNxw6yLz25j3pF9agkdm07D/EcHmWEmiXKoY106cx PAKOJdhnlkTaCEsFAoXNCCd2t7lsi7llhbbi3YiaJ7/8hl2vH4q8Q0j1HXdax2DQWd9c Qgl9JaFD5/ydcqtef1w8gIM6sxS5JOitIisQRO6wsVMP9JrSqn8f96/0miffMH3Tf+F0 yL68d1ITCeItoNEWu9m5wOsq6EGY3jn46TCxDE7kehrESPT8FaI0Ljs6srR/npKKecwo wsltWoF/bT5jaSU/gYYqz1REZ+Kt1HhikcXQhbQKizB6dMPObb7574y6Ssn4gBAv1lOK +kWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777664430; x=1778269230; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E8+F67fOWD2tr6DD1heUFiUUyHmOTJ/tbCdix11hm8s=; b=aLPFayfh1oB6IaAaeOo3lvFd8va4m5lnCah8tGs4hB8ybsnNNchZ0Jl6JDcSZfSzmv 0vbTYFkixDjhVwU1whWHz5Vn8ZRw6QbK/vT7QnVeauQDIDIEzIf3+hb6Ds5e1iipIwrm PKnL5ly2eM7/R5s4SLMuGjsnmO2EqcqNkNi1dWFE9rO6qkC8JI9yQkcDCbYp9CtIYUnd VC/3mNvjCT/iwZMITIbC8F40xbPrCLFQp3LhOXKkDkALU/o8ri55DK6UzpMYbzoxU4dr o/jzJ4j6XaF+zBzXs+kIDKRdzcf/shVCYDLDZF9xGF4jIDOFa5oi0Y2sPQn9geFxYEz7 bWHg== X-Forwarded-Encrypted: i=1; AFNElJ9k0N0TIsfIbDgFQLw8W9sSRni3r9JSi+ovPSitctLf7RhdfcFkxh9noDfNf9E8sj5QE5dNBWO13ySs@vger.kernel.org X-Gm-Message-State: AOJu0Yy+HkjSJxIoL3qLsb84X0A8mdCNy52C80NFGIr7M8gTHEWjKiOW ZjTTeJ+Kq/4Vn48G+pVbpSj/cjGS6saWG3d64rBPoxLd/avylzDzWlVFesscR4O1xg== X-Gm-Gg: AeBDiesyU/dIO29do4hTkwP32/tO/WqbmLUoiqBTN2wz80WlCLmW7isKIlWJNq2EbXC r8CRiPZcE9c9NyoGkMTMCUxthn6qRUO++mFc7QS2eOwO0f9K1h8+U8gBsdWlwYjS2BfLYGIT8z8 5D0buqq6vVyNIeJIwRsBx0I9a/OQDl/cHXU6mKW71eZYS+15hBSA42TD4s8ueQFmwjeVqVXnByP fHCMJ4Yk3x75p7vsnpqiUGojmN469C8MvwqF1mzSj4TrnlFeioV13AP1GpSrGnCqAHGx1s6gptw U1aszl97QsAeaXnBbU0ySbKDc6Mz9lKy4HmKBJ8dQS+bpGnEcECLli7kPrx/Mha0ap7pNJDYADu FAu95pAuTvqmH11kOmDo4ya7+sCDEbHFncW4VGt2AAFFU9nInvstkI+xW7knTLolGpbovmkwVs/ E6+1VuOBVh+I+bBDVTc5s61zPK/VgOUJ7a5iKExuXLTeRpp6CvrGOQFV6uaD0IwcXNZg/unQeTs h7LYhDg82ygk8Q1BuVKWcGqr7kRegoN7epo6PKtfyLe8uU= X-Received: by 2002:a05:7300:6c12:b0:2ed:e12:376d with SMTP id 5a478bee46e88-2efba5a7316mr301846eec.35.1777664429125; Fri, 01 May 2026 12:40:29 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e7c:8:5e5b:112e:7ef4:6fe2? ([2a00:79e0:2e7c:8:5e5b:112e:7ef4:6fe2]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ee3b390df0sm5587081eec.17.2026.05.01.12.40.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 May 2026 12:40:28 -0700 (PDT) Message-ID: Date: Fri, 1 May 2026 12:40:24 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 3/6] mfd: max77759: add register bitmasks and modify irq configs for charger To: Krzysztof Kozlowski , Lee Jones Cc: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Jagan Sridharan , Mark Brown , Matti Vaittinen , Andrew Morton , Sebastian Reichel , Heikki Krogerus , Peter Griffin , Tudor Ambarus , Alim Akhtar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20260331-max77759-charger-v10-0-76f59233c369@google.com> <20260331-max77759-charger-v10-3-76f59233c369@google.com> <20260424082639.GI170138@google.com> <80599996-00e9-4e6c-9215-cf1c33a861bf@kernel.org> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: <80599996-00e9-4e6c-9215-cf1c33a861bf@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Krzysztof, On 4/29/26 9:59 AM, Krzysztof Kozlowski wrote: > On 29/04/2026 02:29, Amit Sunil Dhamne wrote: >> Hi Lee, >> >> >> Thanks for your review. >> >> >> On 4/24/26 1:26 AM, Lee Jones wrote: >>> On Tue, 31 Mar 2026, Amit Sunil Dhamne via B4 Relay wrote: >>> >>>> From: Amit Sunil Dhamne >>>> >>>> Add register bitmasks for charger function. >>>> In addition split the charger IRQs further such that each bit represents >>>> an IRQ downstream of charger regmap irq chip. In addition populate the >>>> ack_base to offload irq ack to the regmap irq chip framework. >>> Please reword this commit messages. >>> >>> Using 'In addition' twice in such close proximity reads a little awkwardly. >> Thanks for pointing it out. Unfortunately, this commit is already part >> of the linux and linux-next so I am not sure if I could fix the commit >> message retrospectively. > I don't understand why you decided to put this with USB patchset. We do > ask not to mix subsystems all the time. You made it unnecessarily > combination of at least three subsystems. > > Do not do that. Thank you for the feedback. I understand the concern regarding mixing subsystems, and I apologize for the extra overhead this caused during review. The decision to group these was driven by tight functional inter-dependencies that I felt would have caused build failures or regressions if split: MFD & Charger: The charger driver relies on new macros and symbols defined in mfd/max77759.h. Additionally, the MFD driver handles the IRQ chip initialization and defines the named IRQ resources that the charger driver requires to register its handlers. Charger & USB Type-C: To avoid a regression, the charger driver needed to take over charger mode programming from the TCPC driver (where it was previously handled as a workaround). Merging these separately would have created a race condition or left the hardware in an inconsistent state during the transition. I see now that this made the patchset difficult to manage across subsystems. For future cases involving such dependencies, would you recommend providing an immutable branch for maintainers to pull from, or is there a different preferred workflow you'd suggest? Best regards, Amit > > Best regards, > Krzysztof