From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Carsten Spieß" <mail@carsten-spiess.de>,
"Guenter Roeck" <linux@roeck-us.net>,
"Jean Delvare" <jdelvare@suse.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Magnus Damm" <magnus.damm@gmail.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022
Date: Thu, 27 Jul 2023 10:25:58 +0200 [thread overview]
Message-ID: <d5e3aa31-1aaa-0f8a-12d2-20dc6ee94f1a@linaro.org> (raw)
In-Reply-To: <20230727093528.594ce3a7.mail@carsten-spiess.de>
On 27/07/2023 09:35, Carsten Spieß wrote:
> thanks all for your input.
> I conclude here in one answer:
>
> On 7/26/23 18:14, Krzysztof Kozlowski wrote:
>> It does not look like you tested the bindings, at least after quick
>> look. Please run `make dt_binding_check` (see
> sorry i missed that, fixed for [Patch v2].
>
>
> On 7/26/23 18:14, Krzysztof Kozlowski wrote:
>>> + shunt-gain:
>> 1. Missing vendor prefix (does not look like generic property)
>> 2. -microvolt
>> And then enum is for 40, 80, 160 and 320.
> replaced with
> renesas,shunt-range-milli-volts:
That's not correct unit in DT, so again please use -microvolt:
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml
> description: |
> maximal shunt voltage range of 40mV, 80mV, 160mV or 320mV
> $ref: /schemas/types.yaml#/definitions/uint32-array
And then drop this line.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-27 8:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20230726152235.249569-1-mail@carsten-spiess.de>
2023-07-26 15:22 ` [PATCH 2/2] dt-bindings: hwmon: add renesas,isl28022 Carsten Spieß
2023-07-26 16:14 ` Krzysztof Kozlowski
2023-07-26 16:19 ` Krzysztof Kozlowski
2023-07-26 18:19 ` Guenter Roeck
2023-07-26 18:27 ` Krzysztof Kozlowski
2023-07-26 18:59 ` Guenter Roeck
2023-07-26 19:05 ` Krzysztof Kozlowski
2023-07-26 16:16 ` Guenter Roeck
2023-07-27 7:35 ` Carsten Spieß
2023-07-27 8:07 ` Conor Dooley
2023-07-27 8:25 ` Krzysztof Kozlowski [this message]
2023-07-27 9:30 ` Carsten Spieß
2023-07-27 13:55 ` Guenter Roeck
2023-07-26 17:13 ` Rob Herring
[not found] <20230727194813.2245116-1-mail@carsten-spiess.de>
2023-07-27 19:48 ` Carsten Spieß
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d5e3aa31-1aaa-0f8a-12d2-20dc6ee94f1a@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=jdelvare@suse.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=magnus.damm@gmail.com \
--cc=mail@carsten-spiess.de \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox