From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 463AD221F17; Mon, 10 Mar 2025 07:49:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741592969; cv=none; b=N6WT7eitS2k7oM/hPe9i+PTpflY4+9bqibpy9p6Bq0kRBgTr0QIlt6jnWQZtKpFEdcM0fOr9yf19cBbqWOBG2iB8VKYglhjjFkda+OZp60r26L3fw8i0lVJp9IaILb4I6UDK10PbU5phK2LJ4fgBWm97+xNMs+1Gp/2usys/pQo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741592969; c=relaxed/simple; bh=A5WdeWt4vfwbKkxKlT44d9TzT5Zdl1cx2ZqK/UJ7sCw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gdJH1R1b4Xwi+wbLhN/RbKOxrg0gfx9xRQe4HEr7JUv+KdoCBgdO7fE6mogQzX/tYHivz6jAsOFYB9ywy14HGQhpiXmUgg5aJ1ZTxddGIKEP1C3B/J6BPOtINV+LLD0iOcdN7qXbcRZoSLF/7/wIQlLEPuarEYisENvlrs+VyfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Zm5UYNqH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Zm5UYNqH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 02579C4CEE5; Mon, 10 Mar 2025 07:49:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1741592968; bh=A5WdeWt4vfwbKkxKlT44d9TzT5Zdl1cx2ZqK/UJ7sCw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Zm5UYNqHaM9F7P5O1ks79pR5k6fXZR0b0iMb4ZlPvLNXzwlgjhErQyZpkB161/CFt RSQbLysxE797uup+GgelsyDEknr8mrWYdnuwlRaAVDY5hfUJxDpy1fkwQOzZ1UJbcG HidrMve56i6V4jx/8ju0hB8GNlkFPMWlclFaqWtVaXRq+2kPBmNuJKBW49N2xIM9bg 8gHmHH8514LeE85B9QMIg/zcLECDrcB/9RqGZyCfz+hkXErnFO12SSNo3Ij9SUU5aU qjwM3fRfsgjfwmS/8KPgmUIsXB9uucXn8V0kZo0a48f86W6iwNsCG1TRvr5Ch2Qw3V y9rWCKRnpzABw== Message-ID: Date: Mon, 10 Mar 2025 08:49:22 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: leds: add Texas Instruments TPS6131x flash LED driver To: Matthias Fend , Pavel Machek , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, bsp-development.geo@leica-geosystems.com References: <20250228-leds-tps6131x-v1-0-d1071d90f9ea@emfend.at> <20250228-leds-tps6131x-v1-1-d1071d90f9ea@emfend.at> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20250228-leds-tps6131x-v1-1-d1071d90f9ea@emfend.at> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 28/02/2025 11:31, Matthias Fend wrote: > + > +properties: > + compatible: > + enum: > + - ti,tps61310 > + - ti,tps61311 > + > + reg: > + maxItems: 1 > + > + '#address-cells': > + const: 1 > + > + '#size-cells': > + const: 0 Why do you need these two? > + > + reset-gpios: > + maxItems: 1 > + description: GPIO connected to NRESET pin > + > + ti,valley-current-limit: > + type: boolean > + description: > + Reduce the valley peak current limit from 1750mA to 1250mA (TPS61310) or > + from 2480mA to 1800mA (TPS61311). > + > + led: Why do you have only one led node? Description says three: LED1-3, unless these are just sinks which always have to be connected to the same LED? > + type: object > + $ref: common.yaml# > + unevaluatedProperties: false > + > + properties: > + led-sources: > + allOf: Drop allOf > + - minItems: 1 > + maxItems: 3 > + items: > + enum: [1, 2, 3] > + > + led-max-microamp: > + anyOf: oneOf > + - minimum: 25000 > + maximum: 350000 > + multipleOf: 50000 > + - minimum: 25000 > + maximum: 525000 Why two different values? > + multipleOf: 25000 > + > + flash-max-microamp: > + anyOf: oneOf > + - minimum: 25000 > + maximum: 800000 > + multipleOf: 50000 > + - minimum: 25000 Same question > + maximum: 1500000 > + multipleOf: 25000 > + > + flash-max-timeout-us: > + enum: [ 5300, 10700, 16000, 21300, 26600, 32000, 37300, 68200, 71500, > + 102200, 136300, 170400, 204500, 340800, 579300, 852000 ] > + > + required: > + - led-sources > + - led-max-microamp > + - flash-max-microamp > + - flash-max-timeout-us > + > +required: > + - compatible > + - reg > + - '#address-cells' > + - '#size-cells' Why? > + - led > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + led-controller@33 { > + compatible = "ti,tps61310"; > + reg = <0x33>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + reset-gpios = <&gpio1 0 GPIO_ACTIVE_LOW>; > + > + tps61310_flash: led { Drop unused label Best regards, Krzysztof