From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49F1C3D333D for ; Fri, 31 Jul 2026 08:24:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486272; cv=none; b=IG1NB49njyrjQ9/xHjBwoScL7R+Vi9neDBy8dcFT7cfxkujKCI5pGXMajfzIDBeyBetu57znA2fbi71gS2vaujUYyGLjXpiL8fto6F2zxpRoEINnCALaW3l5buevs+LKhXZQgi2JlpK0ST+4IYJAIuL6h1z9Bnca/JSD1ExxGv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486272; c=relaxed/simple; bh=tZ6wcj1R/7T6ikjhyiGVXOIeTMRdFJS8++6PntsJuug=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=IH8IS7ASw0QXwb4f1SJ+2fH/XmVLpcWySPmP1h5NX3m6UPW4Mo4eTLuB2f/HgLFQgD5x1N4eOkS1O3g5empDS9btuYPLQFRRCKWqk18Hxp8jLgOkvROPDjGL/p+sSb9rtF96zVQSkLAu/xU6Q5zdCJX6+HfMl1BTXRfq1P9RNSg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UWORjrLn; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=S5z82HG4; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UWORjrLn"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="S5z82HG4" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V7vXqH2885383 for ; Fri, 31 Jul 2026 08:24:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= tfhVrR1XwzbRp56jy68NgRK5yU4D4Jc9JJLcVAiXFzE=; b=UWORjrLnvLDQEMRQ 2SfhQgqbKwcF+gfv+l/hWvPIZE7VRQEBEOyFMK81ce0QbOBABMJ7L0JHkylEGPJY 2rr682LuZg02RdkWuRS2+s9tHHBpR+WdD0j/3353PqzlsD5nOCw0EE+ZF+hTw0B/ +5yJQ85GlPRQJSmq0GKYGn9VXnU+0PceLLKQwMZYRuBxiryBP4k8jRjKbixaWM5Y 9QmyBv1pn3wvEU7Q0qixvlb0mkG8iuV+ODijGj7w4jXMJ+v3P22h1rKd+giSyYuR gExKpNayUDopwynCNxOq8DCUd8Y6JC/uQuLWzfTDXlqYHS8YEv0lOaHxi+76W2Vx qN1leg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frq9w86g3-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 08:24:23 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8ef8249f871so7500226d6.0 for ; Fri, 31 Jul 2026 01:24:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785486262; x=1786091062; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to:content-type; bh=tfhVrR1XwzbRp56jy68NgRK5yU4D4Jc9JJLcVAiXFzE=; b=S5z82HG4fpDMcCFkJpizaeIWDj6bu1SA7kljLszKHPtN+fQ8AnXTkcIBWHUbhWrw8Z T5KyGppwgQJflDuXR6oesDsAw1aXo+/FVbQ8UBidv4SAuwu7pS56oExCT5iUL8MUkbQm kun+Mj8MqMtb8NgT+ozOGIxYxrJ30Q6lDruNAEnpM/5atBPcy2frdt9TdWO7C+8kb0cZ EchMALislLDMq7ZZoZlqGoXh4iWg7DxgaMjkRUI43gA6gQd1TXGS6fY4uVHR+t7SIZXZ 6kPH2777N8HD9+67zvuOD0W9mBakZSFfvShX4rWMXwqrsTNJwSz5Kh8Rwo+r0aTMKxOE uuBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785486262; x=1786091062; h=content-transfer-encoding:content-type:in-reply-to:from:references :cc:to:subject:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tfhVrR1XwzbRp56jy68NgRK5yU4D4Jc9JJLcVAiXFzE=; b=PReWxGIeXmGrZPn8L9yMiataOlhL/cI1/Ls4b8wquVMELIvQtJ6jepGk7PrLavuESr CpQw7hO/obZIsuy6ugd8T1SB3+d9LnVFSMBFAyib8bibddLhWNIUwEN6tY9HCQLmEoGQ elpHqMSEhTivVcPSqarpqzLJmSxTzqmTs4/F8pSrWQx83b8bNJoipkK/ytX3/+0kLG0f 2tgH1Iu4sZe/b6vBED1wYn2o1rf2MUk0vtYK+DQg8da9PqJyH4fD/ItPLY+AoIhKkheR xAOWaDFjNt/fLqWJsqSPKrvBLTuhY5Ejf5yyPxqMznN3i65MVDCdlNO5K+PPvF1aWn2G rkSQ== X-Forwarded-Encrypted: i=1; AHgh+RqczzCBBn5LnYr84TIxaYSdKSenQ51cuFEOOWrD2CwGo5TGWjy9m63ZdvYQROlrgNs9EDTPivcWHZka@vger.kernel.org X-Gm-Message-State: AOJu0Yz/chFUOoqSuMfEpogAWU/0RoIxNduxpyGsAuUUPtD1E5yFAP8t MAnzMpP3U4zEB7748M1hcz7LKymHelkViM9gKFBoE4B4LNRSTXwbvZKs8eKNDmhCCkwh67lPi2Q PRHcgHpQqgEAhjTDVrdGMbDYoX9GIfpSkcJsF3r9r/0y9jB11ljTIWQiRDJx+1LxKd5E/kUnFA+ M= X-Gm-Gg: AR+sD13J7LQZJ51JEsx4Pv+75eKVZMBym3WpnnqhSBJ6v0r6zVHec1pcjuy6UcexhF/ /6Knqa9dXezg/9w0G3WiNZrE0UctSehNOFIrIek1bZRMx4uBEg6S/wqX2xpJHtD08HRM6ZluvIX xJ9sRTeEwhN9ZoDyFIW7ocSiWWLkTqdfD7rdvthAcOxIZZuuJkCOJr/sn8+resY4P96G8+j1AvU 0UQKyL40iQo3o3gwEz4+25K1IQUZ+4r7RedGrm+Vl/NisH2vhXXNfCGLzHONfkQJ3zNKLu+7+Jo NEedfv5Z4gspbiviM93PXTaZzGtDcIFFA/4qYYkdLLpwGmq0vJSASMm5LDvWm/oAr5z9xYMM9it FziRc5M6CCd3rjY9eadjTmhzbbeO+g7sS1ojd7zXT62MTMNKXXgEx97BBAjyzHztA X-Received: by 2002:a05:6214:5d04:b0:8f3:9d85:405b with SMTP id 6a1803df08f44-908421b4b9emr17416896d6.16.1785486261887; Fri, 31 Jul 2026 01:24:21 -0700 (PDT) X-Received: by 2002:a05:6214:5d04:b0:8f3:9d85:405b with SMTP id 6a1803df08f44-908421b4b9emr17416506d6.16.1785486261404; Fri, 31 Jul 2026 01:24:21 -0700 (PDT) Received: from [10.111.175.212] (Global_NAT1_IAD_FW.qualcomm.com. [129.46.232.65]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-908435eab41sm5401746d6.34.2026.07.31.01.24.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Jul 2026 01:24:20 -0700 (PDT) Message-ID: Date: Fri, 31 Jul 2026 16:24:15 +0800 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] media: i2c: Add Samsung S5KJN5 image sensor driver To: Vladimir Zapolskiy , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Sakari Ailus Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260724-sk5jn5-v2-0-871d3b9a2e47@oss.qualcomm.com> <20260724-sk5jn5-v2-2-871d3b9a2e47@oss.qualcomm.com> <2b5753f2-d5f4-4957-b865-f06b842af3de@linaro.org> From: Wenmeng Liu In-Reply-To: <2b5753f2-d5f4-4957-b865-f06b842af3de@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=DPq/JSNb c=1 sm=1 tr=0 ts=6a6c5bb7 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=C3Dk8TwHQYyIj7nOf9RCJw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=z7GYzWamlFIOCxjLmCIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA1OSBTYWx0ZWRfXwdNY2Xktdr8E HxiuPv0Q+674ajeI+gmvIZadJ1HZiyA6JKNzub0JT0+FyceE2YINPBG71GNnvGiiBuMVcK2zNjS w2krKxGWu4pDNUEPlvuVqvYPwDUu+aShr3GLdfBk5bpbqelJZho44G1V2rGflwTl4IMSEqdMTvc p/86EzZt3JYYhGNslYGWj2kYNtu14/E+mSoH16vQnmUVbrSTAkuW8Wh7X80Jt9n5zWUwyiTIqK8 92zxoScJJ4sut1LPsR+UPKKO2nOhoe+WjnvyIt5JJ4NM6r9QAKRDJiwmIC3S2FbmJzIRqldPVgy 5CdYV+feUta9QMQFZYuRSeNiTKaDnWAxWFblfPeJCp46AIK4R0+gM82B7TcBZjlc1at5X4sCY30 QYIpZiXt730gMW0/8kK6JY+7gY/3U82PNR3C3Yjhr+tN0x4eIhzPzgSo/Z2xAUNHQ3XGv1/VcLc xyZBRzSjOkZoccSe73g== X-Proofpoint-ORIG-GUID: 9RxF2rBZtjQAzXVIYR7DNltvEjmitAe3 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA1OSBTYWx0ZWRfXxcvb6r1/KL25 RtPDU80S2vx3Kyj8oCXAO/dEyauHFNhnmbjiAN7SGwOYKInH4WECvDFKmRU5tJVgeBKHn0Dc1s5 d1d9SnY1PA4w8X+MUi2O4yXsTDTTY8Y= X-Proofpoint-GUID: 9RxF2rBZtjQAzXVIYR7DNltvEjmitAe3 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 spamscore=0 clxscore=1015 malwarescore=0 impostorscore=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310059 Hi Vladimir, On 7/25/2026 3:22 PM, Vladimir Zapolskiy wrote: > Hi Wenmeng. > > On 7/24/26 12:50, Wenmeng Liu wrote: >> Add a V4L2 sub-device driver for the Samsung S5KJN5, a 50 MP GBRG 10-bit > > I believe "GBRG" detalization here will be incorrect, if you consider image > flips or odd crops. > >> RAW MIPI CSI-2 image sensor. The driver supports the 4096x3072 mode and >> exposes the standard controls (exposure, gain, vblank/hblank, test >> pattern). >> >> Signed-off-by: Wenmeng Liu >> --- >>   MAINTAINERS                |    1 + >>   drivers/media/i2c/Kconfig  |   11 + >>   drivers/media/i2c/Makefile |    1 + >>   drivers/media/i2c/s5kjn5.c | 2835 ++++++++++++++++++++++++++++++++++ >> ++++++++++ >>   4 files changed, 2848 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index >> 244c7ed5872aa0972a7b055d7e0b19d530820a08..6f6edae5de13efc0cda6c91ab8c9a40bfe2cbff9 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -24195,6 +24195,7 @@ M:    Wenmeng Liu >>   L:    linux-media@vger.kernel.org >>   S:    Supported >>   F:    Documentation/devicetree/bindings/media/i2c/samsung,s5kjn5.yaml >> +F:    drivers/media/i2c/s5kjn5.c >>   SAMSUNG S5P Security SubSystem (SSS) DRIVER >>   M:    Krzysztof Kozlowski >> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig >> index >> 7ffccba897ae5637bd0cb913e1e04f9c7d0c89f5..06b5dbc32cab328df8d10da04d91a708bff6fdda 100644 >> --- a/drivers/media/i2c/Kconfig >> +++ b/drivers/media/i2c/Kconfig >> @@ -824,6 +824,17 @@ config VIDEO_S5KJN1 >>         To compile this driver as a module, choose M here: the >>         module will be called s5kjn1. >> +config VIDEO_S5KJN5 >> +    tristate "Samsung S5KJN5 sensor support" >> +    depends on GPIOLIB >> +    select V4L2_CCI_I2C >> +    help >> +      This is a V4L2 sensor driver for Samsung S5KJN5 50MP GBRG > > Same comment as above, I believe "GBRG" should be either removed or > generalized to "Bayer" or "raw". > >> +      10-bit RAW MIPI CSI-2 camera sensor. >> + >> +      To compile this driver as a module, choose M here: the >> +      module will be called s5kjn5. >> + >>   config VIDEO_T4KA3 >>       tristate "Toshiba T4KA3 sensor support" >>       depends on ACPI || COMPILE_TEST >> diff --git a/drivers/media/i2c/Makefile b/drivers/media/i2c/Makefile >> index >> d04bd5724552e88fc2ad39f9bbaf9b4ce1763939..45019ce20a6c34c8139b8247b6904c3abb1a8fe7 100644 >> --- a/drivers/media/i2c/Makefile >> +++ b/drivers/media/i2c/Makefile >> @@ -133,6 +133,7 @@ obj-$(CONFIG_VIDEO_S5K3M5) += s5k3m5.o >>   obj-$(CONFIG_VIDEO_S5K5BAF) += s5k5baf.o >>   obj-$(CONFIG_VIDEO_S5K6A3) += s5k6a3.o >>   obj-$(CONFIG_VIDEO_S5KJN1) += s5kjn1.o >> +obj-$(CONFIG_VIDEO_S5KJN5) += s5kjn5.o >>   obj-$(CONFIG_VIDEO_SAA6588) += saa6588.o >>   obj-$(CONFIG_VIDEO_SAA6752HS) += saa6752hs.o >>   obj-$(CONFIG_VIDEO_SAA7110) += saa7110.o >> diff --git a/drivers/media/i2c/s5kjn5.c b/drivers/media/i2c/s5kjn5.c >> new file mode 100644 >> index >> 0000000000000000000000000000000000000000..865db808aabcf7d910acbdab8126b9fa308ef875 >> --- /dev/null >> +++ b/drivers/media/i2c/s5kjn5.c >> @@ -0,0 +1,2835 @@ >> +// SPDX-License-Identifier: GPL-2.0 >> +/* >> + * Samsung S5KJN5 50 MP GBRG 10-bit RAW MIPI CSI-2 sensor driver > > Same comment as above. > >> + * >> + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries >> + */ >> + >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include >> +#include > > Let me ask, which interface or declaration from media/v4l2-ctrls.h > is used in the driver? I have a feeling that it's unused. > It is required. The driver call many interfaces form it, like v4l2_ctrl_new_int_menu/__v4l2_ctrl_handler_setup... And thanks a lot for the review. ACK for the rest, and I'll address them in the next revision. Thanks, Wenmeng