From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0E1321B9F5 for ; Sun, 20 Jul 2025 15:24:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753025055; cv=none; b=q+E0noprIFCyek+J39FYJXkUuB50un6ST/Qrd6NW2J0Fr2RMOpUbXn8vQ7fpDBOLmFeYHZUEHidDrbaZNsInh0LiAyyvcWieOr3UDRAVrq4BQgLDoGHyJmcYJJOOEgrVfIofBCFGMOx+7HBI89DQiGag0FgIlhGFABMSC4VU6Vo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753025055; c=relaxed/simple; bh=5RovnvTDAuovyn4cAtpqbi9TnjFhXvo6Fxsbgus1QVo=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=EzgT7Sf+/w3/QvsaM2wkSLIJnlyc2FJPY+RM1caGG9Oej1WfunDZdbUdhNk+WGX1X9wFJKRsfzIXWyAiaQjd+izWdLeqJfvVERPnhhgKLdqtdXKlU2Buw4SCeNKpHjPZBe3jH0scQZ4gB8pGf18tgbe3Sst0kW4HkDA1wDxkad0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=aPpK+mCf; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="aPpK+mCf" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56KErH9V021328 for ; Sun, 20 Jul 2025 15:24:13 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cn5tyQX/xC6r7LynCtZ+cKfCSqVjcFVIFtjOQjXs2ws=; b=aPpK+mCfhjIK+hdD kc7epzo/3ZcjON3f1eCOhZl/+jNOdPGmcQe0iNhhRhkIZJxBFvmBjEoG1lDhrawW WKq8fUcUjITAkKZzMs73dSdMwxcenkCPDRygzrp9jTPA5TCb+IpU5l1TO9gUjEjn ONgP98f1kU/BXLkWA+J5p+fvp4ddAsZCNepIyspJVfaCI6rC/WhfESxgFavA0MQj xyUzWh6zHybxc0wpKiHYy6v3wdM1ZNTEUA9HpxdNwFdx7oe51MwYXq20yqCTd74B OuFamdAimiUVF3VTbfn1qr3alGcNCYIS8se8lgB8HqvLoCOma2tcZP4HfSkiwwsb fGxYvg== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48048tac8k-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Sun, 20 Jul 2025 15:24:12 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-234906c5e29so41479695ad.0 for ; Sun, 20 Jul 2025 08:24:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753025051; x=1753629851; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Cn5tyQX/xC6r7LynCtZ+cKfCSqVjcFVIFtjOQjXs2ws=; b=PJjYSWOOBLVB9H2lrRXghwZoeTwlsGTzEKjODkiIORV9vhchmKy9NRYxPS8SU3dMm4 d3f4AtuyfmKlCjccmbd3Pr0wUk4ucLrZfpGqEDjEBinjS8b1xzO/7BzRQWOUIEppbJDP jR24sbAYuNjxo6IU3Pw0J43KGLbOYg40arYOa8YQkmzfMogMQrKBvi1bMArgf4YTQwOq 2wXPY12lv9Hianfq23lDJlQHp9y9ClFN2+KqRMRmdLjHpBtP5o6m+dY+EZ/eMAYI5QhD KNqOaxSNiFpNOdVRcZRdKyDrTXWWxPQcLMK/ihNewXugmUa3fSKNbR26EY2+O0qW6NvP tekQ== X-Forwarded-Encrypted: i=1; AJvYcCUpa9WeR01nMnUUait79+RlrCmwE2x4zcgDUfOspZCOQvVcpOk0QPv1p/AGTtgV04vOda24uGiQ178B@vger.kernel.org X-Gm-Message-State: AOJu0YzTgmt60i1mV3N+ROcWLLyCFZ6fKxke6MCC29Djqimbqpein/7+ OOFyBZ73Qg2QW8UBJNaPo2q0+Yad6RNDgQnf7GO3uwckGHKyRIpQdw9tthPNYmGwzbbt21cx7/T 4G/Nahf+NLyhv9NmvroiC4BFG8AoBL16ZTyVSiniYiTDAKLzcWfUZNMqDP+fbnxWN X-Gm-Gg: ASbGncumwR/X7i0lStGPsh3FZLDc9ti49uq8j9b42LQiP9DwQhufNXAP5gMcCPJlKUh UD+N5BlBmBvJlNjdbUhTzWeNopjnhUPEx0uXgL2DyndT8+s1piSZwGpmgsVd5puwsst3kGUAXsI y0dO0XooLlgT+q/B2ZpaYaHhWg6SxqUau/kWK+26LZeKqVOyeX2eEWxcmbAHKYbluwGWVegjPkI HUHs5UBbj7WRNGcxBJ1I96+3RKJIhoLJDbfxV/E33KXQO1rirNCkv1JKzZg9MzydXXAZ9mikV4i 9x+MhwqXzqPjxxs2u9pPqDFbEQK++LY0U/JTI6CBuI48c/Ji4ou0/qxPXJsf+hvxwLHd4IvhNpy P X-Received: by 2002:a17:902:e845:b0:234:d7b2:2ac3 with SMTP id d9443c01a7336-23e256b5f6amr233001595ad.20.1753025051559; Sun, 20 Jul 2025 08:24:11 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFUOqsroGWNvuq0aBkHthsIfTFvGKyjKlWXBZvHeY8vMrQhZYhY78dv87gCgxB4llexBH7YVA== X-Received: by 2002:a17:902:e845:b0:234:d7b2:2ac3 with SMTP id d9443c01a7336-23e256b5f6amr233001145ad.20.1753025051069; Sun, 20 Jul 2025 08:24:11 -0700 (PDT) Received: from [192.168.29.115] ([49.43.229.90]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b6b561bsm42672895ad.89.2025.07.20.08.24.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Jul 2025 08:24:10 -0700 (PDT) Message-ID: Date: Sun, 20 Jul 2025 20:54:02 +0530 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [PATCH v11 2/8] power: reset: reboot-mode: Add support for 64 bit magic Content-Language: en-US To: Andrew Lunn Cc: Dmitry Baryshkov , Bartosz Golaszewski , Bjorn Andersson , Sebastian Reichel , Rob Herring , Sudeep Holla , Souvik Chakravarty , Krzysztof Kozlowski , Conor Dooley , Andy Yan , Mark Rutland , Lorenzo Pieralisi , Arnd Bergmann , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, Vinod Koul , Catalin Marinas , Will Deacon , Florian Fainelli , Mukesh Ojha , Stephen Boyd , Andre Draszik , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, Elliot Berman , Srinivas Kandagatla References: <20250717-arm-psci-system_reset2-vendor-reboots-v11-0-df3e2b2183c3@oss.qualcomm.com> <20250717-arm-psci-system_reset2-vendor-reboots-v11-2-df3e2b2183c3@oss.qualcomm.com> <6vlm3ybjpy2jq3cr2pzj4vcmqwoissdml2xmhfzlulfbrpzakt@xrepu6c5zykb> <713b2cc8-1bc7-a8b7-678b-5fc7fe25615a@oss.qualcomm.com> <8d4a42b6-657f-4c30-8e25-4213d8d53a89@lunn.ch> <1653597d-4d6b-a771-fbd8-c129c630ac0a@oss.qualcomm.com> <6227828c-5db0-41c8-956f-eea6f790ccac@lunn.ch> From: Shivendra Pratap In-Reply-To: <6227828c-5db0-41c8-956f-eea6f790ccac@lunn.ch> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzIwMDE0OCBTYWx0ZWRfX1A1R4ENWs4sC WQFne9qBADvtgwBleAnH57Nc78DJNPM0rT0Mq1FuJgsDFkFhxwFUMquftCcTc89HCTdCl+lJWP2 +LJtsdVxIfKSNGDQo8HA6e6Ksce9LcvDx6jtpiYt0L0QiuvTbvJrp32PBsqXCTeuxTl2OwvketD gsKdQP+ITppnGfcXlqbICIcCziVn+JzuK5k3cv2MjwdTG/z5K3Uxi4qNVLoulVP2G+IXmXAj9ZH wqm5r21MfjY/y9/DRmX4pq4/x/QtuJP5p7RjqYLRcz8kZPPiUzOJHHCTml9Tcg7P2NO58iozoPw 96zwhPJkNI2v5j7sD4vjvG8IY2kZk+WiRQ/KNvnZp1YqZXCVBN/QlPQk8pdAbUtIhasaKu3JbO5 CLDzMPXs+iU/zNfoyVk/xMyfNoVHkffR94+6MG7EMQDqYLuq8KLh3TvAODnliFtTVorjYLw7 X-Authority-Analysis: v=2.4 cv=Jb68rVKV c=1 sm=1 tr=0 ts=687d0a1c cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=AKgrFWMC3jRjh4njwhq9Fg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EyloEgBdZQ85O2IC3a4A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-GUID: QQ4aQR5II1e-LPcSJ_WJXdBClZzImCQO X-Proofpoint-ORIG-GUID: QQ4aQR5II1e-LPcSJ_WJXdBClZzImCQO X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-20_01,2025-07-17_02,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=738 adultscore=0 priorityscore=1501 clxscore=1015 phishscore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 malwarescore=0 mlxscore=0 spamscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507200148 On 7/20/2025 8:46 PM, Andrew Lunn wrote: > On Sat, Jul 19, 2025 at 11:07:47PM +0530, Shivendra Pratap wrote: >> >> >> On 7/19/2025 10:27 PM, Andrew Lunn wrote: >>>>>> +static int qcom_pon_reboot_mode_write(struct reboot_mode_driver *reboot, u64 magic) >>>>>> { >>>>>> struct qcom_pon *pon = container_of >>>>>> (reboot, struct qcom_pon, reboot_mode); >>>>>> @@ -37,7 +36,7 @@ static int qcom_pon_reboot_mode_write(struct reboot_mode_driver *reboot, >>>>>> ret = regmap_update_bits(pon->regmap, >>>>>> pon->baseaddr + PON_SOFT_RB_SPARE, >>>>>> GENMASK(7, pon->reason_shift), >>>>>> - magic << pon->reason_shift); >>>>>> + ((u32)magic) << pon->reason_shift); >>> >>> As a general rule of thumb, code with casts is poor quality code. Try >>> to write the code without casts. >>> >>> Maybe something like >>> >>> If (magic > MAX_U32) >>> return -EINVAL; >>> >>> magic_32 = magic; >> sure will update it. And in above, should it be recommended to add a explicit >> cast(for any avoiding any compiler complains)? >> like: magic_32 = (u32)magic; > > I would hope the compiler/optimiser can figure out from the test the > line before that this is a safe conversion. So i don't think you need > a cast. sure, thanks. > > Andrew