From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Douglas Anderson <dianders@chromium.org>,
Bjorn Andersson <andersson@kernel.org>
Cc: mka@chromium.org, swboyd@chromium.org,
Andy Gross <agross@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0
Date: Wed, 1 Mar 2023 23:02:52 +0100 [thread overview]
Message-ID: <d6045df9-fe0f-f013-450e-5d3df4add46b@linaro.org> (raw)
In-Reply-To: <20230301104859.2.I68cbe5d5d45074428469da8c52f1d6a78bdc62fc@changeid>
On 1.03.2023 19:50, Douglas Anderson wrote:
> The earliest kingoftown that I could find in my pile of boards was
> -rev2 and even that revision looks pretty rough (plastics on the case
> are very unfinished). Though I don't actually have details about how
> many -rev0 devices were produced, I can't imagine anyone still using
> one. Let's delete support.
>
> Signed-off-by: Douglas Anderson <dianders@chromium.org>
> ---
Unless there are more kingoftowns on the horizon, the dtsi and ex-r1
dts can be merged.
Konrad
>
> arch/arm64/boot/dts/qcom/Makefile | 3 +-
> .../dts/qcom/sc7180-trogdor-kingoftown-r0.dts | 38 -------------------
> ...n-r1.dts => sc7180-trogdor-kingoftown.dts} | 0
> 3 files changed, 1 insertion(+), 40 deletions(-)
> delete mode 100644 arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
> rename arch/arm64/boot/dts/qcom/{sc7180-trogdor-kingoftown-r1.dts => sc7180-trogdor-kingoftown.dts} (100%)
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
> index a51060378ddc..3ce51093ed8f 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -83,8 +83,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-coachz-r3-lte.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r2.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r3.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-homestar-r4.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r0.dtb
> -dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown-r1.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-kingoftown.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r0.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += sc7180-trogdor-lazor-r1-kb.dtb
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
> deleted file mode 100644
> index 3abd6222fe46..000000000000
> --- a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r0.dts
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> -/*
> - * Google Kingoftown board device tree source
> - *
> - * Copyright 2021 Google LLC.
> - */
> -
> -/dts-v1/;
> -
> -#include "sc7180-trogdor.dtsi"
> -#include "sc7180-trogdor-ti-sn65dsi86.dtsi"
> -#include "sc7180-trogdor-kingoftown.dtsi"
> -
> -/ {
> - model = "Google Kingoftown (rev0)";
> - compatible = "google,kingoftown-rev0", "qcom,sc7180";
> -};
> -
> -/*
> - * In rev1+, the enable pin of pp3300_fp_tp will be tied to pp1800_l10a
> - * power rail instead, since kingoftown does not have FP.
> - */
> -&pp3300_fp_tp {
> - gpio = <&tlmm 74 GPIO_ACTIVE_HIGH>;
> - enable-active-high;
> -
> - pinctrl-names = "default";
> - pinctrl-0 = <&en_fp_rails>;
> -};
> -
> -&tlmm {
> - en_fp_rails: en-fp-rails-state {
> - pins = "gpio74";
> - function = "gpio";
> - drive-strength = <2>;
> - bias-disable;
> - };
> -};
> diff --git a/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts b/arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts
> similarity index 100%
> rename from arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown-r1.dts
> rename to arch/arm64/boot/dts/qcom/sc7180-trogdor-kingoftown.dts
next prev parent reply other threads:[~2023-03-01 22:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 18:50 [PATCH 0/4] arm64: dts: qcom: sc7180: Delete a few unused trogdor dts files Douglas Anderson
2023-03-01 18:50 ` [PATCH 1/4] arm64: dts: qcom: sc7180: Delete wormdingler-rev0 Douglas Anderson
2023-03-01 21:59 ` Konrad Dybcio
2023-03-01 18:50 ` [PATCH 2/4] arm64: dts: qcom: sc7180: Delete kingoftown-rev0 Douglas Anderson
2023-03-01 22:02 ` Konrad Dybcio [this message]
2023-03-01 18:50 ` [PATCH 3/4] arm64: dts: qcom: sc7180: Delete lazor-rev0 Douglas Anderson
2023-03-01 22:03 ` Konrad Dybcio
2023-03-01 18:50 ` [PATCH 4/4] arm64: dts: qcom: sc7180: Delete mrbland Douglas Anderson
2023-03-01 22:05 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6045df9-fe0f-f013-450e-5d3df4add46b@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).