From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Linus Walleij <linusw@kernel.org>, Joel Stanley <joel@jms.id.au>,
linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org,
linux-mmc@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH RFC 01/16] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema
Date: Thu, 18 Dec 2025 08:30:51 +1030 [thread overview]
Message-ID: <d6046a94820cda6bfcc3953d6c737152a9f0cf37.camel@codeconstruct.com.au> (raw)
In-Reply-To: <CAL_JsqJUaKKsJ8BCNbVXe4vLVsQ2Av7VuWqf9DnUKHeLzLb8NQ@mail.gmail.com>
On Wed, 2025-12-17 at 09:37 -0600, Rob Herring wrote:
> On Thu, Dec 11, 2025 at 2:46 AM Andrew Jeffery
> <andrew@codeconstruct.com.au> wrote:
> >
> > From: "Rob Herring (Arm)" <robh@kernel.org>
> >
> > Convert the ASpeed fan controller binding to DT schema format.
> >
> > The '#cooling-cells' value used is 1 rather than 2. '#size-cells' is 0
> > rather 1.
>
> Okay, I can't figure out why I thought '#cooling-cells' needed to be 1
> here. I don't see that anywhere in the tree. The driver for sure only
> supports 2, so anything that's not is an error in any case.
Yeah, I'd started doing some digging to understand your statement about
it needing to be 1 but hadn't got to the bottom of it.
If it can be 2 then great, I can fix up the #size-cells and resend.
Andrew
next prev parent reply other threads:[~2025-12-17 22:00 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 8:45 [PATCH RFC 00/16] Eliminate warnings for AST2500 and AST2600 EVB devicetrees Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 01/16] dt-bindings: hwmon: Convert aspeed,ast2400-pwm-tacho to DT schema Andrew Jeffery
2025-12-11 20:27 ` Guenter Roeck
2025-12-12 5:53 ` Andrew Jeffery
2025-12-17 15:37 ` Rob Herring
2025-12-17 22:00 ` Andrew Jeffery [this message]
2025-12-11 8:45 ` [PATCH RFC 02/16] pinctrl: aspeed: g5: Constrain LPC binding revision workaround to AST2500 Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 03/16] pinctrl: aspeed: g5: Allow use of LPC node instead of LPC host controller Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 04/16] ARM: dts: aspeed: g5: Use LPC phandle for pinctrl aspeed,external-nodes Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 05/16] ARM: dts: aspeed: Remove unspecified LPC host controller node Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 06/16] dt-bindings: mmc: Switch ref to sdhci-common.yaml Andrew Jeffery
2025-12-11 11:31 ` Ulf Hansson
2025-12-11 15:57 ` Rob Herring (Arm)
2025-12-11 17:03 ` Rob Herring
2025-12-11 8:45 ` [PATCH RFC 07/16] ARM: dts: aspeed: Remove sdhci-drive-type property from AST2600 EVB Andrew Jeffery
2025-12-11 11:31 ` Ulf Hansson
2025-12-11 8:45 ` [PATCH RFC 08/16] ARM: dts: aspeed: Use specified wp-inverted property for " Andrew Jeffery
2025-12-11 11:31 ` Ulf Hansson
2025-12-11 8:45 ` [PATCH RFC 09/16] dt-bindings: bus: aspeed: Require syscon for AST2600 AHB controller Andrew Jeffery
2025-12-11 19:56 ` Rob Herring (Arm)
2025-12-11 8:45 ` [PATCH RFC 10/16] dt-bindings: crypto: Document aspeed,ahbc property for Aspeed ACRY Andrew Jeffery
2025-12-11 19:57 ` Rob Herring (Arm)
2025-12-11 8:45 ` [PATCH RFC 11/16] ARM: dts: aspeed: Drop syscon compatible from EDAC in g6 dtsi Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 12/16] ARM: dts: aspeed: g6: Drop unspecified aspeed,ast2600-udma node Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 13/16] ARM: dts: aspeed: ast2600-evb: Tidy up A0 work-around for UART5 Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 14/16] dt-bindings: iio: adc: Allow interrupts property for AST2600 Andrew Jeffery
2025-12-11 19:57 ` Rob Herring (Arm)
2025-12-13 17:02 ` Jonathan Cameron
2025-12-11 8:45 ` [PATCH RFC 15/16] ARM: dts: aspeed: g6: Drop clocks property from arm,armv7-timer Andrew Jeffery
2025-12-11 8:45 ` [PATCH RFC 16/16] dt-bindings: mfd: Document smp-memram node for AST2600 SCU Andrew Jeffery
2025-12-11 15:57 ` Rob Herring (Arm)
2025-12-12 5:57 ` Andrew Jeffery
2025-12-11 14:07 ` [PATCH RFC 00/16] Eliminate warnings for AST2500 and AST2600 EVB devicetrees Rob Herring
2025-12-12 15:06 ` Rob Herring
2025-12-12 23:05 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6046a94820cda6bfcc3953d6c737152a9f0cf37.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).