From: <Claudiu.Beznea@microchip.com>
To: <krzysztof.kozlowski@linaro.org>, <robh@kernel.org>
Cc: <lgirdwood@gmail.com>, <broonie@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <perex@perex.cz>,
<tiwai@suse.com>, <Nicolas.Ferre@microchip.com>,
<alexandre.belloni@bootlin.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding
Date: Tue, 21 Feb 2023 10:52:54 +0000 [thread overview]
Message-ID: <d607c1b6-712e-5c8b-8cd6-86673f4b354d@microchip.com> (raw)
In-Reply-To: <cbe2e397-7044-277d-08a8-93010de339ad@linaro.org>
On 21.02.2023 11:23, Krzysztof Kozlowski wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 21/02/2023 09:10, Claudiu.Beznea@microchip.com wrote:
>> On 21.02.2023 00:56, Rob Herring wrote:
>>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>>>
>>> On Fri, Feb 17, 2023 at 02:41:50PM +0200, Claudiu Beznea wrote:
>>>> Add microchip,startup-delay-us binding to let PDMC users to specify
>>>> startup delay.
>>>
>>> The diff tells me all this. Why does this need to be per platform?
>>
>> PDMC can work with different kind of microphones, thus different boards
>> could have different microphones. Depending on microphone type the PDMC
>> would need to wait longer or shorter period than the default chosen period
>> to filter unwanted noise. Thus the need of having this specified though
>> device tree. Would you prefer to have this in commit message?
>
> I believe you also had explain it to me, thus as you can see having it
> in commit msg would spare you two questions...
Right, I'll add it in the next version.
Thank you,
Claudiu
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2023-02-21 10:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-17 12:41 [PATCH v2 0/3] ASoC: mchp-pdmc: fix poc noises when starting capture Claudiu Beznea
2023-02-17 12:41 ` [PATCH v2 1/3] ASoC: soc-pcm: add option to start DMA after DAI Claudiu Beznea
2023-02-17 13:09 ` Amadeusz Sławiński
2023-02-17 13:14 ` Claudiu.Beznea
2023-02-17 12:41 ` [PATCH v2 2/3] ASoC: dt-bindings: sama7g5-pdmc: add microchip,startup-delay-us binding Claudiu Beznea
2023-02-20 22:56 ` Rob Herring
2023-02-21 8:10 ` Claudiu.Beznea
2023-02-21 9:23 ` Krzysztof Kozlowski
2023-02-21 10:52 ` Claudiu.Beznea [this message]
2023-02-21 14:50 ` Mark Brown
2023-02-17 12:41 ` [PATCH v2 3/3] ASoC: mchp-pdmc: fix poc noise at capture startup Claudiu Beznea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d607c1b6-712e-5c8b-8cd6-86673f4b354d@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=Nicolas.Ferre@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).