Re: [PATCH v5 00/20] mfd: adp5585: support keymap events and drop legacy Input driver

["Nuno Sá" <noname.nuno@gmail.com>]

On Tue, 2025-07-01 at 14:37 +0100, Lee Jones wrote:
> On Tue, 01 Jul 2025, Laurent Pinchart wrote:
> 
> > On Tue, Jul 01, 2025 at 12:09:11PM +0100, Nuno Sá wrote:
> > > On Tue, 2025-07-01 at 12:05 +0100, Lee Jones wrote:
> > > > On Fri, 27 Jun 2025, Nuno Sá wrote:
> > > > 
> > > > > On Thu, 2025-06-19 at 14:38 +0100, Lee Jones wrote:
> > > > > > On Sat, 14 Jun 2025, Nuno Sá via B4 Relay wrote:
> > > > > > 
> > > > > > > Hi all,
> > > > > > > 
> > > > > > > Here it goes v4. Main changes is to drop chip info based struct
> > > > > > > and
> > > > > > > directly use an enum in the FW .data pointer, use the notifier API
> > > > > > > for
> > > > > > > dispatching events and multiple calls to mfd_add_devices().
> > > > > > > 
> > > > > > > Regarding the last point, I think I could have used multiple calls
> > > > > > > to
> > > > > > > devm_mfd_add_devices() and avoid those gotos in
> > > > > > > adp5585_add_devices()
> > > > > > > but I do not feel that would have been "correct".
> > > > > > > 
> > > > > > > Thanks!
> > > > > > > - Nuno Sá
> > > > > > > 
> > > > > > > ---
> > > > > > > Changes in v5:
> > > > > > 
> > > > > > In future, these should be inside the patches themselves please.
> > > > > 
> > > > > Hi Lee,
> > > > > 
> > > > > I'm about to send v6. I just have a question regarding the above. Do
> > > > > you
> > > > > mean to
> > > > > have the log in the commit message itself like DRM or do it with git
> > > > > notes?
> > > > 
> > > > I have no idea what git notes is.
> > > 
> > > It pretty much adds a note before the diff stat but with an annoying
> > > "Notes:"
> > > line. b4 seems to ignore it anyways.
> > > 
> > > > Simply place the Changelog inside the patch, just above the diff stat.
> > > 
> > > There's already some emails about this on v6. I ended up doing it DRM
> > > style
> > > because tweaking the patch before sensing is surprisingly non trivial with
> > > b4.
> > > Unless I missed something.
> > 
> > You can record the changelog in the commit message below a 
> > 
> > ---
> > 
> > line asyou modify commits. That way you won't have to write the
> > changelogs when sending the patches, and b4 should not cause any issue.
> 
> Exactly this.  Should be easy enough.

Yes, just checked now. I was being mistaken by the fact that doing the above
while changing commits will still locally display on my 'git log'. But it will
then be discarded when you apply the patches.

I'll send v7 with the changelog fixed.

- Nuno Sá