From: Matthias Brugger <matthias.bgg@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
Chaotian Jing <chaotian.jing@mediatek.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
yong mao <yong.mao@mediatek.com>,
Linus Walleij <linus.walleij@linaro.org>,
Javier Martinez Canillas <javier@osg.samsung.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Phong LE <ple@baylibre.com>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-mediatek@lists.infradead.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
srv_heupstream <srv_heupstream@mediatek.com>
Subject: Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit
Date: Tue, 10 Oct 2017 10:35:48 +0200 [thread overview]
Message-ID: <d6118956-6fb4-cf7c-010b-b53f1c76b0c3@gmail.com> (raw)
In-Reply-To: <CAPDyKFpzuctUJ7FB9thMi0h602iJZc=kbs7iaVb+0oNCC4K4ng@mail.gmail.com>
On 10/10/2017 09:19 AM, Ulf Hansson wrote:
> On 10 October 2017 at 03:37, Chaotian Jing <chaotian.jing@mediatek.com> wrote:
>> On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote:
>>>
>>> On 10/09/2017 01:35 PM, Chaotian Jing wrote:
>>>> the driver has updated to have an explicit compatible, so update
>>>> binding file according to the driver change.
>>>>
>>>> Signed-off-by: Chaotian Jing <chaotian.jing@mediatek.com>
>>>> ---
>>>> Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>>>> index 3e0a97c..2bb585b 100644
>>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt
>>>> @@ -8,8 +8,8 @@ and the properties used by the msdc driver.
>>>>
>>>> Required properties:
>>>> - compatible: value should be either of the following.
>>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
>>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173
>>>> + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135
>>>> + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173
>>>
>>> You can merge this with patch 1.
>>
>> OK, will merge it in next patch.
>
> No, please don't!
>
> I would like DT documentation changes to be posted in separate
> patches. Moreover, those should be before driver changes, when you
> order the changes in your series.
>
> In this way, the bindings can be reviewed and acked separately, which
> makes it more convenient.
>
Sounds reasonable, sorry for the confusion.
next prev parent reply other threads:[~2017-10-10 8:35 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-09 11:35 [PATCH v2 00/13] mmc: mediatek: add support of mt2701/mt2712 Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 02/13] " Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit Chaotian Jing
2017-10-09 14:54 ` Matthias Brugger
[not found] ` <e4e5fa8b-b6a5-dc70-fbfc-6328493cd073-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2017-10-10 1:37 ` Chaotian Jing
2017-10-10 7:19 ` Ulf Hansson
2017-10-10 8:35 ` Matthias Brugger [this message]
2017-10-13 20:09 ` Rob Herring
2017-10-13 20:14 ` Rob Herring
2017-10-14 2:11 ` Chaotian Jing
[not found] ` <1507548926-9555-1-git-send-email-chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-09 11:35 ` [PATCH v2 01/13] mmc: dt-bindings: Add reg/source_cg/latch-ck for Mediatek MMC bindings Chaotian Jing
2017-10-09 14:53 ` Matthias Brugger
2017-10-09 11:35 ` [PATCH v2 04/13] arm64: dts: mt8173: remove "mediatek, mt8135-mmc" from mmc nodes Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 07/13] mmc: mediatek: add async fifo and data tune support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 08/13] mmc: mediatek: add busy_check support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 09/13] mmc: mediatek: add stop_clk fix and enhance_rx support Chaotian Jing
[not found] ` <1507548926-9555-10-git-send-email-chaotian.jing-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
2017-10-09 15:00 ` Matthias Brugger
2017-10-10 1:39 ` Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 05/13] mmc: mediatek: make hs400_tune_response only for mt8173 Chaotian Jing
2017-10-09 14:58 ` Matthias Brugger
2017-10-10 1:39 ` Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 06/13] mmc: mediatek: add pad_tune0 support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 10/13] mmc: mediatek: add support of source_cg clock Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 11/13] mmc: mediatek: add latch-ck support Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 12/13] mmc: mediatek: improve eMMC hs400 mode read performance Chaotian Jing
2017-10-09 11:35 ` [PATCH v2 13/13] mmc: mediatek: perfer to use rise edge latching for cmd line Chaotian Jing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6118956-6fb4-cf7c-010b-b53f1c76b0c3@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=hkallweit1@gmail.com \
--cc=javier@osg.samsung.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ple@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=will.deacon@arm.com \
--cc=yong.mao@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).