From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthias Brugger Subject: Re: [PATCH v2 03/13] mmc: dt-bindings: make compatible explicit Date: Tue, 10 Oct 2017 10:35:48 +0200 Message-ID: References: <1507548926-9555-1-git-send-email-chaotian.jing@mediatek.com> <1507548926-9555-4-git-send-email-chaotian.jing@mediatek.com> <1507599473.19789.1.camel@mhfsdcap03> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Ulf Hansson , Chaotian Jing Cc: Rob Herring , Mark Rutland , Catalin Marinas , Will Deacon , yong mao , Linus Walleij , Javier Martinez Canillas , Heiner Kallweit , Phong LE , "linux-mmc@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , linux-mediatek@lists.infradead.org, "linux-kernel@vger.kernel.org" , srv_heupstream List-Id: devicetree@vger.kernel.org On 10/10/2017 09:19 AM, Ulf Hansson wrote: > On 10 October 2017 at 03:37, Chaotian Jing wrote: >> On Mon, 2017-10-09 at 16:54 +0200, Matthias Brugger wrote: >>> >>> On 10/09/2017 01:35 PM, Chaotian Jing wrote: >>>> the driver has updated to have an explicit compatible, so update >>>> binding file according to the driver change. >>>> >>>> Signed-off-by: Chaotian Jing >>>> --- >>>> Documentation/devicetree/bindings/mmc/mtk-sd.txt | 4 ++-- >>>> 1 file changed, 2 insertions(+), 2 deletions(-) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mmc/mtk-sd.txt b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> index 3e0a97c..2bb585b 100644 >>>> --- a/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> +++ b/Documentation/devicetree/bindings/mmc/mtk-sd.txt >>>> @@ -8,8 +8,8 @@ and the properties used by the msdc driver. >>>> >>>> Required properties: >>>> - compatible: value should be either of the following. >>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >>>> - "mediatek,mt8173-mmc","mediatek,mt8135-mmc": for mmc host ip compatible with mt8173 >>>> + "mediatek,mt8135-mmc": for mmc host ip compatible with mt8135 >>>> + "mediatek,mt8173-mmc": for mmc host ip compatible with mt8173 >>> >>> You can merge this with patch 1. >> >> OK, will merge it in next patch. > > No, please don't! > > I would like DT documentation changes to be posted in separate > patches. Moreover, those should be before driver changes, when you > order the changes in your series. > > In this way, the bindings can be reviewed and acked separately, which > makes it more convenient. > Sounds reasonable, sorry for the confusion.