From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1AD1013B7AE for ; Tue, 27 Feb 2024 13:28:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709040520; cv=none; b=XbRTJf1OTSu2Klclq54+/pVvzMC7l1j1kPyx8IV8ffzKKgIRkPlZ7PNcpVrBzFU36STZ6Mx8m36XfRy39T0+6HyMPqWl5Fl7/RXw+Dw7tvyr9JRHGvIHvrF5TYIaEqVs0jq+Lo/jUeLAYt8osLg28PRPipeAouJn2Rf/W/al1Zs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709040520; c=relaxed/simple; bh=o2MMtZcg1nPCrRMjPopfyLkNADiPf6kDlW84jMrpkvM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZHDXaQ99ghAVIGZGH8B29Ny8fsA/+lFNbBCDflfl1GwSGuC6TkkYO9WWNBnjM3QY11uODpGFRBcLRjHC5RN4+07Jq/1ewYGePagfEr54zrl26NKY0PSxu4mfd7Bi0iL4k2YzSyMnjIyDs//+46FWmGNr/xhN8UY0KeOXAmONwII= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=n0twzAj0; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="n0twzAj0" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a3f893ad5f4so606925166b.2 for ; Tue, 27 Feb 2024 05:28:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709040516; x=1709645316; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZEHlAA7YKh1er5ipxQxY0qStrUJA7nuiDKK6J0iKTnQ=; b=n0twzAj0KPyiG42Ysv9+uU/A0WuE+kBMu6fTGPdfM/wiZ2QLX8mPzyaqpHesmJRU/c YQYxa0C7JZqGRqfd/x9WxIy8kYCHQRD8pnDIq87QzGOE+BfwQvaQQUFh4LwAQfRwD/wN IOJSEOqWKrEF97DNN9MgsaKbPiu87D2TcMwgON5cfJQqGuN6YSFzUrhKJEwADpNNT2BQ lz5PS0aSWh1GjOAgq293WH2rx+u/qenXRkn/FVDU9pOxQYA3aAh1fu0GQsgR7BDexZ9w IYwYibkcDM+VfKW5Rb6qnLFhZTQDhu9R19hotaryMU6g5f2SfK7X7zA2Rt+w8Bj931A0 msgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709040516; x=1709645316; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZEHlAA7YKh1er5ipxQxY0qStrUJA7nuiDKK6J0iKTnQ=; b=F5B7wPu4uUpRRxDvDecgugBWWnUt1ylH4dd1xcmaBCeTPAo9AeNXp8GyooJ//8Nijl RdiQm/NUGa36q3/+eBkYz5AaCk6//I/0geqymn43pjVgKTE1h8f0ieJ4P/uFKfumMhB/ /PGLGhg7jlTD+X+CkT/7IfBGxgMmygLrN3EZzS/j+YYhhEKZjCbl1KQIsGLmBIt36mFO tm9O1ynuid/ZrREHJ+QFVpQ0jO055S5re8rEhGRjjCIttmAv4pJqPETJsFuIZntg2kwl 0hRhNCWVQr0ynYZbTcXJMmb0jj3CtELQ8P+bzL5kSwDQsXRCejD7BUAOunSxTLvOSJVk IsgA== X-Forwarded-Encrypted: i=1; AJvYcCXLxC0CtT67Azyt6sYY6huRTBARonJYEMs52K6aNLAT0czoqgrsFsHJUegJh35yLrVuLWs+3bb9C/wmENUVyeKKMxu9l+DTfkbUHw== X-Gm-Message-State: AOJu0YyHYqvP5LaYoSkbMANGiHZCFbV9tbx+mzkA9XN+J2vg6VZxeNg6 pJUuka8/+uZZ6PcUn3oaM78RuiqP8pDHOBqOC+08nF1VQslfH32eU8qzhpgEWQ4= X-Google-Smtp-Source: AGHT+IEQSaUkvKdywYgvDY1uVyrYp7GK0Y3ZU+MxIq70rL2kRL46wtA1NilCuTEjvTxI0baN6YTPWg== X-Received: by 2002:a17:906:750:b0:a3f:7fac:6cd2 with SMTP id z16-20020a170906075000b00a3f7fac6cd2mr7064248ejb.43.1709040516287; Tue, 27 Feb 2024 05:28:36 -0800 (PST) Received: from [192.168.1.20] ([178.197.222.116]) by smtp.gmail.com with ESMTPSA id n3-20020a170906118300b00a412d3d506esm784393eja.17.2024.02.27.05.28.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Feb 2024 05:28:35 -0800 (PST) Message-ID: Date: Tue, 27 Feb 2024 14:28:34 +0100 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Convert the Imagination Technologies SPDIF Input Controllerto DT schema. Content-Language: en-US To: =?UTF-8?Q?Javier_Garc=C3=ADa?= Cc: daniel.baluta@nxp.com, Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240227123602.258190-1-javier.garcia.ta@udima.es> From: Krzysztof Kozlowski Autocrypt: addr=krzysztof.kozlowski@linaro.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzTRLcnp5c3p0b2Yg S296bG93c2tpIDxrcnp5c3p0b2Yua296bG93c2tpQGxpbmFyby5vcmc+wsGUBBMBCgA+FiEE m9B+DgxR+NWWd7dUG5NDfTtBYpsFAmI+BxMCGwMFCRRfreEFCwkIBwIGFQoJCAsCBBYCAwEC HgECF4AACgkQG5NDfTtBYptgbhAAjAGunRoOTduBeC7V6GGOQMYIT5n3OuDSzG1oZyM4kyvO XeodvvYv49/ng473E8ZFhXfrre+c1olbr1A8pnz9vKVQs9JGVa6wwr/6ddH7/yvcaCQnHRPK mnXyP2BViBlyDWQ71UC3N12YCoHE2cVmfrn4JeyK/gHCvcW3hUW4i5rMd5M5WZAeiJj3rvYh v8WMKDJOtZFXxwaYGbvFJNDdvdTHc2x2fGaWwmXMJn2xs1ZyFAeHQvrp49mS6PBQZzcx0XL5 cU9ZjhzOZDn6Apv45/C/lUJvPc3lo/pr5cmlOvPq1AsP6/xRXsEFX/SdvdxJ8w9KtGaxdJuf rpzLQ8Ht+H0lY2On1duYhmro8WglOypHy+TusYrDEry2qDNlc/bApQKtd9uqyDZ+rx8bGxyY qBP6bvsQx5YACI4p8R0J43tSqWwJTP/R5oPRQW2O1Ye1DEcdeyzZfifrQz58aoZrVQq+innR aDwu8qDB5UgmMQ7cjDSeAQABdghq7pqrA4P8lkA7qTG+aw8Z21OoAyZdUNm8NWJoQy8m4nUP gmeeQPRc0vjp5JkYPgTqwf08cluqO6vQuYL2YmwVBIbO7cE7LNGkPDA3RYMu+zPY9UUi/ln5 dcKuEStFZ5eqVyqVoZ9eu3RTCGIXAHe1NcfcMT9HT0DPp3+ieTxFx6RjY3kYTGLOwU0EVUNc NAEQAM2StBhJERQvgPcbCzjokShn0cRA4q2SvCOvOXD+0KapXMRFE+/PZeDyfv4dEKuCqeh0 hihSHlaxTzg3TcqUu54w2xYskG8Fq5tg3gm4kh1Gvh1LijIXX99ABA8eHxOGmLPRIBkXHqJY oHtCvPc6sYKNM9xbp6I4yF56xVLmHGJ61KaWKf5KKWYgA9kfHufbja7qR0c6H79LIsiYqf92 H1HNq1WlQpu/fh4/XAAaV1axHFt/dY/2kU05tLMj8GjeQDz1fHas7augL4argt4e+jum3Nwt yupodQBxncKAUbzwKcDrPqUFmfRbJ7ARw8491xQHZDsP82JRj4cOJX32sBg8nO2N5OsFJOcd 5IE9v6qfllkZDAh1Rb1h6DFYq9dcdPAHl4zOj9EHq99/CpyccOh7SrtWDNFFknCmLpowhct9 5ZnlavBrDbOV0W47gO33WkXMFI4il4y1+Bv89979rVYn8aBohEgET41SpyQz7fMkcaZU+ok/ +HYjC/qfDxT7tjKXqBQEscVODaFicsUkjheOD4BfWEcVUqa+XdUEciwG/SgNyxBZepj41oVq FPSVE+Ni2tNrW/e16b8mgXNngHSnbsr6pAIXZH3qFW+4TKPMGZ2rZ6zITrMip+12jgw4mGjy 5y06JZvA02rZT2k9aa7i9dUUFggaanI09jNGbRA/ABEBAAHCwXwEGAEKACYCGwwWIQSb0H4O DFH41ZZ3t1Qbk0N9O0FimwUCYDzvagUJFF+UtgAKCRAbk0N9O0Fim9JzD/0auoGtUu4mgnna oEEpQEOjgT7l9TVuO3Qa/SeH+E0m55y5Fjpp6ZToc481za3xAcxK/BtIX5Wn1mQ6+szfrJQ6 59y2io437BeuWIRjQniSxHz1kgtFECiV30yHRgOoQlzUea7FgsnuWdstgfWi6LxstswEzxLZ Sj1EqpXYZE4uLjh6dW292sO+j4LEqPYr53hyV4I2LPmptPE9Rb9yCTAbSUlzgjiyyjuXhcwM qf3lzsm02y7Ooq+ERVKiJzlvLd9tSe4jRx6Z6LMXhB21fa5DGs/tHAcUF35hSJrvMJzPT/+u /oVmYDFZkbLlqs2XpWaVCo2jv8+iHxZZ9FL7F6AHFzqEFdqGnJQqmEApiRqH6b4jRBOgJ+cY qc+rJggwMQcJL9F+oDm3wX47nr6jIsEB5ZftdybIzpMZ5V9v45lUwmdnMrSzZVgC4jRGXzsU EViBQt2CopXtHtYfPAO5nAkIvKSNp3jmGxZw4aTc5xoAZBLo0OV+Ezo71pg3AYvq0a3/oGRG KQ06ztUMRrj8eVtpImjsWCd0bDWRaaR4vqhCHvAG9iWXZu4qh3ipie2Y0oSJygcZT7H3UZxq fyYKiqEmRuqsvv6dcbblD8ZLkz1EVZL6djImH5zc5x8qpVxlA0A0i23v5QvN00m6G9NFF0Le D2GYIS41Kv4Isx2dEFh+/Q== In-Reply-To: <20240227123602.258190-1-javier.garcia.ta@udima.es> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 27/02/2024 13:35, Javier García wrote: > Convert the Imagination Technologies SPDIF Input Controllerto DT schema. > > Signed-off-by: Javier García > --- > .../bindings/sound/img,spdif-in.txt | 41 ---------- > .../bindings/sound/img,spdif-in.yaml | 80 +++++++++++++++++++ Please use subject prefixes matching the subsystem. You can get them for example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory your patch is touching. Also no need for full stop in subject. > 2 files changed, 80 insertions(+), 41 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/sound/img,spdif-in.txt > create mode 100644 Documentation/devicetree/bindings/sound/img,spdif-in.yaml > > diff --git a/Documentation/devicetree/bindings/sound/img,spdif-in.txt b/Documentation/devicetree/bindings/sound/img,spdif-in.txt > deleted file mode 100644 > index f7ea8c87bf34..000000000000 > --- a/Documentation/devicetree/bindings/sound/img,spdif-in.txt > +++ /dev/null > @@ -1,41 +0,0 @@ ... > diff --git a/Documentation/devicetree/bindings/sound/img,spdif-in.yaml b/Documentation/devicetree/bindings/sound/img,spdif-in.yaml > new file mode 100644 > index 000000000000..d201293d63c7 > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/img,spdif-in.yaml > @@ -0,0 +1,80 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/sound/img,spdif-in.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Imagination Technologies SPDIF Input Controller > + > +maintainers: > + - Rob Herring > + - Krzysztof Kozlowski No, unfortunately this cannot be us. Choose someone responsible for hardware or Linux drivers at least. > + > +properties: > + compatible: > + enum: > + - img,spdif-in > + > + reg: > + description: > + Offset and length of the register set for the device. Drop description > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + dmas: > + maxItems: 1 > + > + dma-names: > + items: > + - const: rx > + > + clocks: > + items: > + - description: The system clock > + > + clock-names: > + items: > + - const: sys > + > + '#sound-dai-cells': > + const: 0 > + > + resets: > + items: > + - description: Should contain a phandle to the spdif in reset signal, if any Drop description, it's useless. You don't say anything valuable here. Just maxItems: 1 > + > + reset-names: > + items: > + - const: rst > + > +required: > + - compatible > + - reg > + - dmas > + - dma-names > + - clocks > + - clock-names > + - '#sound-dai-cells' > + > +unevaluatedProperties: false This alone does not make sense... so it is pointing you to missing $ref for dai-common. > + > +examples: > + - | > + #include > + #include What for? > + #include > + #include > + #include That's not used, so just add resets and reset-names. > + spdif_in: spdif-in@18100e00 { > + compatible = "img,spdif-in"; > + reg = <0x18100E00 0x100>; Lowercase hex > + interrupts = ; > + dmas = <&mdc 15 0xffffffff 0>; > + dma-names = "rx"; > + clocks = <&cr_periph SYS_CLK_SPDIF_IN>; > + clock-names = "sys"; > + > + #sound-dai-cells = <0>; > + }; Best regards, Krzysztof