Re: (EXT) Re: [PATCH 5/5] ARM: dts: imx6ull: add TQ-Systems MBa6ULLxL device trees

[Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>]

On 10/02/2022 13:10, Alexander Stein wrote:
> Hi Krzysztof,
> 
> Am Dienstag, 8. Februar 2022, 17:09:33 CET schrieb Krzysztof Kozlowski:
>> On 08/02/2022 14:42, Alexander Stein wrote:
>>> Add device trees for the MBa6ULx mainboard with TQMa6ULLxL SoMs.
>>>
>>> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
>>> ---
>>>
>>>  arch/arm/boot/dts/Makefile                    |  1 +
>>>  .../boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts   | 15 ++++
>>>  arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi     | 76 +++++++++++++++++++
>>>  3 files changed, 92 insertions(+)
>>>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>>  create mode 100644 arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>>
>>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>>> index 3a6eccb6371a..9bf89273ae71 100644
>>> --- a/arch/arm/boot/dts/Makefile
>>> +++ b/arch/arm/boot/dts/Makefile
>>> @@ -710,6 +710,7 @@ dtb-$(CONFIG_SOC_IMX6UL) += \
>>>
>>>  	imx6ull-phytec-segin-ff-rdk-emmc.dtb \
>>>  	imx6ull-phytec-segin-lc-rdk-nand.dtb \
>>>  	imx6ull-tqma6ull2-mba6ulx.dtb \
>>>
>>> +	imx6ull-tqma6ull2l-mba6ulx.dtb \
>>>
>>>  	imx6ulz-14x14-evk.dtb \
>>>  	imx6ulz-bsh-smm-m2.dtb
>>>  
>>>  dtb-$(CONFIG_SOC_IMX7D) += \
>>>
>>> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>> b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts new file mode 100644
>>> index 000000000000..33437aae9822
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l-mba6ulx.dts
>>> @@ -0,0 +1,15 @@
>>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>>> +/*
>>> + * Copyright 2018-2022 TQ-Systems GmbH
>>> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "imx6ull-tqma6ull2l.dtsi"
>>> +#include "mba6ulx.dtsi"
>>> +
>>> +/ {
>>> +	model = "TQ Systems TQMa6ULL2L SoM on MBa6ULx board";
>>> +	compatible = "tq,imx6ull-tqma6ull2l-mba6ulx", "tq,imx6ull-
> tqma6ull2l",
>>> "fsl,imx6ull"; +};
>>> diff --git a/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>> b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi new file mode 100644
>>> index 000000000000..8e4d5cd18614
>>> --- /dev/null
>>> +++ b/arch/arm/boot/dts/imx6ull-tqma6ull2l.dtsi
>>> @@ -0,0 +1,76 @@
>>> +// SPDX-License-Identifier: (GPL-2.0-or-later OR MIT)
>>> +/*
>>> + * Copyright 2018-2022 TQ-Systems GmbH
>>> + * Author: Markus Niebel <Markus.Niebel@tq-group.com>
>>> + */
>>> +
>>> +#include "imx6ull.dtsi"
>>> +#include "imx6ul-tqma6ul-common.dtsi"
>>> +#include "imx6ul-tqma6ulxl-common.dtsi"
>>> +
>>> +/ {
>>> +	model = "TQ Systems TQMa6ULL2L SoM";
>>> +	compatible = "tq,imx6ull-tqma6ull2l", "fsl,imx6ull";
>>> +};
>>> +
>>
>> This entire file is exactly the same as tqma6ull2l.dtsi. What's the
>> point of creating additional flavor which is exactly the same? The
>> models look compatible, don't they?
> 
> Thanks for your fast feedback. You mean imx6ull-tqma6ull2.dtsi (wthout 
> trailing 'l')? In this case it's not exactly the same, because the LGA version 
> includes 'imx6ul-tqma6ulxl-common.dtsi' while the non-LGA one includes 
> 'imx6ul-tqma6ulx-common.dtsi'.
> 

Yes, you're right. I missed that include part. Thanks!


Best regards,
Krzysztof