From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3645C4332F for ; Wed, 16 Nov 2022 12:39:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238774AbiKPMj2 (ORCPT ); Wed, 16 Nov 2022 07:39:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55688 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239011AbiKPMjH (ORCPT ); Wed, 16 Nov 2022 07:39:07 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id A68391FCEA; Wed, 16 Nov 2022 04:38:35 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 01AD4150C; Wed, 16 Nov 2022 04:38:41 -0800 (PST) Received: from [10.57.70.190] (unknown [10.57.70.190]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2AD043F663; Wed, 16 Nov 2022 04:38:31 -0800 (PST) Message-ID: Date: Wed, 16 Nov 2022 12:38:19 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] arm64: dts: fsd: Change the reg properties from 64-bit to 32-bit Content-Language: en-GB To: Arnd Bergmann , Vivek Yadav , rcsekar@samsung.com, krzysztof.kozlowski+dt@linaro.org, Wolfgang Grandegger , Marc Kleine-Budde , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , pankaj.dubey@samsung.com, ravi.patel@samsung.com, Alim Akhtar , linux-fsd@tesla.com, Rob Herring Cc: linux-can@vger.kernel.org, Netdev , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, aswani.reddy@samsung.com, sriranjani.p@samsung.com, ajaykumar.rs@samsung.com References: <20221116091247.52388-1-vivek.2311@samsung.com> <37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com> From: Robin Murphy In-Reply-To: <37d42235-1960-4001-9be9-20a85de54730@app.fastmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 2022-11-16 11:16, Arnd Bergmann wrote: > On Wed, Nov 16, 2022, at 10:12, Vivek Yadav wrote: >> Change the reg properties from 64-bit to 32-bit for all IPs, as none of >> the nodes are above 32-bit range in the fsd SoC. >> >> Since dma-ranges length does not fit into 32-bit size, keep it 64-bit >> and move it to specific node where it is used instead of SoC section. > > I don't think that works, the dma-ranges property is part of the > bus, not a particular device: > > mdma0: dma-controller@10100000 { > compatible = "arm,pl330", "arm,primecell"; > - reg = <0x0 0x10100000 0x0 0x1000>; > + reg = <0x10100000 0x1000>; > interrupts = ; > #dma-cells = <1>; > clocks = <&clock_imem IMEM_DMA0_IPCLKPORT_ACLK>; > clock-names = "apb_pclk"; > iommus = <&smmu_imem 0x800 0x0>; > + #address-cells = <2>; > + #size-cells = <2>; > + dma-ranges = <0x0 0x0 0x0 0x10 0x0>; > }; > > Since the dma-controller has no children, I don't see how this has > any effect. Also, translating a 36-bit address into a 32-bit > address just means it gets truncated anyway, so there is no > point in making it appear to have a larger address range. Yes, this is definitely bogus on both counts. Thanks, Robin.