From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03362C4332F for ; Fri, 11 Nov 2022 08:52:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233358AbiKKIw3 (ORCPT ); Fri, 11 Nov 2022 03:52:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233352AbiKKIw1 (ORCPT ); Fri, 11 Nov 2022 03:52:27 -0500 Received: from mail-wr1-x42a.google.com (mail-wr1-x42a.google.com [IPv6:2a00:1450:4864:20::42a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED627742C9; Fri, 11 Nov 2022 00:52:25 -0800 (PST) Received: by mail-wr1-x42a.google.com with SMTP id v1so5542877wrt.11; Fri, 11 Nov 2022 00:52:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=fWQHARWsZHyDNDW+VfA9jOmCKFS0p3M16fZSx03dRMA=; b=BqUtZ5LXXvNy2b8GLKkNRJV6a08miUyHMRg5ZZPpqLycu/8A67XS+YSw4ggEv1eC1G sDOv7+MXfXo/++j8QgrTFK7aZMU/V6r1i0NEkZXdkpnRntdkbQrYPSSo1xE+WXVBdIO+ EnatAj9wiBmQuItct6P8gha1iMdZf9w6EtymKDDGq3Dlm6iaRh77qe040npP1MBS/xu2 Ggm7ulcrPUc6AZOVHHlWniuBTLhMq6C2jr3NA3Fq6Lo2huGVJ06iq8dTFvpfaDtbfO3g ZbtsLA7mT3U1g7UfLBu4jFveIsMSn2S7K6fpbtvxengIxfC95QBWgNP4jNaxBu9YsRJt HKtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fWQHARWsZHyDNDW+VfA9jOmCKFS0p3M16fZSx03dRMA=; b=DeTrMM0nf4NE61zCJ9kgMQwdgwHWlHaJto8KooXCihIFJHH/iPVX43cSkRf2htCh1o uz+phY+hKQLk6VQ1V2yP2GdMXszFYiWSCf/e2tfysPZXCIrgnHIv7dCsIbmy4CX1iiAQ jE4Cx+1lktjs7wBqpPY/y3/LvrRZ/k8O3jIWwmuqHAA4AV/W8BycVClvu6n4Ii6x3kDD BHg0h3Vr5oSPsdUpYApjoWsHkjWj748N+Z8EqQvk8JQLEmU3gQij2egmpUFY/S355iwy cC54d9Xgx1osT5iEjM40MwRTtMRrmw0MNFi6+hTRlBCa39PHeY2W6W8zieawY7yY/LAP Dh7A== X-Gm-Message-State: ANoB5pnTyydfa3C/UHTPlPjVUOEjKE0eBhkLlZIHgPrehOviHzMuzqPm ih9N1arbECxGbzn4mMiUKw0= X-Google-Smtp-Source: AA0mqf7UL/sD+Pg+L06Cb1Hhfjv2tyvAGJl07qQRzclryIVRD0Z6XiRZKuySofUi/zOontyGdWyaVQ== X-Received: by 2002:adf:fecd:0:b0:236:6e2a:ac16 with SMTP id q13-20020adffecd000000b002366e2aac16mr614869wrs.287.1668156744330; Fri, 11 Nov 2022 00:52:24 -0800 (PST) Received: from [192.168.1.131] ([207.188.167.132]) by smtp.gmail.com with ESMTPSA id n2-20020a05600c3b8200b003b476cabf1csm2384819wms.26.2022.11.11.00.52.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 00:52:22 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 09:52:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [RFC v3 03/11] arm64: dts: mt7986: add usb related device nodes Content-Language: en-US To: Frank Wunderlich , linux-mediatek@lists.infradead.org Cc: Frank Wunderlich , Rob Herring , Krzysztof Kozlowski , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Shih References: <20221106085034.12582-1-linux@fw-web.de> <20221106085034.12582-4-linux@fw-web.de> From: Matthias Brugger In-Reply-To: <20221106085034.12582-4-linux@fw-web.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 06/11/2022 09:50, Frank Wunderlich wrote: > From: Sam Shih > > This patch adds USB support for MT7986. > > Signed-off-by: Sam Shih > Signed-off-by: Frank Wunderlich > --- > changes compared to sams original version: > - reorder xhci-clocks based on yaml binding > --- > arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts | 28 ++++++++++ > arch/arm64/boot/dts/mediatek/mt7986a.dtsi | 55 ++++++++++++++++++++ > arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts | 28 ++++++++++ > 3 files changed, 111 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > index 58f7e6b169bf..de5d771e5251 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt7986a-rfb.dts > @@ -23,6 +23,24 @@ memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x40000000>; > }; > + > + reg_3p3v: regulator-3p3v { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_5v: regulator-5v { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > ð { > @@ -136,6 +154,12 @@ &spi1 { > status = "okay"; > }; > > +&ssusb { > + vusb33-supply = <®_3p3v>; > + vbus-supply = <®_5v>; > + status = "okay"; > +}; > + > &switch { > ports { > #address-cells = <1>; > @@ -197,6 +221,10 @@ &uart2 { > status = "okay"; > }; > > +&usb_phy { > + status = "okay"; > +}; > + > &wifi { > status = "okay"; > pinctrl-names = "default", "dbdc"; > diff --git a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > index 6d881095d933..58bbecfbab98 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7986a.dtsi > @@ -246,6 +246,61 @@ uart2: serial@11004000 { > status = "disabled"; > }; > > + ssusb: usb@11200000 { > + compatible = "mediatek,mt7986-xhci", I wasn't able to find the compatible in linux-next. > + "mediatek,mtk-xhci"; > + reg = <0 0x11200000 0 0x2e00>, > + <0 0x11203e00 0 0x0100>; > + reg-names = "mac", "ippc"; > + interrupts = ; > + clocks = <&infracfg CLK_INFRA_IUSB_SYS_CK>, > + <&infracfg CLK_INFRA_IUSB_CK>, > + <&infracfg CLK_INFRA_IUSB_133_CK>, > + <&infracfg CLK_INFRA_IUSB_66M_CK>, > + <&topckgen CLK_TOP_U2U3_XHCI_SEL>; > + clock-names = "sys_ck", > + "ref_ck", > + "mcu_ck", > + "dma_ck", > + "xhci_ck"; > + phys = <&u2port0 PHY_TYPE_USB2>, > + <&u3port0 PHY_TYPE_USB3>, > + <&u2port1 PHY_TYPE_USB2>; > + status = "disabled"; > + }; > + > + usb_phy: t-phy@11e10000 { > + compatible = "mediatek,mt7986-tphy", Same here. Regards, Matthias > + "mediatek,generic-tphy-v2"; > + #address-cells = <2>; > + #size-cells = <2>; > + ranges; > + status = "disabled"; > + > + u2port0: usb-phy@11e10000 { > + reg = <0 0x11e10000 0 0x700>; > + clocks = <&topckgen CLK_TOP_DA_U2_REFSEL>, > + <&topckgen CLK_TOP_DA_U2_CK_1P_SEL>; > + clock-names = "ref", "da_ref"; > + #phy-cells = <1>; > + }; > + > + u3port0: usb-phy@11e10700 { > + reg = <0 0x11e10700 0 0x900>; > + clocks = <&topckgen CLK_TOP_USB3_PHY_SEL>; > + clock-names = "ref"; > + #phy-cells = <1>; > + }; > + > + u2port1: usb-phy@11e11000 { > + reg = <0 0x11e11000 0 0x700>; > + clocks = <&topckgen CLK_TOP_DA_U2_REFSEL>, > + <&topckgen CLK_TOP_DA_U2_CK_1P_SEL>; > + clock-names = "ref", "da_ref"; > + #phy-cells = <1>; > + }; > + }; > + > ethsys: syscon@15000000 { > #address-cells = <1>; > #size-cells = <1>; > diff --git a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts > index 7673aa3fa6ae..cd1763fa7f19 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts > +++ b/arch/arm64/boot/dts/mediatek/mt7986b-rfb.dts > @@ -23,6 +23,24 @@ memory@40000000 { > device_type = "memory"; > reg = <0 0x40000000 0 0x40000000>; > }; > + > + reg_3p3v: regulator-3p3v { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-3.3V"; > + regulator-min-microvolt = <3300000>; > + regulator-max-microvolt = <3300000>; > + regulator-boot-on; > + regulator-always-on; > + }; > + > + reg_5v: regulator-5v { > + compatible = "regulator-fixed"; > + regulator-name = "fixed-5V"; > + regulator-min-microvolt = <5000000>; > + regulator-max-microvolt = <5000000>; > + regulator-boot-on; > + regulator-always-on; > + }; > }; > > ð { > @@ -163,10 +181,20 @@ &spi1 { > status = "okay"; > }; > > +&ssusb { > + vusb33-supply = <®_3p3v>; > + vbus-supply = <®_5v>; > + status = "okay"; > +}; > + > &uart0 { > status = "okay"; > }; > > +&usb_phy { > + status = "okay"; > +}; > + > &wifi { > status = "okay"; > pinctrl-names = "default", "dbdc";