From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elad Nachman <enachman@marvell.com>,
wim@linux-watchdog.org, linux@roeck-us.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
gregory.clement@bootlin.com, chris.packham@alliedtelesis.co.nz,
andrew@lunn.ch, fu.wei@linaro.org, Suravee.Suthikulpanit@amd.com,
al.stone@linaro.org, timur@codeaurora.org,
linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: cyuval@marvell.com
Subject: Re: [PATCH 2/3] arm64: dts: ac5: add watchdog nodes
Date: Thu, 14 Dec 2023 16:15:07 +0100 [thread overview]
Message-ID: <d647ca03-3f28-4c94-a86b-c191ed801e4f@linaro.org> (raw)
In-Reply-To: <20231214150414.1849058-3-enachman@marvell.com>
On 14/12/2023 16:04, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
> Add watchdog nodes to ac5 and ac5x device tree files
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi | 14 ++++++++++++++
> arch/arm64/boot/dts/marvell/ac5-98dx35xx.dtsi | 8 ++++++++
> 2 files changed, 22 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> index b5e042b8e929..e898c6bd31f0 100644
> --- a/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> +++ b/arch/arm64/boot/dts/marvell/ac5-98dx25xx.dtsi
> @@ -307,6 +307,20 @@ nand: nand-controller@805b0000 {
> status = "disabled";
> };
>
> +/*
> + * Global Watchdog:
> + */
Messed indentation. Also unnecessary line breaks around comment, unless
you have some KPI per lines of code. If it is the only watchdog, why
even commenting on it?
> + watchdog: watchdog@80216000 {
> + compatible = "marvell,ac5-wd";
> + reg = <0x0 0x80216000 0 0x1000>,
> + <0x0 0x80215000 0 0x1000>,
> + <0x0 0x80210000 0 0x1000>,
> + <0x0 0x7f900000 0 0x1000>,
> + <0x0 0x840F8000 0 0x1000>;
Lowercase hex.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-14 15:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 15:04 [PATCH 0/3] watchdog: sbsa_gwdt: add support for Marvell ac5 Elad Nachman
2023-12-14 15:04 ` [PATCH 1/3] dt-bindings: watchdog: add Marvell AC5 watchdog Elad Nachman
2023-12-14 15:13 ` Krzysztof Kozlowski
2023-12-14 15:04 ` [PATCH 2/3] arm64: dts: ac5: add watchdog nodes Elad Nachman
2023-12-14 15:15 ` Krzysztof Kozlowski [this message]
2023-12-14 15:04 ` [PATCH 3/3] watchdog: sbsa_gwdt: add support for Marvell ac5 Elad Nachman
2023-12-14 15:16 ` Krzysztof Kozlowski
2023-12-15 1:08 ` kernel test robot
2023-12-15 18:01 ` Rob Herring
2023-12-15 19:12 ` Guenter Roeck
2023-12-15 22:35 ` kernel test robot
2023-12-17 3:08 ` kernel test robot
2023-12-20 14:03 ` Rob Herring
2023-12-15 4:21 ` [PATCH 0/3] " Chris Packham
2023-12-15 17:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d647ca03-3f28-4c94-a86b-c191ed801e4f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Suravee.Suthikulpanit@amd.com \
--cc=al.stone@linaro.org \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=cyuval@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=fu.wei@linaro.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
--cc=timur@codeaurora.org \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).