From: Krzysztof Kozlowski <krzk@kernel.org>
To: Artem Novak <artem122novak@gmail.com>, robh@kernel.org
Cc: krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-sh@vger.kernel.org,
glaubitz@physik.fu-berlin.de
Subject: Re: [PATCH] dt-bindings: soc: document Casio fx-9750GIII
Date: Thu, 22 Oct 2026 09:16:35 +0200 [thread overview]
Message-ID: <d6562416-05aa-452d-8fe5-a68cb8f50f01@kernel.org> (raw)
In-Reply-To: <20261022063902.471383-1-artem122novak@gmail.com>
On 22/10/2026 08:39, Artem Novak wrote:
> Document for the Casio fx-9750GIII graphing calculator,
> which is based on the Renesas SH7305 (SH4A) processor.
>
> Add the Casio vendor prefix and the board compatible
> binding.
This looks oddly wrapped.
Please wrap commit message according to Linux coding style / submission
process (neither too early nor over the limit):
https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597
Anyway, I do not understand why this is sent separately from any other
code. We do not take usually bindings without any users.
>
> Signed-off-by: Artem Novak <artem122novak@gmail.com>
> ---
> .../soc/renesas/casio,fx-9750giii.yaml | 33 +++++++++++++++++++
> .../devicetree/bindings/vendor-prefixes.yaml | 2 ++
> 2 files changed, 35 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
>
> diff --git a/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> new file mode 100644
> index 000000000000..f3c1c02f1bd5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/soc/renesas/casio,fx-9750giii.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/soc/renesas/casio,fx-9750giii.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Casio fx-9750GIII Graphing Calculator
> +
> +maintainers:
> + - Artem Novak <artem122novak@gmail.com>
> +
> +description:
> + The Casio fx-9750GIII graphing calculator is based on
> + the Renesas SH7305 processor.
> +
> +select:
> + properties:
> + compatible:
> + contains:
> + const: casio,fx-9750giii
> + required:
> + - compatible
And this I do not understand at all. Why do you need this?
> +
> +properties:
> + compatible:
> + items:
> + - const: casio,fx-9750giii
> + - const: renesas,sh7305
Where is any user of this?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-10-22 7:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 6:39 [PATCH] dt-bindings: soc: document Casio fx-9750GIII Artem Novak
2026-10-22 6:49 ` sashiko-bot
2026-10-22 7:16 ` Krzysztof Kozlowski [this message]
2026-10-22 7:27 ` John Paul Adrian Glaubitz
2026-10-22 7:33 ` Krzysztof Kozlowski
2026-10-22 7:46 ` John Paul Adrian Glaubitz
2026-10-22 7:57 ` Krzysztof Kozlowski
2026-10-22 8:05 ` Artem Novak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6562416-05aa-452d-8fe5-a68cb8f50f01@kernel.org \
--to=krzk@kernel.org \
--cc=artem122novak@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=glaubitz@physik.fu-berlin.de \
--cc=krzk+dt@kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox