From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v2 02/15] clk: qcom: Use qcom_branch_set_clk_en()
Date: Wed, 29 Nov 2023 20:59:50 +0000 [thread overview]
Message-ID: <d65653d1-e7f6-45c6-ba2c-0ef973866ffb@linaro.org> (raw)
In-Reply-To: <20230717-topic-branch_aon_cleanup-v2-2-2a583460ef26@linaro.org>
On 29/11/2023 18:59, Konrad Dybcio wrote:
> Instead of magically poking at the bit0 of branch clocks' CBCR, use
> the newly introduced helper.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> - /*
> - * Keep clocks always enabled:
> - * cam_cc_gdsc_clk
> - * cam_cc_sleep_clk
> - */
> - regmap_update_bits(regmap, 0x1419c, BIT(0), BIT(0));
> - regmap_update_bits(regmap, 0x142cc, BIT(0), BIT(0));
> + qcom_branch_set_clk_en(regmap, 0x1419c); /* CAM_CC_GDSC_CLK */
> + qcom_branch_set_clk_en(regmap, 0x142cc); /* CAM_CC_SLEEP_CLK */
This all looks functionally correct to me, wondering what your
motivation for changing the comment is though.
Anyway, IDK that matters.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-11-29 20:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-29 18:59 [PATCH v2 00/15] Unregister critical branch clocks + some RPM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 01/15] clk: qcom: branch: Add a helper for setting the enable bit Konrad Dybcio
2023-11-29 20:53 ` Bryan O'Donoghue
2023-11-29 18:59 ` [PATCH v2 02/15] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2023-11-29 20:59 ` Bryan O'Donoghue [this message]
2023-11-29 22:05 ` Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 03/15] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2023-11-29 21:08 ` Bryan O'Donoghue
2023-11-29 22:08 ` Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 04/15] clk: qcom: gcc-sm6375: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 05/15] clk: qcom: gpucc-sm6375: Unregister critical clocks Konrad Dybcio
2023-11-29 21:10 ` Bryan O'Donoghue
2023-11-29 18:59 ` [PATCH v2 06/15] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2023-11-29 21:14 ` Bryan O'Donoghue
2023-11-29 22:09 ` Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 07/15] clk: qcom: gpucc-sm6115: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 08/15] clk: qcom: gcc-sm6115: Unregister critical clocks Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 09/15] clk: qcom: gcc-sm6115: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 10/15] clk: qcom: gcc-qcm2290: Unregister critical clocks Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 11/15] clk: qcom: gcc-qcm2290: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 12/15] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 13/15] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 14/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 15/15] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d65653d1-e7f6-45c6-ba2c-0ef973866ffb@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).