From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="fCMh6vsP" Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 20D68E6 for ; Wed, 29 Nov 2023 12:59:54 -0800 (PST) Received: by mail-wr1-x42d.google.com with SMTP id ffacd0b85a97d-3316c6e299eso158373f8f.1 for ; Wed, 29 Nov 2023 12:59:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701291592; x=1701896392; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=FzQQfOp27wgqk+mvGXV7TAJbuPcrusmFmRn6zVsoj4c=; b=fCMh6vsPNm/I17BBfoq0wveOG2abeVkXoSFKIpjIJCbUKMtYEQrPlVqqqGOnheiqK5 v6kHPHC2e8fQewcK1aJ6bqWdel9R60PVktOlJFMEvucxIsdk09drbberBgJVT1qZpddt AJ4EDXHR/QHOIj7G9UJk6hnmSmgI5204eQMnxtbo33SbblrdId6L3gSaZ10/RRSUSRXL fXdez2ex4ze/6whhycFZa80Aj1jyWYn4y1Tp5UQKaj7LYHSjhvB3wPRp4NQjO9AfnRz6 tXlXGGktRw233ZavCIlVXZprd1EXXOCqoagorpfU6k5b2d7HKI+En1Th853pOpwtPmdn ciWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701291592; x=1701896392; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=FzQQfOp27wgqk+mvGXV7TAJbuPcrusmFmRn6zVsoj4c=; b=YBHBbfQQuEuxtwx2yiYdbUHCb4smsjlJvtw/zeGU4lYGEahvp7A8rwmmtIh7F5RxEw sVLzcBzVIw9yVxdoFQqUFS2PHpvI2Q8UfggcXiSWlh4Q5/azGXFs9+dWhJWZnINsII/n tU2I1HzQT7b8k2WdHqADFljdO9EeJTsiiDn/C4ht3F7pz4TUMwAK8lu0Geg4BRb6oowQ piNgD59eiXGnFUbfbe7T/d4JQZNG1lDp7rFxRl1SjJGHZdq/6QuGMcs6Q94goBb88bro /H2IvXvUMUVxs6R8bSGF+UCWS0tHXpPVvTViA0McBhn7L1D5jU6qYSU2FafeHvP8xFQm fNUA== X-Gm-Message-State: AOJu0Yz08hpo9/Jk1SL8PBRcOAbtQaxdiX4zhCmvnTwb9ULYM7iEujlm as/w5JOWaNc4nl/r+gpGHu9n3A== X-Google-Smtp-Source: AGHT+IFSqhdoAfTiT6S2k82UhyjDcshJX0U75yjF7Rv6AWlXKr5UKlcpowl5+2AHrDv4ASj5TZwRIA== X-Received: by 2002:a5d:6343:0:b0:32f:a5af:99ca with SMTP id b3-20020a5d6343000000b0032fa5af99camr13822722wrw.69.1701291592610; Wed, 29 Nov 2023 12:59:52 -0800 (PST) Received: from [192.168.100.102] ([37.228.218.3]) by smtp.gmail.com with ESMTPSA id hg11-20020a05600c538b00b0040b48690c49sm3410823wmb.6.2023.11.29.12.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 29 Nov 2023 12:59:51 -0800 (PST) Message-ID: Date: Wed, 29 Nov 2023 20:59:50 +0000 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 02/15] clk: qcom: Use qcom_branch_set_clk_en() Content-Language: en-US To: Konrad Dybcio , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: Marijn Suijten , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20230717-topic-branch_aon_cleanup-v2-0-2a583460ef26@linaro.org> <20230717-topic-branch_aon_cleanup-v2-2-2a583460ef26@linaro.org> From: Bryan O'Donoghue In-Reply-To: <20230717-topic-branch_aon_cleanup-v2-2-2a583460ef26@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 29/11/2023 18:59, Konrad Dybcio wrote: > Instead of magically poking at the bit0 of branch clocks' CBCR, use > the newly introduced helper. > > Signed-off-by: Konrad Dybcio > --- > - /* > - * Keep clocks always enabled: > - * cam_cc_gdsc_clk > - * cam_cc_sleep_clk > - */ > - regmap_update_bits(regmap, 0x1419c, BIT(0), BIT(0)); > - regmap_update_bits(regmap, 0x142cc, BIT(0), BIT(0)); > + qcom_branch_set_clk_en(regmap, 0x1419c); /* CAM_CC_GDSC_CLK */ > + qcom_branch_set_clk_en(regmap, 0x142cc); /* CAM_CC_SLEEP_CLK */ This all looks functionally correct to me, wondering what your motivation for changing the comment is though. Anyway, IDK that matters. Reviewed-by: Bryan O'Donoghue