Re: [PATCH 2/5] soc: mediatek: mtk-cmdq: Add cmdq_pkt_jump_rel_temp() for removing shift_pa

["Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>]

On Sat, 2025-11-01 at 19:28 +0800, kernel test robot wrote:
> 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
> 
> 
> Hi Jason-JH,
> 
> kernel test robot noticed the following build errors:
> 
> [auto build test ERROR on linuxtv-media-pending/master]
> [also build test ERROR on media-tree/master linus/master v6.18-rc3
> next-20251031]
> [If your patch is applied to the wrong git tree, kindly drop us a
> note.
> And when submitting patch, we suggest to use '--base' as documented
> in
> https://urldefense.com/v3/__https://git-scm.com/docs/git-format-patch*_base_tree_information__;Iw!!CTRNKA9wMg0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7jrWAz0pEvu18-k7To$
>  ]
> 
> url:   
> https://urldefense.com/v3/__https://github.com/intel-lab-lkp/linux/commits/Jason-JH-Lin/soc-mediatek-Use-pkt_write-function-pointer-for-subsys-ID-compatibility/20251101-000555__;!!CTRNKA9wMg0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7jrWAz0pEvu3sD-kHo$
> base:  
> https://urldefense.com/v3/__https://git.linuxtv.org/media-ci/media-pending.git__;!!CTRNKA9wMg0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7jrWAz0pEvuiN7jJOY$
>   master
> patch link:   
> https://lore.kernel.org/r/20251031160309.1654761-3-jason-jh.lin%40mediatek.com
> patch subject: [PATCH 2/5] soc: mediatek: mtk-cmdq: Add
> cmdq_pkt_jump_rel_temp() for removing shift_pa
> config: x86_64-buildonly-randconfig-001-20251101
> (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/
> 20251101/202511011919.0lkK3DY8-lkp@intel.com/config__;!!CTRNKA9wMg0AR
> bw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7jrWA
> z0pEvuVmcUrRc$ )
> compiler: clang version 20.1.8
> (https://urldefense.com/v3/__https://github.com/llvm/llvm-project__;!
> !CTRNKA9wMg0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnj
> VYv0mFTaP7jrWAz0pEvu9cIYwIM$ 
> 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
> reproduce (this is a W=1 build):
> (https://urldefense.com/v3/__https://download.01.org/0day-ci/archive/
> 20251101/202511011919.0lkK3DY8-lkp@intel.com/reproduce__;!!CTRNKA9wMg
> 0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7j
> rWAz0pEvuU32uhvk$ )
> 
> If you fix the issue in a separate patch/commit (i.e. not just a new
> version of
> the same patch/commit), kindly add following tags
> > Reported-by: kernel test robot <lkp@intel.com>
> > Closes:
> > https://lore.kernel.org/oe-kbuild-all/202511011919.0lkK3DY8-lkp@intel.com/
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/soc/mediatek/mtk-mmsys.c:14:
>    In file included from include/linux/soc/mediatek/mtk-mmsys.h:11:
> > > include/linux/soc/mediatek/mtk-cmdq.h:530:10: error: use of
> > > undeclared identifier 'EIMVAL'
>      530 |         return -EIMVAL;

Oops! I didn't verify this without disabling CONFIG_MTK_CMDQ.

To wait for other maintainers review the full topic,
I'll fix this and rebase the series once the soc patches in (Series
1/4) is applied.

Regards,
Jason-JH Lin

>          |                 ^
>    drivers/soc/mediatek/mtk-mmsys.c:170:26: error: no member named
> 'pkt_write_mask' in 'struct cmdq_client_reg'
>      170 |                 ret = mmsys-
> >cmdq_base.pkt_write_mask(cmdq_pkt,
>          |                       ~~~~~~~~~~~~~~~~ ^
>    drivers/soc/mediatek/mtk-mmsys.c:172:30: error: no member named
> 'pa_base' in 'struct cmdq_client_reg'
>      172 |                                                      
> mmsys->cmdq_base.pa_base,
>          |                                                      
> ~~~~~~~~~~~~~~~~ ^
>    3 errors generated.
> --
>    In file included from drivers/soc/mediatek/mtk-mutex.c:12:
>    In file included from include/linux/soc/mediatek/mtk-mmsys.h:11:
> > > include/linux/soc/mediatek/mtk-cmdq.h:530:10: error: use of
> > > undeclared identifier 'EIMVAL'
>      530 |         return -EIMVAL;
>          |                 ^
>    drivers/soc/mediatek/mtk-mutex.c:1002:16: error: no member named
> 'pkt_write' in 'struct cmdq_client_reg'
>     1002 |         mtx->cmdq_reg.pkt_write(cmdq_pkt, mtx-
> >cmdq_reg.subsys, en_addr, en_addr, 1);
>          |         ~~~~~~~~~~~~~ ^
>    2 errors generated.
> --
>    In file included from mtk-mmsys.c:14:
>    In file included from include/linux/soc/mediatek/mtk-mmsys.h:11:
> > > include/linux/soc/mediatek/mtk-cmdq.h:530:10: error: use of
> > > undeclared identifier 'EIMVAL'
>      530 |         return -EIMVAL;
>          |                 ^
>    mtk-mmsys.c:170:26: error: no member named 'pkt_write_mask' in
> 'struct cmdq_client_reg'
>      170 |                 ret = mmsys-
> >cmdq_base.pkt_write_mask(cmdq_pkt,
>          |                       ~~~~~~~~~~~~~~~~ ^
>    mtk-mmsys.c:172:30: error: no member named 'pa_base' in 'struct
> cmdq_client_reg'
>      172 |                                                      
> mmsys->cmdq_base.pa_base,
>          |                                                      
> ~~~~~~~~~~~~~~~~ ^
>    3 errors generated.
> --
>    In file included from mtk-mutex.c:12:
>    In file included from include/linux/soc/mediatek/mtk-mmsys.h:11:
> > > include/linux/soc/mediatek/mtk-cmdq.h:530:10: error: use of
> > > undeclared identifier 'EIMVAL'
>      530 |         return -EIMVAL;
>          |                 ^
>    mtk-mutex.c:1002:16: error: no member named 'pkt_write' in 'struct
> cmdq_client_reg'
>     1002 |         mtx->cmdq_reg.pkt_write(cmdq_pkt, mtx-
> >cmdq_reg.subsys, en_addr, en_addr, 1);
>          |         ~~~~~~~~~~~~~ ^
>    2 errors generated.
> 
> Kconfig warnings: (for reference only)
>    WARNING: unmet direct dependencies detected for OF_GPIO
>    Depends on [n]: GPIOLIB [=y] && OF [=n] && HAS_IOMEM [=y]
>    Selected by [y]:
>    - GPIO_TB10X [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] &&
> (ARC_PLAT_TB10X || COMPILE_TEST [=y])
>    WARNING: unmet direct dependencies detected for GPIO_SYSCON
>    Depends on [n]: GPIOLIB [=y] && HAS_IOMEM [=y] && MFD_SYSCON [=y]
> && OF [=n]
>    Selected by [y]:
>    - GPIO_SAMA5D2_PIOBU [=y] && GPIOLIB [=y] && HAS_IOMEM [=y] &&
> MFD_SYSCON [=y] && OF_GPIO [=y] && (ARCH_AT91 || COMPILE_TEST [=y])
>    WARNING: unmet direct dependencies detected for I2C_K1
>    Depends on [n]: I2C [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT ||
> COMPILE_TEST [=y]) && OF [=n]
>    Selected by [y]:
>    - MFD_SPACEMIT_P1 [=y] && HAS_IOMEM [=y] && (ARCH_SPACEMIT ||
> COMPILE_TEST [=y]) && I2C [=y]
> 
> 
> vim +/EIMVAL +530 include/linux/soc/mediatek/mtk-cmdq.h
> 
>    526
>    527  /* This wrapper has to be removed after all users migrated to
> jump_rel */
>    528  static inline int cmdq_pkt_jump_rel_temp(struct cmdq_pkt
> *pkt, s32 offset, u8 shift_pa)
>    529  {
>  > 530          return -EIMVAL;
>    531  }
>    532
> 
> --
> 0-DAY CI Kernel Test Service
> https://urldefense.com/v3/__https://github.com/intel/lkp-tests/wiki__;!!CTRNKA9wMg0ARbw!nKZ_THnG2hj_x0PnskSK6csrz_nDUSLqDLwJpsyHAJ1CMg41ahnjVYv0mFTaP7jrWAz0pEvujSdJzZc$