From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Horatiu Vultur <horatiu.vultur@microchip.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Cc: robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com,
claudiu.beznea@microchip.com, arnd@arndb.de, olof@lixom.net,
soc@kernel.org, UNGLinuxDriver@microchip.com,
maxime.chevallier@bootlin.com
Subject: Re: [PATCH 1/2] dt-bindings: arm: at91: add lan966 pcb8309 board
Date: Thu, 21 Jul 2022 08:46:18 +0200 [thread overview]
Message-ID: <d66aae55-1615-1bbc-4f56-2b4806635db4@linaro.org> (raw)
In-Reply-To: <20220720194904.2025384-2-horatiu.vultur@microchip.com>
On 20/07/2022 21:49, Horatiu Vultur wrote:
> Add documentation for Microchip LAN9662 PCB8309.
>
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> Documentation/devicetree/bindings/arm/atmel-at91.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/atmel-at91.yaml b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> index 4e495e03264b..9dc9ad81193a 100644
> --- a/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> +++ b/Documentation/devicetree/bindings/arm/atmel-at91.yaml
> @@ -169,6 +169,12 @@ properties:
> - const: microchip,lan9662
> - const: microchip,lan966
>
> + - description: Microchip LAN9662 PCB8309 Evaluation Board.
> + items:
> + - const: microchip,lan9662-pcb8309
This and other lan9662 boards should be just an enum. You grow the file
needlessly... Unless it is clear preference of maintainer. Other boards
follow normal enum approach, so it seems there is no such preference.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-21 6:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-20 19:49 [PATCH 0/2] ARM: add support for pcb8309 Horatiu Vultur
2022-07-20 19:49 ` [PATCH 1/2] dt-bindings: arm: at91: add lan966 pcb8309 board Horatiu Vultur
2022-07-21 6:46 ` Krzysztof Kozlowski [this message]
2022-07-22 12:52 ` Horatiu Vultur
2022-07-20 19:49 ` [PATCH 2/2] ARM: dts: lan966x: add support for pcb8309 Horatiu Vultur
2022-07-21 6:08 ` Kavyasree.Kotagiri
2022-07-22 12:46 ` Horatiu Vultur - M31836
2022-07-21 7:39 ` Claudiu.Beznea
2022-07-22 12:48 ` Horatiu Vultur - M31836
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d66aae55-1615-1bbc-4f56-2b4806635db4@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=claudiu.beznea@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=nicolas.ferre@microchip.com \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).