From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Marijn Suijten <marijn.suijten@somainline.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Iskren Chernev <iskren.chernev@gmail.com>,
Martin Botka <martin.botka@somainline.org>,
Vinod Koul <vkoul@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema
Date: Mon, 10 Oct 2022 07:31:31 -0400 [thread overview]
Message-ID: <d6765e12-715a-066e-c6c3-63e0962ee3af@linaro.org> (raw)
In-Reply-To: <d97b7d32-6e27-5a04-336b-0af6bd92c83c@linaro.org>
On 10/10/2022 06:26, Krzysztof Kozlowski wrote:
> On 09/10/2022 13:46, Marijn Suijten wrote:
>>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> index 8c582a9e4ada..1fe3fa3ad877 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi
>>> @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 {
>>> #interrupt-cells = <2>;
>>>
>>> sdc2_off_state: sdc2-off-state {
>>> - clk {
>>> + clk-pins {
>>> pins = "sdc2_clk";
>>> drive-strength = <2>;
>>> bias-disable;
>>> };
>>>
>>> - cmd {
>>> + cmd-pins {
>>> pins = "sdc2_cmd";
>>> drive-strength = <2>;
>>> bias-pull-up;
>>> };
>>>
>>> - data {
>>> + data-pins {
>>> pins = "sdc2_data";
>>> drive-strength = <2>;
>>> bias-pull-up;
>>> @@ -413,13 +413,13 @@ clk {
>>> bias-disable;
>>> };
>>>
>>> - cmd {
>>> + cmd-pins-pins {
>>
>> Is this double -pins-pins suffix intended?
>>
>
> No, thanks for noticing it.
Wait, you commented on patch which was already merged. Fix is here already:
https://lore.kernel.org/linux-devicetree/20220930192954.242546-11-krzysztof.kozlowski@linaro.org/
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-10-10 11:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-12 6:17 [PATCH v2 00/40] pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 01/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 02/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: require function on GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 03/40] dt-bindings: pinctrl: qcom,sm6115-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 04/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 05/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 06/40] dt-bindings: pinctrl: qcom,sm6125-pinctrl: extend example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 07/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 08/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 09/40] dt-bindings: pinctrl: qcom,sm6350-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 10/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 11/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 12/40] dt-bindings: pinctrl: qcom,sm6375-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 13/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 14/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: reference tlmm common pins Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 15/40] dt-bindings: pinctrl: qcom,sm8250-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 16/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 17/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 18/40] dt-bindings: pinctrl: qcom,sm8350-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 19/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 20/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 21/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 22/40] dt-bindings: pinctrl: qcom,sm8450-pinctrl: add gpio-line-names Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 23/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: correct number of GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 24/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 25/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: add gpio-line-names Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 26/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: reference tlmm schema Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 27/40] dt-bindings: pinctrl: qcom,sc7280-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 28/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 29/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 30/40] dt-bindings: pinctrl: qcom,sc8180x-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 31/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix matching pin config Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 32/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: do not require function on non-GPIOs Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 33/40] dt-bindings: pinctrl: qcom,sc8280xp-pinctrl: fix indentation in example Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-10-09 17:46 ` Marijn Suijten
2022-10-10 10:26 ` Krzysztof Kozlowski
2022-10-10 11:31 ` Krzysztof Kozlowski [this message]
2022-10-10 13:12 ` Marijn Suijten
2022-09-12 6:17 ` [PATCH v2 35/40] arm64: dts: qcom: sm6350: " Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 36/40] arm64: dts: qcom: sm8350-sagami: correct TS pin property Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 37/40] arm64: dts: qcom: sm8350: align TLMM pin configuration with DT schema Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 38/40] arm64: dts: qcom: sm8450: " Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 39/40] arm64: dts: qcom: sc7280: " Krzysztof Kozlowski
2022-09-12 6:17 ` [PATCH v2 40/40] arm64: dts: qcom: sc7280-herobrine: correct TLMM gpio-line-names Krzysztof Kozlowski
2022-09-13 19:47 ` [PATCH v2 00/40] pinctrl/arm64: qcom: fix some of Qualcomm pinctrl schema warnings Bjorn Andersson
2022-09-13 22:48 ` (subset) " Bjorn Andersson
2022-09-14 10:21 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6765e12-715a-066e-c6c3-63e0962ee3af@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=iskren.chernev@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).