From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFC28C4332F for ; Mon, 10 Oct 2022 11:32:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230421AbiJJLcE (ORCPT ); Mon, 10 Oct 2022 07:32:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39058 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231864AbiJJLcD (ORCPT ); Mon, 10 Oct 2022 07:32:03 -0400 Received: from mail-qt1-x82f.google.com (mail-qt1-x82f.google.com [IPv6:2607:f8b0:4864:20::82f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C0BE40BFE for ; Mon, 10 Oct 2022 04:32:00 -0700 (PDT) Received: by mail-qt1-x82f.google.com with SMTP id h15so2140747qtu.2 for ; Mon, 10 Oct 2022 04:32:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=udkTcYsMkDl++4/6q7yNQSkg4/Iz9OjgmrKT1oZP0DQ=; b=sEerDYita79azCEkmkfrIkb1QxpBkJWvCzAxx5CGwyvQ8JL5VV9RqncCYEXf8gmnQD JQFPIkP5l4N0eBSJzhsfQLDzqsa097vXeE+K1DD3qT2rge7QeEeGKpURYqcw/dddMqhX lbvuMeKXmnUA2ZLbLSUgS+0cib/hQ9302zgLfkg2y+Uhm8Aeyb9P0dRTSbBY+hI/bx+d wt/xbPSTzEX4cz/0uDLWnBn05sH+TA087TrvuxGHkZdCOBgqJjn6PWp3WuC4SkTpXJzC ArI3NEOIPkNl+2KTnkzYO+THinNE669S3U66thuLq9p8/hu5IP1ephvD08AJcZdz8uNl znSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=udkTcYsMkDl++4/6q7yNQSkg4/Iz9OjgmrKT1oZP0DQ=; b=nAyQ3fR6naBjwRJLLR8rw9TEgLHmFagWmoiGHxdYMP1Tswa5SgMhlaQk+UJJXrCoeM kBiQ2eh8cetW6fyrzIZNdMzr969pm08JQrkIC9rLPoI8Wp+Uxhpmk+ZX8TrFy9tsTIcq /EPom92EBaOayIAoJEz/5cbm/8a8hXYx6VUjycVbZLxUM9gru6WoTwd/bEpCHvEDF6NE X2aaaMV0XehqpgNkBVhQSXkXZABXWI8OxnQwFKR4bNkfLHChcszoEtFABkwX/PuUwC74 /wz+58IKVTiZKa1wQlx8YIjHR+OkWdiCNMsFWSM8lf2WLhmKZEqtxUJaZ4/I0z49Pmn5 wb5w== X-Gm-Message-State: ACrzQf3IXw0dvDOM6iQvSbQO2jlRnWWR29l0dd2xeU7kk9U1pZLwwbpE JzUjRt7dFixjcSjhwQbWkU8Whw== X-Google-Smtp-Source: AMsMyM6iDYU0n449yi/Poervh+Wt+/XsqG8kherp0ZrmI4+Cj/yOkKE+y4HGbuPzT3U81A0Ak8GACw== X-Received: by 2002:a05:622a:58d:b0:394:9d68:edc2 with SMTP id c13-20020a05622a058d00b003949d68edc2mr14696370qtb.230.1665401519621; Mon, 10 Oct 2022 04:31:59 -0700 (PDT) Received: from [192.168.1.57] (cpe-72-225-192-120.nyc.res.rr.com. [72.225.192.120]) by smtp.gmail.com with ESMTPSA id bs10-20020ac86f0a000000b0038d9555b580sm5056528qtb.44.2022.10.10.04.31.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 10 Oct 2022 04:31:58 -0700 (PDT) Message-ID: Date: Mon, 10 Oct 2022 07:31:31 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 34/40] arm64: dts: qcom: sm6125: align TLMM pin configuration with DT schema Content-Language: en-US From: Krzysztof Kozlowski To: Marijn Suijten Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Linus Walleij , Rob Herring , Krzysztof Kozlowski , Iskren Chernev , Martin Botka , Vinod Koul , linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220912061746.6311-1-krzysztof.kozlowski@linaro.org> <20220912061746.6311-35-krzysztof.kozlowski@linaro.org> <20221009174621.ecamh76faoibuykv@SoMainline.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 10/10/2022 06:26, Krzysztof Kozlowski wrote: > On 09/10/2022 13:46, Marijn Suijten wrote: >>> diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi >>> index 8c582a9e4ada..1fe3fa3ad877 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi >>> @@ -387,19 +387,19 @@ tlmm: pinctrl@500000 { >>> #interrupt-cells = <2>; >>> >>> sdc2_off_state: sdc2-off-state { >>> - clk { >>> + clk-pins { >>> pins = "sdc2_clk"; >>> drive-strength = <2>; >>> bias-disable; >>> }; >>> >>> - cmd { >>> + cmd-pins { >>> pins = "sdc2_cmd"; >>> drive-strength = <2>; >>> bias-pull-up; >>> }; >>> >>> - data { >>> + data-pins { >>> pins = "sdc2_data"; >>> drive-strength = <2>; >>> bias-pull-up; >>> @@ -413,13 +413,13 @@ clk { >>> bias-disable; >>> }; >>> >>> - cmd { >>> + cmd-pins-pins { >> >> Is this double -pins-pins suffix intended? >> > > No, thanks for noticing it. Wait, you commented on patch which was already merged. Fix is here already: https://lore.kernel.org/linux-devicetree/20220930192954.242546-11-krzysztof.kozlowski@linaro.org/ Best regards, Krzysztof