From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E86056443 for ; Sat, 13 Apr 2024 20:13:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713039193; cv=none; b=ZCDdhPDaVJjrkCj/XFCZ45xMLA0nilyqpu/nGq6ae8Wos1mLdDUFr4QmO03Ux3X8UVgrVOOk6jwfy/Gy/7+rYzmWgvsp0p8Q1MnlfQ9JIgjJMgzxJlWxnEK51Hwlgq+OQ32I8YslwGbensn5/ScnXk6sDY3QZuCfBndiC5TYaIE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713039193; c=relaxed/simple; bh=6An0L48kYFjflh8FlJpVAhC+mhCU5vKixogNl4dF0Lw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=E6kGLEWL93oj1zpvHk5Fcwu3CB01dbM4262ouGOpSlTfWUt1yIyDosA86QtjnGOvMQX1TFLY9s8oSuvN1EoaefQOt6bZH3l5RrkJJIcydthYNvkZYvPl12nXYOqculAtNfIMr8dWk9oQHn58kz89HSx73ZLDB6feoojel7nGYlw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=ir1RjVBh; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="ir1RjVBh" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-516d8764656so720901e87.1 for ; Sat, 13 Apr 2024 13:13:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1713039190; x=1713643990; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=c21Lbybh5bmPv2qzfkq/dwgMQUd0Rl2nuEZhArPPfjE=; b=ir1RjVBhYTpya0sQyy7zJMTQJwnyQ+iZZyW4z39MvEansbjihvqYYBTix6lm1e7eIy BaIwCxyjSmb2nDJdnA8mqUFwhkbQpC1DKG+EF+UwdbXpO6VQDNX6Oir4+1kGQgsbJXFU AhPH3CMpMAuMaqovpQcGdpU+KOoYaqUWMjd/EM9MBnhV0gYEkdooUJJUu/vIHv+eb1nH R1EMPyjmWaIUEntXFRGJgt3LDPhEx9+uJbgV0wqIDybXk7mZEbaII3Soak1i24wupgOV Pq++HXyW2S/xb9FyThU7v2s9IpaQC0SmqCUP/gZJXWq/7rYNASpiq3aO8eqsZYFJ+WkG MZJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713039190; x=1713643990; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=c21Lbybh5bmPv2qzfkq/dwgMQUd0Rl2nuEZhArPPfjE=; b=dLx7gCgG6T/xp12HpvNuL5CSbc13zU3E17i+aHhxcocWn/cgdN1IYDlpnHvYSfz1bP 826tX7aqesqIQctaP/KeV36UXgLYsI1vxn8Ov1QAyH8uFMA6N5AbjR0JSJg8EiGPYbre jSL3m3NSfoTQSwPXvVuhEojXJPiDd2LQiBQN4I/SlPJBVvpt5zKsheVZOyiGsadGDro4 KKicL/kK9Ahk1fkr1kjESGX5wbLJ5zP6QEs4/8MpNfHQPmtWGItRk2GiiVgxI9ISFZcA UB5ZDT9kR9Bc5wRKb8qjgZiuct+gIulhmCq+ZqE8CZKWJGaT9mWWDCp5oMPikH5Xoj9Y kvfA== X-Forwarded-Encrypted: i=1; AJvYcCVMSJKyfdBWLhD1OSm1LzwOiKMamyjFpzOVWKdfeH9lk5zUW1uJCoZvrF0qoxwxUgjeNDKBjRMULgr1kmeQmskAnuDpsGzyonPh3g== X-Gm-Message-State: AOJu0YyQrd6A4d/iPWLlRp2iFj+I79PE0WS+ewRYIdtd6cVStCJ3A0WO xGhhseVpng77U00+MnmSrme3wXssAAp6hdmTCuynDw0FAc8/bhF5PErnr0aOVQw= X-Google-Smtp-Source: AGHT+IEJIzEdlJ2h1Ko7lKjyl2QgL2RSUc87dFSTgw5U3NIFfqQuNFJckIWYYM5uOg82JI6kCKNPWw== X-Received: by 2002:a05:6512:3d1a:b0:513:ca5a:e9cb with SMTP id d26-20020a0565123d1a00b00513ca5ae9cbmr4541232lfv.4.1713039189663; Sat, 13 Apr 2024 13:13:09 -0700 (PDT) Received: from [192.168.1.102] (88-112-131-206.elisa-laajakaista.fi. [88.112.131.206]) by smtp.gmail.com with ESMTPSA id b17-20020a0565120b9100b00516d1afe4f6sm362963lfv.290.2024.04.13.13.13.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 13 Apr 2024 13:13:09 -0700 (PDT) Message-ID: Date: Sat, 13 Apr 2024 23:13:08 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] dt-bindings: i2c: qcom-cci: Document sc8280xp compatible Content-Language: en-US To: Bryan O'Donoghue , wsa@kernel.org, Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240412-linux-next-24-04-11-sc8280xp-cci-compat-string-fix-v1-1-7dbafff36932@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <20240412-linux-next-24-04-11-sc8280xp-cci-compat-string-fix-v1-1-7dbafff36932@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Bryan, On 4/12/24 16:53, Bryan O'Donoghue wrote: > Add sc8280xp compatible consistent with recent CAMSS CCI interfaces. > > sc8280xp has the following clock list and so requires its own compat > string and sc8280xp specific clock definition in the yaml. > > - const: camnoc_axi > - const: slow_ahb_src > - const: cpas_ahb > - const: cci > > Signed-off-by: Bryan O'Donoghue > --- > Initially I added a compat string to yaml and driver for sc8280xp but, it > was incomplete and wrong so I asked for a revert. > > Subsequent to posting the compat string I had posted dtsi changes to > sc8280xp to add in the CCI, forgetting to follow up on the compat revert. > > I then completely forgot about the compat string and worse still > misremembered the whole reasoning behind it. > > This one patch series cleans up the mess. > > - The fallback compat qcom,msm8916-cci hooks the driver. > Since there are no driver changes specific to sc8280xp we don't > need to add yet another entry to the CCI driver. > > - The compat string qcom,sc8280xp-cci is additionally declared in > the dts -> compat = "qcom,msm8916-cci", "qcom,sc8280xp-cci"; > The sc8280xp-cci will match the yaml and enforce constraints. > > - The yaml entry for qcom,sc8280xp-cci constrains the list of > clocks which is specific to sc8280xp-cci > > Result: > > - No new redundant compat string in the CCI driver > > - DTS is unchanged > > - YAML expanded to capture missing string > I believe it's excellent, thank you very much for the change and efforts! Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir