From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Pankaj Gupta <pankaj.gupta@nxp.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"krzysztof.kozlowski+dt@linaro.org"
<krzysztof.kozlowski+dt@linaro.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"festevam@gmail.com" <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: Varun Sethi <V.Sethi@nxp.com>
Subject: Re: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr
Date: Mon, 10 Jul 2023 08:23:47 +0200 [thread overview]
Message-ID: <d69221f2-4947-f4e5-4a37-550ba13a0d9f@linaro.org> (raw)
In-Reply-To: <PAXPR04MB8638AD814BC6A3BFF6A822209530A@PAXPR04MB8638.eurprd04.prod.outlook.com>
On 10/07/2023 07:27, Pankaj Gupta wrote:
> Hi All,
>
> Gentle reminder. Please review this patch.
>
> Thanks.
> Pankaj
>
>> -----Original Message-----
>> From: Pankaj Gupta <pankaj.gupta@nxp.com>
>> Sent: Monday, June 26, 2023 10:17 AM
>> To: robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
>> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de;
>> kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx <linux-
>> imx@nxp.com>; devicetree@vger.kernel.org; linux-arm-
>> kernel@lists.infradead.org; linux-kernel@vger.kernel.org
>> Cc: Pankaj Gupta <pankaj.gupta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>
>> Subject: [PATCH v2] arm64: dts: imx8ulp-evk: add caam jr
>>
>> V2: Changed the email subject line.
>> ------------------------------------------------
>>
>>
That's not a place for changelog. It goes after --- .
>> Add crypto node in device tree for:
>> - CAAM job-ring
>>
>> Signed-off-by: Varun Sethi <v.sethi@nxp.com>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
>> ---
>> arch/arm64/boot/dts/freescale/imx8ulp.dtsi | 32
>> ++++++++++++++++++++++
>> 1 file changed, 32 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> index 32193a43ff49..ce8de81cac9a 100644
>> --- a/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> +++ b/arch/arm64/boot/dts/freescale/imx8ulp.dtsi
>> @@ -207,6 +207,38 @@ pcc3: clock-controller@292d0000 {
>> #reset-cells = <1>;
>> };
>>
>> + crypto: crypto@292e0000 {
>> + compatible = "fsl,sec-v4.0";
>> + #address-cells = <1>;
>> + #size-cells = <1>;
>> + reg = <0x292e0000 0x10000>;
reg is after compatible
>> + ranges = <0 0x292e0000 0x10000>;
ranges should be third.
>> +
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-07-10 6:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-16 17:40 [PATCH 1/9] arm64: dts: imx8ulp-evk: add caam jr Pankaj Gupta
2023-06-26 1:26 ` Peng Fan
2023-06-26 4:46 ` Pankaj Gupta
2023-06-26 4:46 ` [PATCH v2] " Pankaj Gupta
2023-07-10 5:27 ` Pankaj Gupta
2023-07-10 6:23 ` Krzysztof Kozlowski [this message]
2023-07-10 6:25 ` Krzysztof Kozlowski
2023-07-18 2:07 ` Shawn Guo
2023-07-18 4:50 ` [EXT] " Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d69221f2-4947-f4e5-4a37-550ba13a0d9f@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=V.Sethi@nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pankaj.gupta@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).