From: Krzysztof Kozlowski <krzk@kernel.org>
To: Stefan Binding <sbinding@opensource.cirrus.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-sound@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@opensource.cirrus.com
Subject: Re: [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the cirrus,subsystem-id property
Date: Sat, 13 Sep 2025 15:48:12 +0200 [thread overview]
Message-ID: <d6a70fc3-eec2-4de4-a107-d687fc0a31aa@kernel.org> (raw)
In-Reply-To: <20250912154759.279661-2-sbinding@opensource.cirrus.com>
On 12/09/2025 17:47, Stefan Binding wrote:
> Add new property: cirrus,subsystem-id
> This new property is used to uniquely identify the system if device
> tree is used, to allow the driver to select the correct firmware and
> tuning for the system.
>
> Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
> ---
> Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> index 14dea1feefc5..e6cf2ebcd777 100644
> --- a/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> +++ b/Documentation/devicetree/bindings/sound/cirrus,cs35l41.yaml
> @@ -151,6 +151,12 @@ properties:
> minimum: 0
> maximum: 5
>
> + cirrus,subsystem-id:
> + $ref: /schemas/types.yaml#/definitions/string
> + description:
> + Subsystem ID. If this property is present, it sets the system name,
> + used to identify the firmware and tuning to load.
Please do not send new version immediately, but allow people to actually
review your code. You received the review on v1.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-09-13 13:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-12 15:47 [PATCH v2 0/2] Support reading Subsystem ID from Device Tree Stefan Binding
2025-09-12 15:47 ` [PATCH v2 1/2] ASoC: dt-bindings: cirrus,cs35l41: Document the cirrus,subsystem-id property Stefan Binding
2025-09-13 13:48 ` Krzysztof Kozlowski [this message]
2025-09-12 15:47 ` [PATCH v2 2/2] ASoC: cs35l41: Fallback to reading Subsystem ID property if not ACPI Stefan Binding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6a70fc3-eec2-4de4-a107-d687fc0a31aa@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=patches@opensource.cirrus.com \
--cc=robh@kernel.org \
--cc=sbinding@opensource.cirrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).