devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "mirela.rabulea@oss.nxp.com" <mirela.rabulea@oss.nxp.com>
To: Ming Qian <ming.qian@nxp.com>,
	mchehab@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de
Cc: hverkuil-cisco@xs4all.nl, kernel@pengutronix.de,
	festevam@gmail.com, linux-imx@nxp.com,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg
Date: Sat, 23 Apr 2022 03:52:17 +0300	[thread overview]
Message-ID: <d6ac234f-c21b-b583-f375-1e7cbdd89adf@oss.nxp.com> (raw)
In-Reply-To: <20220406094703.8229-1-ming.qian@nxp.com>



On 06.04.2022 12:47, Ming Qian wrote:
> Wait finishing jpeg job before system sleep,
> otherwise the encoding/decoding can't be resumed after suspend.
> 
> Signed-off-by: Ming Qian <ming.qian@nxp.com>

Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>

> ---
>   .../media/platform/nxp/imx-jpeg/mxc-jpeg.c    | 24 +++++++++++++++++++
>   1 file changed, 24 insertions(+)
> 
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index ccc26372e178..3df51d866011 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2356,9 +2356,33 @@ static int mxc_jpeg_runtime_suspend(struct device *dev)
>   }
>   #endif
>   
> +#ifdef CONFIG_PM_SLEEP
> +static int mxc_jpeg_suspend(struct device *dev)
> +{
> +	struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> +
> +	v4l2_m2m_suspend(jpeg->m2m_dev);
> +	return pm_runtime_force_suspend(dev);
> +}
> +
> +static int mxc_jpeg_resume(struct device *dev)
> +{
> +	struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> +	int ret;
> +
> +	ret = pm_runtime_force_resume(dev);
> +	if (ret < 0)
> +		return ret;
> +
> +	v4l2_m2m_resume(jpeg->m2m_dev);
> +	return ret;
> +}
> +#endif
> +
>   static const struct dev_pm_ops	mxc_jpeg_pm_ops = {
>   	SET_RUNTIME_PM_OPS(mxc_jpeg_runtime_suspend,
>   			   mxc_jpeg_runtime_resume, NULL)
> +	SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
>   };
>   
>   static int mxc_jpeg_remove(struct platform_device *pdev)

      reply	other threads:[~2022-04-23  0:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-06  9:47 [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg Ming Qian
2022-04-23  0:52 ` mirela.rabulea [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d6ac234f-c21b-b583-f375-1e7cbdd89adf@oss.nxp.com \
    --to=mirela.rabulea@oss.nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=hverkuil-cisco@xs4all.nl \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=ming.qian@nxp.com \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).