* [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg
@ 2022-04-06 9:47 Ming Qian
2022-04-23 0:52 ` mirela.rabulea
0 siblings, 1 reply; 2+ messages in thread
From: Ming Qian @ 2022-04-06 9:47 UTC (permalink / raw)
To: mchehab, shawnguo, s.hauer, mirela.rabulea
Cc: hverkuil-cisco, kernel, festevam, linux-imx, linux-media,
linux-kernel, devicetree, linux-arm-kernel
Wait finishing jpeg job before system sleep,
otherwise the encoding/decoding can't be resumed after suspend.
Signed-off-by: Ming Qian <ming.qian@nxp.com>
---
.../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
index ccc26372e178..3df51d866011 100644
--- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
+++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -2356,9 +2356,33 @@ static int mxc_jpeg_runtime_suspend(struct device *dev)
}
#endif
+#ifdef CONFIG_PM_SLEEP
+static int mxc_jpeg_suspend(struct device *dev)
+{
+ struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
+
+ v4l2_m2m_suspend(jpeg->m2m_dev);
+ return pm_runtime_force_suspend(dev);
+}
+
+static int mxc_jpeg_resume(struct device *dev)
+{
+ struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
+ int ret;
+
+ ret = pm_runtime_force_resume(dev);
+ if (ret < 0)
+ return ret;
+
+ v4l2_m2m_resume(jpeg->m2m_dev);
+ return ret;
+}
+#endif
+
static const struct dev_pm_ops mxc_jpeg_pm_ops = {
SET_RUNTIME_PM_OPS(mxc_jpeg_runtime_suspend,
mxc_jpeg_runtime_resume, NULL)
+ SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
};
static int mxc_jpeg_remove(struct platform_device *pdev)
--
2.33.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg
2022-04-06 9:47 [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg Ming Qian
@ 2022-04-23 0:52 ` mirela.rabulea
0 siblings, 0 replies; 2+ messages in thread
From: mirela.rabulea @ 2022-04-23 0:52 UTC (permalink / raw)
To: Ming Qian, mchehab, shawnguo, s.hauer
Cc: hverkuil-cisco, kernel, festevam, linux-imx, linux-media,
linux-kernel, devicetree, linux-arm-kernel
On 06.04.2022 12:47, Ming Qian wrote:
> Wait finishing jpeg job before system sleep,
> otherwise the encoding/decoding can't be resumed after suspend.
>
> Signed-off-by: Ming Qian <ming.qian@nxp.com>
Reviewed-by: Mirela Rabulea <mirela.rabulea@nxp.com>
> ---
> .../media/platform/nxp/imx-jpeg/mxc-jpeg.c | 24 +++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> index ccc26372e178..3df51d866011 100644
> --- a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> +++ b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
> @@ -2356,9 +2356,33 @@ static int mxc_jpeg_runtime_suspend(struct device *dev)
> }
> #endif
>
> +#ifdef CONFIG_PM_SLEEP
> +static int mxc_jpeg_suspend(struct device *dev)
> +{
> + struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> +
> + v4l2_m2m_suspend(jpeg->m2m_dev);
> + return pm_runtime_force_suspend(dev);
> +}
> +
> +static int mxc_jpeg_resume(struct device *dev)
> +{
> + struct mxc_jpeg_dev *jpeg = dev_get_drvdata(dev);
> + int ret;
> +
> + ret = pm_runtime_force_resume(dev);
> + if (ret < 0)
> + return ret;
> +
> + v4l2_m2m_resume(jpeg->m2m_dev);
> + return ret;
> +}
> +#endif
> +
> static const struct dev_pm_ops mxc_jpeg_pm_ops = {
> SET_RUNTIME_PM_OPS(mxc_jpeg_runtime_suspend,
> mxc_jpeg_runtime_resume, NULL)
> + SET_SYSTEM_SLEEP_PM_OPS(mxc_jpeg_suspend, mxc_jpeg_resume)
> };
>
> static int mxc_jpeg_remove(struct platform_device *pdev)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-23 0:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-06 9:47 [PATCH] media: imx-jpeg: Add pm-sleep support for imx-jpeg Ming Qian
2022-04-23 0:52 ` mirela.rabulea
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).