From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f169.google.com (mail-lj1-f169.google.com [209.85.208.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8E31A1836D7 for ; Fri, 14 Jun 2024 08:16:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718353011; cv=none; b=BqRCMhg9kKGDw0fz1WX15S4kJ7Abe6/l7Akaz9QMip+SDzYDg3x9Dr3RVBU2Rvan91MgkUL09A8Wru4FDc8XeM7V2yyVoehyI08KtMowdFZ1luG7S/xdbhekfTiFY1MP+QEW25fgX15KY3paf4n14iv0qTUHUYZkJbBLmA+TpZo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718353011; c=relaxed/simple; bh=nwE7qH3et0xBAyB0MTDxfmgBc8lMSr+/9XrUUisIykQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Oa9aKPwyuovdznhOch5Lv2bwbzA6kAkZXlOCBr/3Usb8vYj6/foeBjysy3yw0E8mD+dl5nJ7xxv6jgPq6wXwchDUpUXRhAYx3eEjZP7xXW3KSVwuDhFKnrbe5M3tZhymdDb8cHCulk6znkobA2FlJrOl5w35sHlkeB58oV1PA4w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=FrzuS8rP; arc=none smtp.client-ip=209.85.208.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="FrzuS8rP" Received: by mail-lj1-f169.google.com with SMTP id 38308e7fff4ca-2eaea28868dso25400521fa.3 for ; Fri, 14 Jun 2024 01:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1718353007; x=1718957807; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=eGmOzn1R1K16dkDMQJjEQ6wgWuo7/3DN6CTKOSNpNgg=; b=FrzuS8rPAQXu5iSoydjMExSyF0JG+sUoXV2L9KKhAr3STgNHLgSQy3RJ9DFISFD2jh RJIaamNFcx6y3QzFGFgMkyXtZyCs3N/Yd4Ri0WILV4SqrgR6wM5wx5icfRFqrqDfCBE8 GAZMoQdOeh1DYaZH/6ezzQCTaZPlDO/Xbj3lX3VijjB919wqP/MjTs56z4GU9mYxD394 swGKG+ChzC/dgP+gb1DZ2njamktxwk17e3LYy/vZJqeZxD2GiFgoVdwvgeNk9ewvYBGy bZ5MXFrOwPGAf9etp/CNI0NbjA01Pwt7qNSRL8k73q1bkneRy6TvuZp5RQrUdyxbzua6 Wg9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718353007; x=1718957807; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=eGmOzn1R1K16dkDMQJjEQ6wgWuo7/3DN6CTKOSNpNgg=; b=U/WTrT4DJRI79WdG/hEpAWrQ3IqVPB55BhQNKy0yyaquDzskqjfYMjqUAysHp8rWqT P1mNZs7tz1/ew41lLj5hy3MCbTBWw68p8ucFt9fg4WpT9sc1SLOt5TbuTgvF8NcKcOxe gEWU4Un1731vL2MktEZiaM1tjIQeV1QvmSZ4igpZBonUBorwji9l3P9CsBxBKF5JoiQY Z089MSTn3wo2dIitNK8cigHF843Y7eRRfzPWEtbndBIs3jHnB/p66XdWBQFYLaH+9rqP R/nXMKuESmdCkQ7n/+oPK8vqZDFhxEMvE3T3mnoNOr2USsxy7hq05lcp0GsM86KqN4sl 40Pw== X-Forwarded-Encrypted: i=1; AJvYcCVNXUfl8LqeGwHsK/Z5Kb796faHMi95YReJ9BLnzFytFOXA+LfMly2yN1ockmPjMKmPU6grErNb7HSWP5iYT+/2o4sHf9Qi7YuRrg== X-Gm-Message-State: AOJu0YwBPJn9uLRMz0s7zACcqM0e8+75Vc/UmhrvdF47oy3JDaDc+/YL 44ldxB16VRD1Lnm/Hsd80DwzxBcgRwq7uHKdL0XkfLtznh2Bk7wkA6gOWSUXDgI= X-Google-Smtp-Source: AGHT+IGdVz9wnYuErYpbzpZPBaxajSeBzfE2NEQMkvFihFynmrdBmCln5caVCr3TFMsMNsUcb/jj1Q== X-Received: by 2002:a2e:7d03:0:b0:2eb:e56c:c90a with SMTP id 38308e7fff4ca-2ec0e5c8c3dmr14354061fa.43.1718353006713; Fri, 14 Jun 2024 01:16:46 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-422f6127c6fsm51121795e9.24.2024.06.14.01.16.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 01:16:46 -0700 (PDT) Message-ID: Date: Fri, 14 Jun 2024 11:16:43 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC Content-Language: en-US To: Biju Das , "geert+renesas@glider.be" , "mturquette@baylibre.com" , "sboyd@kernel.org" , "robh@kernel.org" , "krzk+dt@kernel.org" , "conor+dt@kernel.org" , "lee@kernel.org" , "alexandre.belloni@bootlin.com" , "magnus.damm@gmail.com" Cc: "linux-renesas-soc@vger.kernel.org" , "linux-clk@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rtc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Claudiu Beznea References: <20240614071932.1014067-1-claudiu.beznea.uj@bp.renesas.com> <20240614071932.1014067-6-claudiu.beznea.uj@bp.renesas.com> From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Biju, On 14.06.2024 10:53, Biju Das wrote: > Hi Claudiu, > > Thanks for the patch. > >> -----Original Message----- >> From: linux-arm-kernel On Behalf Of Claudiu >> Sent: Friday, June 14, 2024 8:19 AM >> Subject: [PATCH 05/12] dt-bindings: rtc: renesas,rzg3s-rtc: Document the Renesas RZ/G3S RTC >> >> From: Claudiu Beznea >> >> Document the RTC IP (RTCA-3) available on the Renesas RZ/G3S SoC. >> >> Signed-off-by: Claudiu Beznea >> --- >> .../bindings/rtc/renesas,rzg3s-rtc.yaml | 60 +++++++++++++++++++ >> 1 file changed, 60 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> >> diff --git a/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> b/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> new file mode 100644 >> index 000000000000..0e17f8a36155 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/renesas,rzg3s-rtc.yaml >> @@ -0,0 +1,60 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/renesas,rzg3s-rtc.yaml# > > Please make it generic renesas,rtca3-rtc.yaml. Future SoCs may use this IP. > So use IP name instead. >From what I know the file name should correspond with the compatible that file was introduced with, and this one shouldn't be generic but SoC specific. Thank you, Claudiu Beznea > > Cheers, > Biju > >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Real Time Clock for Renesas RZ/G3S SoC >> + >> +maintainers: >> + - Claudiu Beznea >> + >> +properties: >> + compatible: >> + const: renesas,rzg3s-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 3 >> + >> + interrupt-names: >> + items: >> + - const: alarm >> + - const: period >> + - const: carry >> + >> + clocks: >> + maxItems: 1 >> + description: RTC counter clock >> + >> + clock-names: >> + maxItems: 1 >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - interrupt-names >> + - clocks >> + - clock-names >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + #include >> + >> + rtc: rtc@1004ec00 { >> + compatible = "renesas,rzg3s-rtc"; >> + reg = <0x1004ec00 0x400>; >> + interrupts = , >> + , >> + ; >> + interrupt-names = "alarm", "period", "carry"; >> + clocks = <&vbattclk>; >> + clock-names = "counter"; >> + status = "disabled"; >> + }; >> -- >> 2.39.2 >> >