* [PATCH 0/3] More RPMhPD levels + sm8550
@ 2023-05-17 13:19 Konrad Dybcio
2023-05-17 13:19 ` [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels Konrad Dybcio
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
Bring in missing RPMhPd levels from downstream and add ones we'll
need for GPU on SM8550.
Patch 1 adds the missing ones with an easy-to-read diff, patch 2
reformats the block and patch 3 adds the necessary levels to 8550 dt.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
Konrad Dybcio (3):
dt-bindings: power: qcom,rpmpd: add missing RPMH levels
dt-bindings: power: qcom,rpmpd: Format RPMh levels better
arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels
arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 +++++++++++++++++++++++++-------
include/dt-bindings/power/qcom-rpmpd.h | 38 +++++++++++++++++++++-------------
2 files changed, 52 insertions(+), 22 deletions(-)
---
base-commit: 065efa589871e93b6610c70c1e9de274ef1f1ba2
change-id: 20230517-topic-kailua-rpmhpd-d24c4c538c3a
Best regards,
--
Konrad Dybcio <konrad.dybcio@linaro.org>
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels
2023-05-17 13:19 [PATCH 0/3] More RPMhPD levels + sm8550 Konrad Dybcio
@ 2023-05-17 13:19 ` Konrad Dybcio
2023-05-17 19:53 ` Krzysztof Kozlowski
2023-05-17 13:19 ` [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better Konrad Dybcio
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
There are a lot of RPMh levels that we haven't included yet.. some
sadly turned out to be necessary, add them!
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
include/dt-bindings/power/qcom-rpmpd.h | 10 ++++++++++
1 file changed, 10 insertions(+)
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index 1bf8e87ecd7e..e34c01e650d6 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -209,18 +209,28 @@
/* SDM845 Power Domain performance levels */
#define RPMH_REGULATOR_LEVEL_RETENTION 16
#define RPMH_REGULATOR_LEVEL_MIN_SVS 48
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_D2 52
#define RPMH_REGULATOR_LEVEL_LOW_SVS_D1 56
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_D0 60
#define RPMH_REGULATOR_LEVEL_LOW_SVS 64
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_P1 72
#define RPMH_REGULATOR_LEVEL_LOW_SVS_L1 80
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_L2 96
#define RPMH_REGULATOR_LEVEL_SVS 128
#define RPMH_REGULATOR_LEVEL_SVS_L0 144
#define RPMH_REGULATOR_LEVEL_SVS_L1 192
#define RPMH_REGULATOR_LEVEL_SVS_L2 224
#define RPMH_REGULATOR_LEVEL_NOM 256
+#define RPMH_REGULATOR_LEVEL_NOM_L0 288
#define RPMH_REGULATOR_LEVEL_NOM_L1 320
#define RPMH_REGULATOR_LEVEL_NOM_L2 336
#define RPMH_REGULATOR_LEVEL_TURBO 384
+#define RPMH_REGULATOR_LEVEL_TURBO_L0 400
#define RPMH_REGULATOR_LEVEL_TURBO_L1 416
+#define RPMH_REGULATOR_LEVEL_TURBO_L2 432
+#define RPMH_REGULATOR_LEVEL_TURBO_L3 448
+#define RPMH_REGULATOR_LEVEL_SUPER_TURBO 464
+#define RPMH_REGULATOR_LEVEL_SUPER_TURBO_NO_CPR 480
/* MDM9607 Power Domains */
#define MDM9607_VDDCX 0
--
2.40.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better
2023-05-17 13:19 [PATCH 0/3] More RPMhPD levels + sm8550 Konrad Dybcio
2023-05-17 13:19 ` [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels Konrad Dybcio
@ 2023-05-17 13:19 ` Konrad Dybcio
2023-05-17 19:53 ` Krzysztof Kozlowski
2023-05-17 13:19 ` [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels Konrad Dybcio
2023-05-17 17:36 ` [PATCH 0/3] More RPMhPD levels + sm8550 Conor Dooley
3 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
After adding the missing levels with a nice, easy-to-read diff,
reformat the defines to make them nice to look at..
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
include/dt-bindings/power/qcom-rpmpd.h | 46 +++++++++++++++++-----------------
1 file changed, 23 insertions(+), 23 deletions(-)
diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h
index e34c01e650d6..4ede277d20e1 100644
--- a/include/dt-bindings/power/qcom-rpmpd.h
+++ b/include/dt-bindings/power/qcom-rpmpd.h
@@ -207,29 +207,29 @@
#define SC8280XP_XO 15
/* SDM845 Power Domain performance levels */
-#define RPMH_REGULATOR_LEVEL_RETENTION 16
-#define RPMH_REGULATOR_LEVEL_MIN_SVS 48
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_D2 52
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_D1 56
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_D0 60
-#define RPMH_REGULATOR_LEVEL_LOW_SVS 64
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_P1 72
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_L1 80
-#define RPMH_REGULATOR_LEVEL_LOW_SVS_L2 96
-#define RPMH_REGULATOR_LEVEL_SVS 128
-#define RPMH_REGULATOR_LEVEL_SVS_L0 144
-#define RPMH_REGULATOR_LEVEL_SVS_L1 192
-#define RPMH_REGULATOR_LEVEL_SVS_L2 224
-#define RPMH_REGULATOR_LEVEL_NOM 256
-#define RPMH_REGULATOR_LEVEL_NOM_L0 288
-#define RPMH_REGULATOR_LEVEL_NOM_L1 320
-#define RPMH_REGULATOR_LEVEL_NOM_L2 336
-#define RPMH_REGULATOR_LEVEL_TURBO 384
-#define RPMH_REGULATOR_LEVEL_TURBO_L0 400
-#define RPMH_REGULATOR_LEVEL_TURBO_L1 416
-#define RPMH_REGULATOR_LEVEL_TURBO_L2 432
-#define RPMH_REGULATOR_LEVEL_TURBO_L3 448
-#define RPMH_REGULATOR_LEVEL_SUPER_TURBO 464
+#define RPMH_REGULATOR_LEVEL_RETENTION 16
+#define RPMH_REGULATOR_LEVEL_MIN_SVS 48
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_D2 52
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_D1 56
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_D0 60
+#define RPMH_REGULATOR_LEVEL_LOW_SVS 64
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_P1 72
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_L1 80
+#define RPMH_REGULATOR_LEVEL_LOW_SVS_L2 96
+#define RPMH_REGULATOR_LEVEL_SVS 128
+#define RPMH_REGULATOR_LEVEL_SVS_L0 144
+#define RPMH_REGULATOR_LEVEL_SVS_L1 192
+#define RPMH_REGULATOR_LEVEL_SVS_L2 224
+#define RPMH_REGULATOR_LEVEL_NOM 256
+#define RPMH_REGULATOR_LEVEL_NOM_L0 288
+#define RPMH_REGULATOR_LEVEL_NOM_L1 320
+#define RPMH_REGULATOR_LEVEL_NOM_L2 336
+#define RPMH_REGULATOR_LEVEL_TURBO 384
+#define RPMH_REGULATOR_LEVEL_TURBO_L0 400
+#define RPMH_REGULATOR_LEVEL_TURBO_L1 416
+#define RPMH_REGULATOR_LEVEL_TURBO_L2 432
+#define RPMH_REGULATOR_LEVEL_TURBO_L3 448
+#define RPMH_REGULATOR_LEVEL_SUPER_TURBO 464
#define RPMH_REGULATOR_LEVEL_SUPER_TURBO_NO_CPR 480
/* MDM9607 Power Domains */
--
2.40.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels
2023-05-17 13:19 [PATCH 0/3] More RPMhPD levels + sm8550 Konrad Dybcio
2023-05-17 13:19 ` [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels Konrad Dybcio
2023-05-17 13:19 ` [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better Konrad Dybcio
@ 2023-05-17 13:19 ` Konrad Dybcio
2023-05-17 13:25 ` Dmitry Baryshkov
2023-05-17 17:36 ` [PATCH 0/3] More RPMhPD levels + sm8550 Conor Dooley
3 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:19 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel,
Konrad Dybcio
We need more granularity for things like the GPU. Add the missing levels.
This unfortunately requires some re-indexing, resulting in an ugly diff.
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++--------
1 file changed, 28 insertions(+), 8 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 6e9bad8f6f33..0c987dd4e4e5 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 {
opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
};
- rpmhpd_opp_low_svs: opp3 {
+ rpmhpd_opp_lov_svs_d2: opp3 {
+ opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
+ };
+
+ rpmhpd_opp_lov_svs_d1: opp4 {
+ opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D1>;
+ };
+
+ rpmhpd_opp_lov_svs_d0: opp5 {
+ opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D0>;
+ };
+
+ rpmhpd_opp_low_svs: opp6 {
opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS>;
};
- rpmhpd_opp_svs: opp4 {
+ rpmhpd_opp_low_svs_l1: opp7 {
+ opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_L1>;
+ };
+
+ rpmhpd_opp_svs: opp8 {
opp-level = <RPMH_REGULATOR_LEVEL_SVS>;
};
- rpmhpd_opp_svs_l1: opp5 {
+ rpmhpd_opp_svs_l0: opp9 {
+ opp-level = <RPMH_REGULATOR_LEVEL_SVS_L0>;
+ };
+
+ rpmhpd_opp_svs_l1: opp10 {
opp-level = <RPMH_REGULATOR_LEVEL_SVS_L1>;
};
- rpmhpd_opp_nom: opp6 {
+ rpmhpd_opp_nom: opp11 {
opp-level = <RPMH_REGULATOR_LEVEL_NOM>;
};
- rpmhpd_opp_nom_l1: opp7 {
+ rpmhpd_opp_nom_l1: opp12 {
opp-level = <RPMH_REGULATOR_LEVEL_NOM_L1>;
};
- rpmhpd_opp_nom_l2: opp8 {
+ rpmhpd_opp_nom_l2: opp13 {
opp-level = <RPMH_REGULATOR_LEVEL_NOM_L2>;
};
- rpmhpd_opp_turbo: opp9 {
+ rpmhpd_opp_turbo: opp14 {
opp-level = <RPMH_REGULATOR_LEVEL_TURBO>;
};
- rpmhpd_opp_turbo_l1: opp10 {
+ rpmhpd_opp_turbo_l1: opp15 {
opp-level = <RPMH_REGULATOR_LEVEL_TURBO_L1>;
};
};
--
2.40.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels
2023-05-17 13:19 ` [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels Konrad Dybcio
@ 2023-05-17 13:25 ` Dmitry Baryshkov
2023-05-17 13:25 ` Konrad Dybcio
0 siblings, 1 reply; 10+ messages in thread
From: Dmitry Baryshkov @ 2023-05-17 13:25 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marijn Suijten, linux-arm-msm, devicetree,
linux-kernel
On Wed, 17 May 2023 at 16:20, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>
> We need more granularity for things like the GPU. Add the missing levels.
>
> This unfortunately requires some re-indexing, resulting in an ugly diff.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++--------
> 1 file changed, 28 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 6e9bad8f6f33..0c987dd4e4e5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 {
> opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
> };
>
> - rpmhpd_opp_low_svs: opp3 {
> + rpmhpd_opp_lov_svs_d2: opp3 {
> + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
> + };
>
Maybe we should stop using the indices for OPP entries and switch to
encoding levels instead?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels
2023-05-17 13:25 ` Dmitry Baryshkov
@ 2023-05-17 13:25 ` Konrad Dybcio
2023-05-17 13:28 ` Konrad Dybcio
0 siblings, 1 reply; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:25 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marijn Suijten, linux-arm-msm, devicetree,
linux-kernel
On 17.05.2023 15:25, Dmitry Baryshkov wrote:
> On Wed, 17 May 2023 at 16:20, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>
>> We need more granularity for things like the GPU. Add the missing levels.
>>
>> This unfortunately requires some re-indexing, resulting in an ugly diff.
>>
>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>> ---
>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++--------
>> 1 file changed, 28 insertions(+), 8 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> index 6e9bad8f6f33..0c987dd4e4e5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>> @@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 {
>> opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
>> };
>>
>> - rpmhpd_opp_low_svs: opp3 {
>> + rpmhpd_opp_lov_svs_d2: opp3 {
>> + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
>> + };
>>
>
> Maybe we should stop using the indices for OPP entries and switch to
> encoding levels instead?
I think we should just retire this and register a hardcoded OPP table
in the .c driver.
Konrad
>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels
2023-05-17 13:25 ` Konrad Dybcio
@ 2023-05-17 13:28 ` Konrad Dybcio
0 siblings, 0 replies; 10+ messages in thread
From: Konrad Dybcio @ 2023-05-17 13:28 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marijn Suijten, linux-arm-msm, devicetree,
linux-kernel
On 17.05.2023 15:25, Konrad Dybcio wrote:
>
>
> On 17.05.2023 15:25, Dmitry Baryshkov wrote:
>> On Wed, 17 May 2023 at 16:20, Konrad Dybcio <konrad.dybcio@linaro.org> wrote:
>>>
>>> We need more granularity for things like the GPU. Add the missing levels.
>>>
>>> This unfortunately requires some re-indexing, resulting in an ugly diff.
>>>
>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
>>> ---
>>> arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++--------
>>> 1 file changed, 28 insertions(+), 8 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> index 6e9bad8f6f33..0c987dd4e4e5 100644
>>> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
>>> @@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 {
>>> opp-level = <RPMH_REGULATOR_LEVEL_MIN_SVS>;
>>> };
>>>
>>> - rpmhpd_opp_low_svs: opp3 {
>>> + rpmhpd_opp_lov_svs_d2: opp3 {
>>> + opp-level = <RPMH_REGULATOR_LEVEL_LOW_SVS_D2>;
>>> + };
>>>
>>
>> Maybe we should stop using the indices for OPP entries and switch to
>> encoding levels instead?
> I think we should just retire this and register a hardcoded OPP table
> in the .c driver.
But then we don't have any required-opps to reference... yeah the nodes
should probably be renamed to opp-<levelvalue>
Konrad
>
> Konrad
>>
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 0/3] More RPMhPD levels + sm8550
2023-05-17 13:19 [PATCH 0/3] More RPMhPD levels + sm8550 Konrad Dybcio
` (2 preceding siblings ...)
2023-05-17 13:19 ` [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels Konrad Dybcio
@ 2023-05-17 17:36 ` Conor Dooley
3 siblings, 0 replies; 10+ messages in thread
From: Conor Dooley @ 2023-05-17 17:36 UTC (permalink / raw)
To: Konrad Dybcio
Cc: Andy Gross, Bjorn Andersson, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Marijn Suijten, linux-arm-msm, devicetree,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 685 bytes --]
On Wed, May 17, 2023 at 03:19:42PM +0200, Konrad Dybcio wrote:
> Bring in missing RPMhPd levels from downstream and add ones we'll
> need for GPU on SM8550.
>
> Patch 1 adds the missing ones with an easy-to-read diff, patch 2
> reformats the block and patch 3 adds the necessary levels to 8550 dt.
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
> Konrad Dybcio (3):
> dt-bindings: power: qcom,rpmpd: add missing RPMH levels
> dt-bindings: power: qcom,rpmpd: Format RPMh levels better
If you're going to add these defines regardless of a to change your
approach:
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels
2023-05-17 13:19 ` [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels Konrad Dybcio
@ 2023-05-17 19:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-17 19:53 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel
On 17/05/2023 15:19, Konrad Dybcio wrote:
> There are a lot of RPMh levels that we haven't included yet.. some
> sadly turned out to be necessary, add them!
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better
2023-05-17 13:19 ` [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better Konrad Dybcio
@ 2023-05-17 19:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 10+ messages in thread
From: Krzysztof Kozlowski @ 2023-05-17 19:53 UTC (permalink / raw)
To: Konrad Dybcio, Andy Gross, Bjorn Andersson, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Marijn Suijten, linux-arm-msm, devicetree, linux-kernel
On 17/05/2023 15:19, Konrad Dybcio wrote:
> After adding the missing levels with a nice, easy-to-read diff,
> reformat the defines to make them nice to look at..
>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2023-05-17 19:54 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-05-17 13:19 [PATCH 0/3] More RPMhPD levels + sm8550 Konrad Dybcio
2023-05-17 13:19 ` [PATCH 1/3] dt-bindings: power: qcom,rpmpd: add missing RPMH levels Konrad Dybcio
2023-05-17 19:53 ` Krzysztof Kozlowski
2023-05-17 13:19 ` [PATCH 2/3] dt-bindings: power: qcom,rpmpd: Format RPMh levels better Konrad Dybcio
2023-05-17 19:53 ` Krzysztof Kozlowski
2023-05-17 13:19 ` [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels Konrad Dybcio
2023-05-17 13:25 ` Dmitry Baryshkov
2023-05-17 13:25 ` Konrad Dybcio
2023-05-17 13:28 ` Konrad Dybcio
2023-05-17 17:36 ` [PATCH 0/3] More RPMhPD levels + sm8550 Conor Dooley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).