From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49D1FC77B7F for ; Wed, 17 May 2023 13:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229707AbjEQN0E (ORCPT ); Wed, 17 May 2023 09:26:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231276AbjEQNZ7 (ORCPT ); Wed, 17 May 2023 09:25:59 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 54B8A76BA for ; Wed, 17 May 2023 06:25:57 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id 2adb3069b0e04-4f00d41df22so10464369e87.1 for ; Wed, 17 May 2023 06:25:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684329955; x=1686921955; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hp2kPkd9ZRMUETaRmMSuFYktMxLqAJpnJYXLcv1M178=; b=DOZPjNgiUJXEqkKXk4r1H9T/X1RO3QycJmsfSKRJDT0ywuMtmEThWzay9RJd/02bXz K9crsDQ4XBjHukL47XolUY4KUzlkAYHS7y6rZWxTl3Q6+L1VtVfqc1mv3ALiq+MsnK17 9UrwxgcpNEjYK9g8xDGE3hkJMcO2LzhZYl6pzGg7zQMUxvQ9EiUnou/9DP7328Y7e/JY P8CGC/9waKK5Tl0OAWTOFpP5R6/h+gX50ThUEW5a6KRi29F0BIO6gXTLZqShxKiZS0BD 0REdjaGjkZr5U5zcNockugIowaJhAos0A22cgSGjAadjb7jVzF5u2GvaMX8ndcrNzSmQ DhOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684329955; x=1686921955; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hp2kPkd9ZRMUETaRmMSuFYktMxLqAJpnJYXLcv1M178=; b=R9pIfQao4NaCEtZ/xxJatbCDviNwwg3FfFCYO2kW8e4q9RuIhCqOX0UisY0k0qJbGq mdZ4Duw5yXs7tqaj7bTvu1tpgleKgi5flspxXtqEqEtvqOLAkGO7A6c05a7IRlM/9w4e BBjLNesPeGAPKzefaN3gobraG9VHIuE6S50dXf2rOmiucNDCmp8JhHfl2NdMegQgjG9K o6Ykhw7Tduis1filjPn1D1Rw92bwLO8TJVTtHQa6hlo3VMoW38b72xvMCF/xaJt7E2Px MczM4Wiel+suqrSQLo3EJplbSPEgtwcI/RsT4hL4pjwNuDl/heJtcd05bgy2/GjreJla 21rg== X-Gm-Message-State: AC+VfDyNZEhw7nIkRp80XFHjzrFtJGdFVNX/UN8F0Mgkk7T0yqd42W1j YVqGSlHHhPw78Zi6ObvGD3uHoQ== X-Google-Smtp-Source: ACHHUZ66A49Q8pGQ0boPoaDUf9DyQZ5nKb/JogEyVnTLZ5Rb2ZpAmgkYB3QVLfG1JUif5LnjOcdTPw== X-Received: by 2002:a2e:b623:0:b0:2ac:7fc5:e4a9 with SMTP id s3-20020a2eb623000000b002ac7fc5e4a9mr697973ljn.16.1684329955606; Wed, 17 May 2023 06:25:55 -0700 (PDT) Received: from ?IPV6:2a00:f41:c93:874f:be7b:fb6c:26f9:307c? ([2a00:f41:c93:874f:be7b:fb6c:26f9:307c]) by smtp.gmail.com with ESMTPSA id n14-20020a2e904e000000b002a8ac166e55sm4594646ljg.44.2023.05.17.06.25.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 May 2023 06:25:55 -0700 (PDT) Message-ID: Date: Wed, 17 May 2023 15:25:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH 3/3] arm64: dts: qcom: sm8550: Add missing RPMhPD OPP levels Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230517-topic-kailua-rpmhpd-v1-0-cd3013d051a6@linaro.org> <20230517-topic-kailua-rpmhpd-v1-3-cd3013d051a6@linaro.org> From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 17.05.2023 15:25, Dmitry Baryshkov wrote: > On Wed, 17 May 2023 at 16:20, Konrad Dybcio wrote: >> >> We need more granularity for things like the GPU. Add the missing levels. >> >> This unfortunately requires some re-indexing, resulting in an ugly diff. >> >> Signed-off-by: Konrad Dybcio >> --- >> arch/arm64/boot/dts/qcom/sm8550.dtsi | 36 ++++++++++++++++++++++++++++-------- >> 1 file changed, 28 insertions(+), 8 deletions(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi >> index 6e9bad8f6f33..0c987dd4e4e5 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi >> @@ -3616,35 +3616,55 @@ rpmhpd_opp_min_svs: opp2 { >> opp-level = ; >> }; >> >> - rpmhpd_opp_low_svs: opp3 { >> + rpmhpd_opp_lov_svs_d2: opp3 { >> + opp-level = ; >> + }; >> > > Maybe we should stop using the indices for OPP entries and switch to > encoding levels instead? I think we should just retire this and register a hardcoded OPP table in the .c driver. Konrad >