From: William Qiu <william.qiu@starfivetech.com>
To: Emil Renner Berthing <emil.renner.berthing@canonical.com>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-riscv@lists.infradead.org>, <linux-mmc@vger.kernel.org>
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Rob Herring <robh+dt@kernel.org>,
Jaehoon Chung <jh80.chung@samsung.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>
Subject: Re: [PATCH v2 3/3] riscv: dts: starfive: Drop unused properties and limit frquency
Date: Wed, 13 Sep 2023 18:50:31 +0800 [thread overview]
Message-ID: <d6bf4465-28a7-418f-47c9-7189fa746ca0@starfivetech.com> (raw)
In-Reply-To: <CAJM55Z-_V6Ty61u1bF=BziBRwn7bzTygE02g_4B3UW9tG4yikw@mail.gmail.com>
On 2023/9/12 21:23, Emil Renner Berthing wrote:
> William Qiu wrote:
>> Drop unused properties and limit cclk_in to 50M, thus cancelling the
>> internal frequency and adopting the by-pass mode.
>
> That's two unrelated changes which should really be in different patches. But
> again the hardware still has the relevant field in the syscon registers even if
> the driver doesn't use it, so maybe just leave them and just keep this patch
> adding the assigned-clock* properties.
>
> /Emil
>
>>
Will update.
Best Regards,
William
>> Signed-off-by: William Qiu <william.qiu@starfivetech.com>
>> ---
>> .../riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi | 4 ++++
>> arch/riscv/boot/dts/starfive/jh7110.dtsi | 2 --
>> 2 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> index d79f94432b27..d1f2ec308bca 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110-starfive-visionfive-2.dtsi
>> @@ -205,6 +205,8 @@ &i2c6 {
>>
>> &mmc0 {
>> max-frequency = <100000000>;
>> + assigned-clocks = <&syscrg JH7110_SYSCLK_SDIO0_SDCARD>;
>> + assigned-clock-rates = <50000000>;
>> bus-width = <8>;
>> cap-mmc-highspeed;
>> mmc-ddr-1_8v;
>> @@ -221,6 +223,8 @@ &mmc0 {
>>
>> &mmc1 {
>> max-frequency = <100000000>;
>> + assigned-clocks = <&syscrg JH7110_SYSCLK_SDIO1_SDCARD>;
>> + assigned-clock-rates = <50000000>;
>> bus-width = <4>;
>> no-sdio;
>> no-mmc;
>> diff --git a/arch/riscv/boot/dts/starfive/jh7110.dtsi b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> index e85464c328d0..7b8e841aeef8 100644
>> --- a/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> +++ b/arch/riscv/boot/dts/starfive/jh7110.dtsi
>> @@ -870,7 +870,6 @@ mmc0: mmc@16010000 {
>> fifo-depth = <32>;
>> fifo-watermark-aligned;
>> data-addr = <0>;
>> - starfive,sysreg = <&sys_syscon 0x14 0x1a 0x7c000000>;
>> status = "disabled";
>> };
>>
>> @@ -886,7 +885,6 @@ mmc1: mmc@16020000 {
>> fifo-depth = <32>;
>> fifo-watermark-aligned;
>> data-addr = <0>;
>> - starfive,sysreg = <&sys_syscon 0x9c 0x1 0x3e>;
>> status = "disabled";
>> };
>>
>> --
>> 2.34.1
>>
>>
>> _______________________________________________
>> linux-riscv mailing list
>> linux-riscv@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2023-09-13 10:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-12 8:13 [PATCH 1/3] dt-bindings: mmc: Remove properties from required William Qiu
2023-09-12 8:13 ` [PATCH 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-09-12 8:13 ` [PATCH 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
2023-09-12 8:13 ` [PATCH v2 0/3] Change tuning implementation William Qiu
2023-09-12 17:55 ` Rob Herring
2023-09-12 8:14 ` [PATCH v2 1/3] dt-bindings: mmc: Remove properties from required William Qiu
2023-09-12 16:39 ` Conor Dooley
2023-09-12 8:14 ` [PATCH v2 2/3] mmc: starfive: Change tuning implementation William Qiu
2023-09-12 13:20 ` Emil Renner Berthing
2023-09-12 8:14 ` [PATCH v2 3/3] riscv: dts: starfive: Drop unused properties and limit frquency William Qiu
2023-09-12 13:23 ` Emil Renner Berthing
2023-09-13 10:50 ` William Qiu [this message]
2023-09-12 9:12 ` [PATCH 1/3] dt-bindings: mmc: Remove properties from required Emil Renner Berthing
2023-09-12 16:40 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6bf4465-28a7-418f-47c9-7189fa746ca0@starfivetech.com \
--to=william.qiu@starfivetech.com \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=emil.renner.berthing@canonical.com \
--cc=jh80.chung@samsung.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).